From: Rob Herring <robh@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
David Heidelberg <david@ixit.cz>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
John Stultz <john.stultz@linaro.org>,
Vinay Simha BN <simhavcs@gmail.com>
Subject: Re: [PATCH v2 2/9] dt-bindings: battery: Add temperature properties
Date: Mon, 13 Jul 2020 17:46:04 -0600 [thread overview]
Message-ID: <20200713234604.GA935472@bogus> (raw)
In-Reply-To: <20200607144113.10202-3-digetx@gmail.com>
On Sun, Jun 07, 2020 at 05:41:06PM +0300, Dmitry Osipenko wrote:
> Document generic battery temperature properties.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> .../devicetree/bindings/power/supply/battery.txt | 10 ++++++++++
> 1 file changed, 10 insertions(+)
This is close to being converted to schema:
https://lore.kernel.org/linux-pm/20200707212914.31540-1-r-rivera-matos@ti.com/
> diff --git a/Documentation/devicetree/bindings/power/supply/battery.txt b/Documentation/devicetree/bindings/power/supply/battery.txt
> index 5e29595edd74..e0c35eff9d3f 100644
> --- a/Documentation/devicetree/bindings/power/supply/battery.txt
> +++ b/Documentation/devicetree/bindings/power/supply/battery.txt
> @@ -45,6 +45,16 @@ Optional Properties:
> and corresponding battery internal resistance percent, which is used to look
> up the resistance percent according to current temperature to get a accurate
> batterty internal resistance in different temperatures.
> + - temperature-ambient-min-alert-celsius: Alert when ambient temperature of a
> + battery is lower than threshold value.
> + - temperature-ambient-max-alert-celsius: Alert when ambient temperature of a
> + battery is higher than threshold value.
> + - temperature-min-alert-celsius: Alert when battery temperature is lower
> + than threshold value.
> + - temperature-max-alert-celsius: Alert when battery temperature is higher
> + than threshold value.
> + - temperature-min-celsius: minimum temperature at which battery can operate
> + - temperature-max-celsius: maximum temperature at which battery can operate
Perhaps 'temperature' is redundant since we have units.
Perhaps do <min max> properties given specifying only min or max is
probably not valid?
Rob
next prev parent reply other threads:[~2020-07-13 23:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-07 14:41 [PATCH v2 0/9] Summit SMB3xx driver & device-tree Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 1/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx Dmitry Osipenko
2020-07-13 23:39 ` Rob Herring
2020-07-16 17:24 ` Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 2/9] dt-bindings: battery: Add temperature properties Dmitry Osipenko
2020-07-13 23:46 ` Rob Herring [this message]
2020-07-16 17:24 ` Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 3/9] power: supply: Support battery temperature device-tree properties Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 4/9] power: supply: smb347-charger: Use resource-managed API Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 5/9] power: supply: smb347-charger: Implement device-tree support Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 6/9] power: supply: smb347-charger: Support SMB345 and SMB358 Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 7/9] power: supply: smb347-charger: Remove virtual smb347-battery Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 8/9] power: supply: smb347-charger: Replace mutex with IRQ disable/enable Dmitry Osipenko
2020-06-07 14:41 ` [PATCH v2 9/9] ARM: dts: qcom: apq8064-nexus7: Add SMB345 charger node Dmitry Osipenko
2020-07-08 7:42 ` [PATCH v2 0/9] Summit SMB3xx driver & device-tree Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713234604.GA935472@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=john.stultz@linaro.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=simhavcs@gmail.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.