Re: [PATCH v2 1/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx

From: Dmitry Osipenko <digetx@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	David Heidelberg <david@ixit.cz>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	Jonghwa Lee <jonghwa3.lee@samsung.com>,
	John Stultz <john.stultz@linaro.org>,
	Vinay Simha BN <simhavcs@gmail.com>
Subject: Re: [PATCH v2 1/9] dt-bindings: power: supply: Add device-tree binding for Summit SMB3xx
Date: Thu, 16 Jul 2020 20:24:33 +0300	[thread overview]
Message-ID: <8427d000-f803-6f17-3f87-fae17aceb24a@gmail.com> (raw)
In-Reply-To: <20200713233959.GA928559@bogus>

14.07.2020 02:39, Rob Herring пишет:
> On Sun, Jun 07, 2020 at 05:41:05PM +0300, Dmitry Osipenko wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Summit SMB3xx series is a Programmable Switching Li+ Battery Charger.
>> This patch adds device-tree binding for Summit SMB345, SMB347 and SMB358
>> chargers.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>> ---
>>  .../power/supply/summit,smb347-charger.yaml   | 165 ++++++++++++++++++
>>  .../dt-bindings/power/summit,smb347-charger.h |  19 ++
>>  2 files changed, 184 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
>>  create mode 100644 include/dt-bindings/power/summit,smb347-charger.h
>>
>> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
>> new file mode 100644
>> index 000000000000..eea0a6398c95
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
>> @@ -0,0 +1,165 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/power/supply/summit,smb347-charger.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>> +
>> +title: Battery charger driver for SMB345, SMB347 and SMB358
>> +
>> +maintainers:
>> +  - David Heidelberg <david@ixit.cz>
>> +  - Dmitry Osipenko <digetx@gmail.com>
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - summit,smb345
>> +      - summit,smb347
>> +      - summit,smb358
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  monitored-battery:
>> +    description: phandle to the battery node
>> +    $ref: /schemas/types.yaml#/definitions/phandle
>> +
>> +  summit,enable-usb-charging:
>> +    type: boolean
>> +    description: Enable charging through USB.
>> +
>> +  summit,enable-otg-charging:
>> +    type: boolean
>> +    description: Provide power for USB OTG
>> +
>> +  summit,enable-mains-charging:
>> +    type: boolean
>> +    description: Enable charging through mains
>> +
>> +  summit,enable-charge-control:
>> +    description: Enable charging control
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
>> +      - enum:
>> +          - 0 # SMB3XX_CHG_ENABLE_SW SW (I2C interface)
>> +          - 1 # SMB3XX_CHG_ENABLE_PIN_ACTIVE_LOW Pin control (Active Low)
>> +          - 2 # SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH Pin control (Active High)
>> +
>> +  summit,fast-voltage-threshold-microvolt:
>> +    description: Voltage threshold to transit to fast charge mode (in uV)
>> +    allOf:
>> +      - $ref: /schemas/types.yaml#/definitions/uint32
> 
> Anything with a standard unit suffix already has a type, so drop.

I'll correct it in the next revision, thanks!