From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly
Date: Wed, 15 Jul 2020 16:31:16 +0200 [thread overview]
Message-ID: <20200715163116.3215cb45@ibm-vm> (raw)
In-Reply-To: <20200714041905.12848-1-sean.j.christopherson@intel.com>
On Mon, 13 Jul 2020 21:19:05 -0700
Sean Christopherson <sean.j.christopherson@intel.com> wrote:
> Replace a '%' with a '$' to encode a literal in when initializing CR4.
> This fixes the build on i386 as gcc complains about a non-existent
> register.
>
> x86/cstart.S: Assembler messages:
> x86/cstart.S:128: Error: bad register name `%(1<<4)'
> Makefile:101: recipe for target 'x86/cstart.o' failed
>
> Fixes: d86ef58519645 ("cstart: do not assume CR4 starts as zero")
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>
> ---
> x86/cstart.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/x86/cstart.S b/x86/cstart.S
> index e63e4e2..c0efc5f 100644
> --- a/x86/cstart.S
> +++ b/x86/cstart.S
> @@ -125,7 +125,7 @@ start:
> jmpl $8, $start32
>
> prepare_32:
> - mov %(1 << 4), %eax // pse
> + mov $(1 << 4), %eax // pse
> mov %eax, %cr4
>
> mov $pt, %eax
prev parent reply other threads:[~2020-07-15 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 4:19 [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly Sean Christopherson
2020-07-14 4:37 ` Nadav Amit
2020-07-15 14:31 ` Claudio Imbrenda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715163116.3215cb45@ibm-vm \
--to=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.