All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nadav Amit <nadav.amit@gmail.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly
Date: Mon, 13 Jul 2020 21:37:22 -0700	[thread overview]
Message-ID: <AB5EF337-A271-4440-B716-BEB4AF70F5FB@gmail.com> (raw)
In-Reply-To: <20200714041905.12848-1-sean.j.christopherson@intel.com>

> On Jul 13, 2020, at 9:19 PM, Sean Christopherson <sean.j.christopherson@intel.com> wrote:
> 
> Replace a '%' with a '$' to encode a literal in when initializing CR4.
> This fixes the build on i386 as gcc complains about a non-existent
> register.

Reviewed-by: Nadav Amit <namit@vmware.com>

( I should have noticed it before )

  reply	other threads:[~2020-07-14  4:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14  4:19 [kvm-unit-tests PATCH] cstart: Fix typo in i386's cstart assembly Sean Christopherson
2020-07-14  4:37 ` Nadav Amit [this message]
2020-07-15 14:31 ` Claudio Imbrenda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AB5EF337-A271-4440-B716-BEB4AF70F5FB@gmail.com \
    --to=nadav.amit@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.