From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: hch@lst.de, iommu@lists.linux-foundation.org,
jonathan.lemon@gmail.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, baolu.lu@linux.intel.com,
dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices
Date: Wed, 22 Jul 2020 14:48:55 +0200 [thread overview]
Message-ID: <20200722124854.GZ27672@8bytes.org> (raw)
In-Reply-To: <ad3f66c8-7772-731d-cd0a-c5d6d46297cb@arm.com>
On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote:
> Oh bother - yes, this could have been masking all manner of bugs. That
> system will presumably also break if you managed to exhaust the 32-bit IOVA
> space such that the allocator moved up to the higher range anyway, or if you
> passed the XHCI through to a VM with a sufficiently wacky GPA layout, but I
> guess those are cases that simply nobody's run into yet.
>
> Does the firmware actually report any upper address constraint such that
> Sebastian's IVRS aperture patches might help?
No, it doesn't. I am not sure what the best way is to get these issues
found and fixed. I doubt they will be getting fixed when the allocation
pattern isn't changed, maybe we can put your changes behind a config
variable and start testing/reporting bugs/etc.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jonathan.lemon@gmail.com,
dwmw2@infradead.org, hch@lst.de,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices
Date: Wed, 22 Jul 2020 14:48:55 +0200 [thread overview]
Message-ID: <20200722124854.GZ27672@8bytes.org> (raw)
In-Reply-To: <ad3f66c8-7772-731d-cd0a-c5d6d46297cb@arm.com>
On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote:
> Oh bother - yes, this could have been masking all manner of bugs. That
> system will presumably also break if you managed to exhaust the 32-bit IOVA
> space such that the allocator moved up to the higher range anyway, or if you
> passed the XHCI through to a VM with a sufficiently wacky GPA layout, but I
> guess those are cases that simply nobody's run into yet.
>
> Does the firmware actually report any upper address constraint such that
> Sebastian's IVRS aperture patches might help?
No, it doesn't. I am not sure what the best way is to get these issues
found and fixed. I doubt they will be getting fixed when the allocation
pattern isn't changed, maybe we can put your changes behind a config
variable and start testing/reporting bugs/etc.
Regards,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org, jonathan.lemon@gmail.com,
dwmw2@infradead.org, hch@lst.de,
linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com
Subject: Re: [PATCH 2/2] iommu/dma: Avoid SAC address trick for PCIe devices
Date: Wed, 22 Jul 2020 14:48:55 +0200 [thread overview]
Message-ID: <20200722124854.GZ27672@8bytes.org> (raw)
In-Reply-To: <ad3f66c8-7772-731d-cd0a-c5d6d46297cb@arm.com>
On Tue, Jul 14, 2020 at 12:42:36PM +0100, Robin Murphy wrote:
> Oh bother - yes, this could have been masking all manner of bugs. That
> system will presumably also break if you managed to exhaust the 32-bit IOVA
> space such that the allocator moved up to the higher range anyway, or if you
> passed the XHCI through to a VM with a sufficiently wacky GPA layout, but I
> guess those are cases that simply nobody's run into yet.
>
> Does the firmware actually report any upper address constraint such that
> Sebastian's IVRS aperture patches might help?
No, it doesn't. I am not sure what the best way is to get these issues
found and fixed. I doubt they will be getting fixed when the allocation
pattern isn't changed, maybe we can put your changes behind a config
variable and start testing/reporting bugs/etc.
Regards,
Joerg
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-22 12:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 11:32 [PATCH 1/2] iommu/intel: Avoid SAC address trick for PCIe devices Robin Murphy
2020-07-08 11:32 ` Robin Murphy
2020-07-08 11:32 ` Robin Murphy
2020-07-08 11:32 ` [PATCH 2/2] iommu/dma: " Robin Murphy
2020-07-08 11:32 ` Robin Murphy
2020-07-08 11:32 ` Robin Murphy
2020-07-13 13:14 ` Joerg Roedel
2020-07-13 13:14 ` Joerg Roedel
2020-07-13 13:14 ` Joerg Roedel
2020-07-14 11:42 ` Robin Murphy
2020-07-14 11:42 ` Robin Murphy
2020-07-14 11:42 ` Robin Murphy
2020-07-22 12:48 ` Joerg Roedel [this message]
2020-07-22 12:48 ` Joerg Roedel
2020-07-22 12:48 ` Joerg Roedel
2020-07-08 12:26 ` [PATCH 1/2] iommu/intel: " Christoph Hellwig
2020-07-08 12:26 ` Christoph Hellwig
2020-07-08 12:26 ` Christoph Hellwig
2020-07-10 14:20 ` Joerg Roedel
2020-07-10 14:20 ` Joerg Roedel
2020-07-10 14:20 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722124854.GZ27672@8bytes.org \
--to=joro@8bytes.org \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jonathan.lemon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.