From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: netdev@vger.kernel.org, kernel-team@fb.com, robin.murphy@arm.com,
akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org,
willemb@google.com, edumazet@google.com,
steffen.klassert@secunet.com, saeedm@mellanox.com,
maximmi@mellanox.com, bjorn.topel@intel.com,
magnus.karlsson@intel.com, borisp@mellanox.com, david@redhat.com
Subject: Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu
Date: Mon, 27 Jul 2020 18:48:12 -0700 [thread overview]
Message-ID: <20200728014812.izihmnon3khzyr32@bsd-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200727182424.GA10178@lst.de>
On Mon, Jul 27, 2020 at 08:24:25PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 27, 2020 at 10:00:03AM -0700, Jonathan Lemon wrote:
> > On Mon, Jul 27, 2020 at 09:35:09AM +0200, Christoph Hellwig wrote:
> > > Seriously? If you only even considered this is something reasonable
> > > to do you should not be anywhere near Linux kernel development.
> > >
> > > Just go away!
> >
> > This isn't really a constructive comment.
>
> And this wasn't a constructive patch. If you really think adding tons
> of garbage to the kernel to support a proprietary driver you really
> should not be here at all.
This is not in support of a proprietary driver. As the cover letter
notes, this is for data transfers between the NIC/GPU, while still
utilizing the kernel protocol stack and leaving the application in
control.
While the current GPU utilized is nvidia, there's nothing in the rest of
the patches specific to Nvidia - an Intel or AMD GPU interface could be
equally workable.
I think this is a better patch than all the various implementations of
the protocol stack in the form of RDMA, driver code and device firmware.
I'm aware that Nvidia code is maintained outside the tree, so this last
patch may better placed there; I included it here so reviewers can see
how things work.
--
Jonathan
next prev parent reply other threads:[~2020-07-28 1:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200727052846.4070247-1-jonathan.lemon@gmail.com>
[not found] ` <20200727052846.4070247-4-jonathan.lemon@gmail.com>
2020-07-27 5:58 ` [RFC PATCH v2 03/21] mm: Allow DMA mapping of pages which are not online Christoph Hellwig
2020-07-27 17:08 ` Jonathan Lemon
[not found] ` <20200727052846.4070247-22-jonathan.lemon@gmail.com>
2020-07-27 7:35 ` [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu Christoph Hellwig
2020-07-27 17:00 ` Jonathan Lemon
2020-07-27 18:24 ` Christoph Hellwig
2020-07-28 1:48 ` Jonathan Lemon [this message]
2020-07-28 6:47 ` Christoph Hellwig
2020-07-28 16:05 ` Jonathan Lemon
2020-07-28 16:10 ` Christoph Hellwig
2020-07-28 18:19 ` Jason Gunthorpe
2020-07-28 21:01 ` Jonathan Lemon
2020-07-28 21:14 ` Christoph Hellwig
2020-07-28 23:38 ` Jason Gunthorpe
[not found] ` <20200727052846.4070247-14-jonathan.lemon@gmail.com>
2020-07-27 15:19 ` [RFC PATCH v2 13/21] net/tcp: Pad TCP options out to a fixed size " Eric Dumazet
2020-07-27 17:20 ` Jonathan Lemon
[not found] ` <20200727052846.4070247-16-jonathan.lemon@gmail.com>
2020-07-27 15:19 ` [RFC PATCH v2 15/21] net/tcp: add MSG_NETDMA flag for sendmsg() Eric Dumazet
2020-07-27 15:55 ` Jonathan Lemon
2020-07-27 16:09 ` Eric Dumazet
2020-07-27 17:35 ` Jonathan Lemon
2020-07-27 17:44 ` Eric Dumazet
2020-07-28 2:11 ` Jonathan Lemon
2020-07-28 2:17 ` Eric Dumazet
2020-07-28 3:08 ` Jonathan Lemon
2020-07-28 6:50 ` Christoph Hellwig
[not found] ` <20200727052846.4070247-9-jonathan.lemon@gmail.com>
2020-07-27 15:24 ` [RFC PATCH v2 08/21] skbuff: add a zc_netgpu bitflag Eric Dumazet
2020-07-27 16:59 ` Jonathan Lemon
2020-07-27 17:08 ` Eric Dumazet
2020-07-27 17:16 ` Jonathan Lemon
2020-07-27 22:44 [RFC PATCH v2 00/21] netgpu: networking between NIC and GPU/CPU Jonathan Lemon
2020-07-27 22:44 ` [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu Jonathan Lemon
2020-07-28 16:31 ` Greg KH
2020-07-28 17:18 ` Chris Mason
2020-07-28 17:27 ` Christoph Hellwig
2020-07-28 18:47 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728014812.izihmnon3khzyr32@bsd-mbp.dhcp.thefacebook.com \
--to=jonathan.lemon@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bjorn.topel@intel.com \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=edumazet@google.com \
--cc=hch@lst.de \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=saeedm@mellanox.com \
--cc=steffen.klassert@secunet.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.