From: Christoph Hellwig <hch@lst.de>
To: Jonathan Lemon <jonathan.lemon@gmail.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>, Christoph Hellwig <hch@lst.de>,
netdev@vger.kernel.org, kernel-team@fb.com, robin.murphy@arm.com,
akpm@linux-foundation.org, davem@davemloft.net, kuba@kernel.org,
willemb@google.com, edumazet@google.com,
steffen.klassert@secunet.com, saeedm@mellanox.com,
maximmi@mellanox.com, bjorn.topel@intel.com,
magnus.karlsson@intel.com, borisp@mellanox.com, david@redhat.com
Subject: Re: [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu
Date: Tue, 28 Jul 2020 23:14:27 +0200 [thread overview]
Message-ID: <20200728211427.GA22919@lst.de> (raw)
In-Reply-To: <20200728210116.56potw45eyptmlc7@bsd-mbp.dhcp.thefacebook.com>
On Tue, Jul 28, 2020 at 02:01:16PM -0700, Jonathan Lemon wrote:
> For /this/ patch [21], this is quite true. I'm forced to use the nv_p2p
> API if I want to use the hardware that I have. What's being overlooked
> is that the host mem driver does not do this, nor would another GPU
> if it used p2p_dma. I'm just providing get_page, put_page, get_dma.
No, that is not overlooked. What you overlooked is that your design
is bogus. We don't do pointless plugings for something where there
is exactly one way to do, which is done in common infrastructure.
>
>
> > Any approach done in tree, where we can actually modify the GPU
> > driver, would do sane things like have the GPU driver itself create
> > the MEMORY_DEVICE_PCI_P2PDMA pages, use the P2P DMA API framework, use
> > dmabuf for the cross-driver attachment, etc, etc.
>
> So why doesn't Nvidia implement the above in the driver?
> Actually a serious question, not trolling here.
No one knows, and most importantly it simply does not matter at all.
If you actually want to be productive contributor and not just troll
(as it absoutely seems) you'd just stop talking about a out of tree
driver that can't actually be distributed together with the kernel.
And better forget everything you ever knew about it, because it not
only is irrelevant but actually harmful.
next prev parent reply other threads:[~2020-07-28 21:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200727052846.4070247-1-jonathan.lemon@gmail.com>
[not found] ` <20200727052846.4070247-4-jonathan.lemon@gmail.com>
2020-07-27 5:58 ` [RFC PATCH v2 03/21] mm: Allow DMA mapping of pages which are not online Christoph Hellwig
2020-07-27 17:08 ` Jonathan Lemon
[not found] ` <20200727052846.4070247-22-jonathan.lemon@gmail.com>
2020-07-27 7:35 ` [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu Christoph Hellwig
2020-07-27 17:00 ` Jonathan Lemon
2020-07-27 18:24 ` Christoph Hellwig
2020-07-28 1:48 ` Jonathan Lemon
2020-07-28 6:47 ` Christoph Hellwig
2020-07-28 16:05 ` Jonathan Lemon
2020-07-28 16:10 ` Christoph Hellwig
2020-07-28 18:19 ` Jason Gunthorpe
2020-07-28 21:01 ` Jonathan Lemon
2020-07-28 21:14 ` Christoph Hellwig [this message]
2020-07-28 23:38 ` Jason Gunthorpe
[not found] ` <20200727052846.4070247-14-jonathan.lemon@gmail.com>
2020-07-27 15:19 ` [RFC PATCH v2 13/21] net/tcp: Pad TCP options out to a fixed size " Eric Dumazet
2020-07-27 17:20 ` Jonathan Lemon
[not found] ` <20200727052846.4070247-16-jonathan.lemon@gmail.com>
2020-07-27 15:19 ` [RFC PATCH v2 15/21] net/tcp: add MSG_NETDMA flag for sendmsg() Eric Dumazet
2020-07-27 15:55 ` Jonathan Lemon
2020-07-27 16:09 ` Eric Dumazet
2020-07-27 17:35 ` Jonathan Lemon
2020-07-27 17:44 ` Eric Dumazet
2020-07-28 2:11 ` Jonathan Lemon
2020-07-28 2:17 ` Eric Dumazet
2020-07-28 3:08 ` Jonathan Lemon
2020-07-28 6:50 ` Christoph Hellwig
[not found] ` <20200727052846.4070247-9-jonathan.lemon@gmail.com>
2020-07-27 15:24 ` [RFC PATCH v2 08/21] skbuff: add a zc_netgpu bitflag Eric Dumazet
2020-07-27 16:59 ` Jonathan Lemon
2020-07-27 17:08 ` Eric Dumazet
2020-07-27 17:16 ` Jonathan Lemon
2020-07-27 22:44 [RFC PATCH v2 00/21] netgpu: networking between NIC and GPU/CPU Jonathan Lemon
2020-07-27 22:44 ` [RFC PATCH v2 21/21] netgpu/nvidia: add Nvidia plugin for netgpu Jonathan Lemon
2020-07-28 16:31 ` Greg KH
2020-07-28 17:18 ` Chris Mason
2020-07-28 17:27 ` Christoph Hellwig
2020-07-28 18:47 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728211427.GA22919@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=bjorn.topel@intel.com \
--cc=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=edumazet@google.com \
--cc=jgg@nvidia.com \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=saeedm@mellanox.com \
--cc=steffen.klassert@secunet.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.