From: <wsa@kernel.org> To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>, <ludovic.desroches@microchip.com>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <linux@armlinux.org.uk>, <kamel.bouhara@bootlin.com> Subject: Re: [PATCH 2/4] i2c: core: add generic I2C GPIO recovery Date: Wed, 5 Aug 2020 10:36:29 +0200 [thread overview] Message-ID: <20200805083629.GB1229@kunai> (raw) In-Reply-To: <20200804095926.205643-3-codrin.ciubotariu@microchip.com> [-- Attachment #1: Type: text/plain, Size: 2224 bytes --] On Tue, Aug 04, 2020 at 12:59:24PM +0300, Codrin Ciubotariu wrote: > Multiple I2C bus drivers use similar bindings to obtain information needed > for I2C recovery. For example, for platforms using device-tree, the > properties look something like this: > > &i2c { > ... > pinctrl-names = "default", "gpio"; > pinctrl-0 = <&pinctrl_i2c_default>; > pinctrl-1 = <&pinctrl_i2c_gpio>; > sda-gpios = <&pio 0 GPIO_ACTIVE_HIGH>; > scl-gpios = <&pio 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > ... > } > > For this reason, we can add this common initialization in the core. This > way, other I2C bus drivers will be able to support GPIO recovery just by > providing a pointer to platform's pinctrl and calling i2c_recover_bus() > when SDA is stuck low. > > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- Applied to for-next, thanks! Two minor change: > + /* for pinctrl state changes, we need all the information */ > + if (!bri->pins_default || !bri->pins_gpio) { > + bri->pinctrl = NULL; > + bri->pins_default = NULL; > + bri->pins_gpio = NULL; > + } else { > + dev_info(dev, "using pinctrl states for GPIO recovery"); > + } I inverted the logic here: 294 /* for pinctrl state changes, we need all the information */ 295 if (bri->pins_default && bri->pins_gpio) { 296 dev_info(dev, "using pinctrl states for GPIO recovery"); 297 } else { 298 bri->pinctrl = NULL; 299 bri->pins_default = NULL; 300 bri->pins_gpio = NULL; 301 } I think it is a bit easier to read if the desired path is not in the else case. > + * @pins_default: default state of SCL/SDA lines, when they are assigned to the > + * I2C bus. Optional. Populated internally for GPIO recovery, if a state with > + * the name PINCTRL_STATE_DEFAULT is found and pinctrl is valid. > + * @pins_gpio: recovery state of SCL/SDA lines, when they are used as GPIOs. > + * Optional. Populated internally for GPIO recovery, if this state is called > + * "gpio" or "recovery" and pinctrl is valid. Added "pinctrl" to "state of SCL/SDA" to make it clear. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: <wsa@kernel.org> To: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, kamel.bouhara@bootlin.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/4] i2c: core: add generic I2C GPIO recovery Date: Wed, 5 Aug 2020 10:36:29 +0200 [thread overview] Message-ID: <20200805083629.GB1229@kunai> (raw) In-Reply-To: <20200804095926.205643-3-codrin.ciubotariu@microchip.com> [-- Attachment #1.1: Type: text/plain, Size: 2224 bytes --] On Tue, Aug 04, 2020 at 12:59:24PM +0300, Codrin Ciubotariu wrote: > Multiple I2C bus drivers use similar bindings to obtain information needed > for I2C recovery. For example, for platforms using device-tree, the > properties look something like this: > > &i2c { > ... > pinctrl-names = "default", "gpio"; > pinctrl-0 = <&pinctrl_i2c_default>; > pinctrl-1 = <&pinctrl_i2c_gpio>; > sda-gpios = <&pio 0 GPIO_ACTIVE_HIGH>; > scl-gpios = <&pio 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > ... > } > > For this reason, we can add this common initialization in the core. This > way, other I2C bus drivers will be able to support GPIO recovery just by > providing a pointer to platform's pinctrl and calling i2c_recover_bus() > when SDA is stuck low. > > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> > --- Applied to for-next, thanks! Two minor change: > + /* for pinctrl state changes, we need all the information */ > + if (!bri->pins_default || !bri->pins_gpio) { > + bri->pinctrl = NULL; > + bri->pins_default = NULL; > + bri->pins_gpio = NULL; > + } else { > + dev_info(dev, "using pinctrl states for GPIO recovery"); > + } I inverted the logic here: 294 /* for pinctrl state changes, we need all the information */ 295 if (bri->pins_default && bri->pins_gpio) { 296 dev_info(dev, "using pinctrl states for GPIO recovery"); 297 } else { 298 bri->pinctrl = NULL; 299 bri->pins_default = NULL; 300 bri->pins_gpio = NULL; 301 } I think it is a bit easier to read if the desired path is not in the else case. > + * @pins_default: default state of SCL/SDA lines, when they are assigned to the > + * I2C bus. Optional. Populated internally for GPIO recovery, if a state with > + * the name PINCTRL_STATE_DEFAULT is found and pinctrl is valid. > + * @pins_gpio: recovery state of SCL/SDA lines, when they are used as GPIOs. > + * Optional. Populated internally for GPIO recovery, if this state is called > + * "gpio" or "recovery" and pinctrl is valid. Added "pinctrl" to "state of SCL/SDA" to make it clear. [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-05 8:36 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-04 9:59 [PATCH 0/4] i2c: core: add generic GPIO bus recovery Codrin Ciubotariu 2020-08-04 9:59 ` Codrin Ciubotariu 2020-08-04 9:59 ` [PATCH 1/4] dt-binding: i2c: add generic properties for " Codrin Ciubotariu 2020-08-04 9:59 ` Codrin Ciubotariu 2020-08-05 8:28 ` wsa 2020-08-05 8:28 ` wsa 2020-08-04 9:59 ` [PATCH 2/4] i2c: core: add generic I2C GPIO recovery Codrin Ciubotariu 2020-08-04 9:59 ` Codrin Ciubotariu 2020-08-05 8:36 ` wsa [this message] 2020-08-05 8:36 ` wsa 2020-08-04 9:59 ` [PATCH 3/4] i2c: core: treat EPROBE_DEFER when acquiring SCL/SDA GPIOs Codrin Ciubotariu 2020-08-04 9:59 ` Codrin Ciubotariu 2020-08-05 8:40 ` wsa 2020-08-05 8:40 ` wsa 2020-08-04 9:59 ` [PATCH 4/4] i2c: at91: Move to generic GPIO bus recovery Codrin Ciubotariu 2020-08-04 9:59 ` Codrin Ciubotariu 2020-08-05 8:41 ` wsa 2020-08-05 8:41 ` wsa 2020-08-05 8:52 ` [PATCH 0/4] i2c: core: add " wsa 2020-08-05 8:52 ` wsa 2020-08-05 10:29 ` Codrin.Ciubotariu 2020-08-05 10:29 ` Codrin.Ciubotariu 2020-08-05 11:17 ` wsa 2020-08-05 11:17 ` wsa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200805083629.GB1229@kunai \ --to=wsa@kernel.org \ --cc=alexandre.belloni@bootlin.com \ --cc=codrin.ciubotariu@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=kamel.bouhara@bootlin.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-i2c@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.