All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtio-fs@redhat.com
Cc: vgoyal@redhat.com, miklos@szeredi.hu, stefanha@redhat.com,
	dgilbert@redhat.com
Subject: [PATCH v2 16/20] fuse,virtiofs: Define dax address space operations
Date: Fri,  7 Aug 2020 15:55:22 -0400	[thread overview]
Message-ID: <20200807195526.426056-17-vgoyal@redhat.com> (raw)
In-Reply-To: <20200807195526.426056-1-vgoyal@redhat.com>

This is done along the lines of ext4 and xfs. I primarily wanted ->writepages
hook at this time so that I could call into dax_writeback_mapping_range().
This in turn will decide which pfns need to be written back.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 fs/fuse/file.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 00ad27216cc3..54708cb24da0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2669,6 +2669,16 @@ static int fuse_writepages_fill(struct page *page,
 	return err;
 }
 
+static int fuse_dax_writepages(struct address_space *mapping,
+				struct writeback_control *wbc)
+{
+
+	struct inode *inode = mapping->host;
+	struct fuse_conn *fc = get_fuse_conn(inode);
+
+	return dax_writeback_mapping_range(mapping, fc->dax_dev, wbc);
+}
+
 static int fuse_writepages(struct address_space *mapping,
 			   struct writeback_control *wbc)
 {
@@ -4030,6 +4040,13 @@ static const struct address_space_operations fuse_file_aops  = {
 	.write_end	= fuse_write_end,
 };
 
+static const struct address_space_operations fuse_dax_file_aops  = {
+	.writepages	= fuse_dax_writepages,
+	.direct_IO	= noop_direct_IO,
+	.set_page_dirty	= noop_set_page_dirty,
+	.invalidatepage	= noop_invalidatepage,
+};
+
 void fuse_init_file_inode(struct inode *inode)
 {
 	struct fuse_inode *fi = get_fuse_inode(inode);
@@ -4045,6 +4062,8 @@ void fuse_init_file_inode(struct inode *inode)
 	fi->writepages = RB_ROOT;
 	fi->dmap_tree = RB_ROOT_CACHED;
 
-	if (fc->dax_dev)
+	if (fc->dax_dev) {
 		inode->i_flags |= S_DAX;
+		inode->i_data.a_ops = &fuse_dax_file_aops;
+	}
 }
-- 
2.25.4


WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtio-fs@redhat.com
Cc: vgoyal@redhat.com, miklos@szeredi.hu
Subject: [Virtio-fs] [PATCH v2 16/20] fuse, virtiofs: Define dax address space operations
Date: Fri,  7 Aug 2020 15:55:22 -0400	[thread overview]
Message-ID: <20200807195526.426056-17-vgoyal@redhat.com> (raw)
In-Reply-To: <20200807195526.426056-1-vgoyal@redhat.com>

This is done along the lines of ext4 and xfs. I primarily wanted ->writepages
hook at this time so that I could call into dax_writeback_mapping_range().
This in turn will decide which pfns need to be written back.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 fs/fuse/file.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 00ad27216cc3..54708cb24da0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -2669,6 +2669,16 @@ static int fuse_writepages_fill(struct page *page,
 	return err;
 }
 
+static int fuse_dax_writepages(struct address_space *mapping,
+				struct writeback_control *wbc)
+{
+
+	struct inode *inode = mapping->host;
+	struct fuse_conn *fc = get_fuse_conn(inode);
+
+	return dax_writeback_mapping_range(mapping, fc->dax_dev, wbc);
+}
+
 static int fuse_writepages(struct address_space *mapping,
 			   struct writeback_control *wbc)
 {
@@ -4030,6 +4040,13 @@ static const struct address_space_operations fuse_file_aops  = {
 	.write_end	= fuse_write_end,
 };
 
+static const struct address_space_operations fuse_dax_file_aops  = {
+	.writepages	= fuse_dax_writepages,
+	.direct_IO	= noop_direct_IO,
+	.set_page_dirty	= noop_set_page_dirty,
+	.invalidatepage	= noop_invalidatepage,
+};
+
 void fuse_init_file_inode(struct inode *inode)
 {
 	struct fuse_inode *fi = get_fuse_inode(inode);
@@ -4045,6 +4062,8 @@ void fuse_init_file_inode(struct inode *inode)
 	fi->writepages = RB_ROOT;
 	fi->dmap_tree = RB_ROOT_CACHED;
 
-	if (fc->dax_dev)
+	if (fc->dax_dev) {
 		inode->i_flags |= S_DAX;
+		inode->i_data.a_ops = &fuse_dax_file_aops;
+	}
 }
-- 
2.25.4


  parent reply	other threads:[~2020-08-07 19:56 UTC|newest]

Thread overview: 97+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07 19:55 [PATCH v2 00/20] virtiofs: Add DAX support Vivek Goyal
2020-08-07 19:55 ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 01/20] dax: Modify bdev_dax_pgoff() to handle NULL bdev Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55   ` Vivek Goyal
2020-08-17 16:57   ` Jan Kara
2020-08-17 16:57     ` [Virtio-fs] " Jan Kara
2020-08-17 16:57     ` Jan Kara
2020-08-07 19:55 ` [PATCH v2 02/20] dax: Create a range version of dax_layout_busy_page() Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55   ` Vivek Goyal
2020-08-17 16:53   ` Jan Kara
2020-08-17 16:53     ` [Virtio-fs] " Jan Kara
2020-08-17 16:53     ` Jan Kara
2020-08-17 17:22     ` Vivek Goyal
2020-08-17 17:22       ` [Virtio-fs] " Vivek Goyal
2020-08-17 17:22       ` Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 03/20] virtio: Add get_shm_region method Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-10 13:47   ` Michael S. Tsirkin
2020-08-10 13:47     ` [Virtio-fs] " Michael S. Tsirkin
2020-08-10 13:54     ` Vivek Goyal
2020-08-10 13:54       ` [Virtio-fs] " Vivek Goyal
2020-08-10 14:02   ` Michael S. Tsirkin
2020-08-10 14:02     ` [Virtio-fs] " Michael S. Tsirkin
2020-08-10 14:06   ` Michael S. Tsirkin
2020-08-10 14:06     ` [Virtio-fs] " Michael S. Tsirkin
2020-08-07 19:55 ` [PATCH v2 04/20] virtio: Implement get_shm_region for PCI transport Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-10 14:05   ` Michael S. Tsirkin
2020-08-10 14:05     ` [Virtio-fs] " Michael S. Tsirkin
2020-08-10 14:50     ` Vivek Goyal
2020-08-10 14:50       ` [Virtio-fs] " Vivek Goyal
2020-08-14  2:51       ` Gurchetan Singh
2020-08-17 20:29         ` Vivek Goyal
2020-08-17 20:29           ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 05/20] virtio: Implement get_shm_region for MMIO transport Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-10 14:03   ` Michael S. Tsirkin
2020-08-10 14:03     ` [Virtio-fs] " Michael S. Tsirkin
2020-08-07 19:55 ` [PATCH v2 06/20] virtiofs: Provide a helper function for virtqueue initialization Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 07/20] fuse: Get rid of no_mount_options Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 08/20] fuse,virtiofs: Add a mount option to enable dax Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] [PATCH v2 08/20] fuse, virtiofs: " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 09/20] virtio_fs, dax: Set up virtio_fs dax_device Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 10/20] fuse,virtiofs: Keep a list of free dax memory ranges Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] [PATCH v2 10/20] fuse, virtiofs: " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 11/20] fuse: implement FUSE_INIT map_alignment field Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 12/20] fuse: Introduce setupmapping/removemapping commands Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 13/20] fuse, dax: Implement dax read/write operations Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-10 22:06   ` Dave Chinner
2020-08-10 22:06     ` [Virtio-fs] " Dave Chinner
2020-08-11 17:44     ` Vivek Goyal
2020-08-11 17:44       ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 14/20] fuse,dax: add DAX mmap support Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 15/20] fuse, dax: Take ->i_mmap_sem lock during dax page fault Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-10 22:22   ` Dave Chinner
2020-08-10 22:22     ` [Virtio-fs] " Dave Chinner
2020-08-11 17:55     ` Vivek Goyal
2020-08-11 17:55       ` [Virtio-fs] " Vivek Goyal
2020-08-12  1:23       ` Dave Chinner
2020-08-12  1:23         ` [Virtio-fs] " Dave Chinner
2020-08-12 21:10         ` Vivek Goyal
2020-08-12 21:10           ` [Virtio-fs] " Vivek Goyal
2020-08-13  5:12           ` Dave Chinner
2020-08-13  5:12             ` [Virtio-fs] " Dave Chinner
2020-08-07 19:55 ` Vivek Goyal [this message]
2020-08-07 19:55   ` [Virtio-fs] [PATCH v2 16/20] fuse, virtiofs: Define dax address space operations Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 17/20] fuse,virtiofs: Maintain a list of busy elements Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] [PATCH v2 17/20] fuse, virtiofs: " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 18/20] fuse: Release file in process context Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-10  8:29   ` Miklos Szeredi
2020-08-10  8:29     ` [Virtio-fs] " Miklos Szeredi
2020-08-10 15:48     ` Vivek Goyal
2020-08-10 15:48       ` [Virtio-fs] " Vivek Goyal
2020-08-10 19:37     ` Vivek Goyal
2020-08-10 19:37       ` [Virtio-fs] " Vivek Goyal
2020-08-10 19:39       ` Miklos Szeredi
2020-08-10 19:39         ` [Virtio-fs] " Miklos Szeredi
2020-08-07 19:55 ` [PATCH v2 19/20] fuse: Take inode lock for dax inode truncation Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] " Vivek Goyal
2020-08-07 19:55 ` [PATCH v2 20/20] fuse,virtiofs: Add logic to free up a memory range Vivek Goyal
2020-08-07 19:55   ` [Virtio-fs] [PATCH v2 20/20] fuse, virtiofs: " Vivek Goyal
2020-08-10  7:29 ` [PATCH v2 00/20] virtiofs: Add DAX support Miklos Szeredi
2020-08-10  7:29   ` [Virtio-fs] " Miklos Szeredi
2020-08-10 13:08   ` Vivek Goyal
2020-08-10 13:08     ` [Virtio-fs] " Vivek Goyal
2020-08-10 13:08     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200807195526.426056-17-vgoyal@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=stefanha@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.