Re: [PATCH v2] ARM: dts: imx25-pinfunc: add missing and fix wrong SPI related defintions

From: Sascha Hauer <s.hauer@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v2] ARM: dts: imx25-pinfunc: add missing and fix wrong SPI related defintions
Date: Mon, 10 Aug 2020 07:21:50 +0200	[thread overview]
Message-ID: <20200810052150.GT31536@pengutronix.de> (raw)
In-Reply-To: <20200805151307.18377-1-u.kleine-koenig@pengutronix.de>

On Wed, Aug 05, 2020 at 05:13:07PM +0200, Uwe Kleine-König wrote:
> I used the i.MX25 Reference Manual (Rev 2 01/2011) as source for these
> additions and fixes.
> 
> No mainline dts is affected by the fixes (nor obviously by the
> additions).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
> 
> I had a wip commit in my tree which made v1 non-applicable. Here is a
> proper patch that applies to 5.8 and has an additional note in the
> commit log.
> 
> Best regards
> Uwe
> 
>  arch/arm/boot/dts/imx25-pinfunc.h | 21 ++++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)

I checked a few of the changes. The ones I checked are correct and match
the datasheet.

Reviewed-by: Sascha Hauer <s.hauer@pengutronix.de>

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |