Re: [PATCH 1/8] mfd: mt6358: refine interrupt code

From: Lee Jones <lee.jones@linaro.org>
To: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Frank Wunderlich <frank-w@public-files.de>,
	Josef Friedl <josef.friedl@speed.at>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	srv_heupstream <srv_heupstream@mediatek.com>
Subject: Re: [PATCH 1/8] mfd: mt6358: refine interrupt code
Date: Mon, 10 Aug 2020 08:31:28 +0100	[thread overview]
Message-ID: <20200810073128.GC4411@dell> (raw)
In-Reply-To: <1596443379.31084.3.camel@mtksdaap41>

On Mon, 03 Aug 2020, Hsin-hsiung Wang wrote:

> Hi,
> 
> On Mon, 2020-07-27 at 16:48 +0100, Lee Jones wrote:
> > On Thu, 23 Jul 2020, Hsin-Hsiung Wang wrote:
> > 
> > > This patch refines the interrupt related code to support new chips.
> > 
> > Refines in what way?
> > 
> > What makes this better?
> > 
> 
> Thanks for the comment. I will add more information into comment message
> based on my below explanation.

Thanks.

> > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
> > > ---
> > >  drivers/mfd/mt6358-irq.c        | 65 ++++++++++++++++++++++++-----------------
> > >  include/linux/mfd/mt6358/core.h |  8 ++---
> > >  2 files changed, 41 insertions(+), 32 deletions(-)
> > > 
> > > diff --git a/drivers/mfd/mt6358-irq.c b/drivers/mfd/mt6358-irq.c
> > > index db734f2..4b094e5 100644
> > > --- a/drivers/mfd/mt6358-irq.c
> > > +++ b/drivers/mfd/mt6358-irq.c
> > > @@ -13,7 +13,9 @@
> > >  #include <linux/platform_device.h>
> > >  #include <linux/regmap.h>
> > >  
> > > -static struct irq_top_t mt6358_ints[] = {
> > > +#define MTK_PMIC_REG_WIDTH 16
> > > +
> > > +static const struct irq_top_t mt6358_ints[] = {
> > >  	MT6358_TOP_GEN(BUCK),
> > >  	MT6358_TOP_GEN(LDO),
> > >  	MT6358_TOP_GEN(PSC),
> > > @@ -24,6 +26,13 @@ static struct irq_top_t mt6358_ints[] = {
> > >  	MT6358_TOP_GEN(MISC),
> > >  };
> > >  
> > > +static struct pmic_irq_data mt6358_irqd = {
> > > +	.num_top = ARRAY_SIZE(mt6358_ints),
> > > +	.num_pmic_irqs = MT6358_IRQ_NR,
> > > +	.top_int_status_reg = MT6358_TOP_INT_STATUS0,
> > > +	.pmic_ints = mt6358_ints,
> > > +};
> > 
> > Dynamically assigned driver data is usually preferred.
> > 
> > Why have you gone static?
> > 
> 
> Do you consider the memory allocation?
> Below modification is to assign necessary data dynamically and the code
> will become longer with more chips if we assign every member of the
> structure.

[...]

Never mind.  On second glance, this should be fine.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog