From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, Yan Zhao <yan.y.zhao@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt:fix raw-wakeref not held calltrace in vGPU
Date: Tue, 11 Aug 2020 16:39:09 +0800 [thread overview]
Message-ID: <20200811083909.GM27035@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <159713437103.2955.4439985576665396417@build.alporthouse.com>
[-- Attachment #1.1: Type: text/plain, Size: 583 bytes --]
On 2020.08.11 09:26:11 +0100, Chris Wilson wrote:
> Quoting Yan Zhao (2020-08-11 04:02:09)
> > UNCORE_HAS_FORCEWAKE is not turned on when intel_vgpu_active() returns
> > true, so the guest mmio writes go to gen2_write32().
>
> The vgpu writes are just memory traps, the device wakeref should not be
> required. It seems like we've accidentally added the assert to the wrong
> io accessors.
yeah, I agree. I did remember we didn't have that assert before for
vgpu case... maybe better hook with explicit vgpu_read()/vgpu_write()
that won't be affected by other changes.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-11 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 3:02 [Intel-gfx] [PATCH] drm/i915/gt:fix raw-wakeref not held calltrace in vGPU Yan Zhao
2020-08-11 3:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-08-11 4:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-11 5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-11 8:26 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-08-11 8:18 ` Yan Zhao
2020-08-11 8:39 ` Zhenyu Wang [this message]
2020-08-11 9:25 ` [Intel-gfx] [PATCH] drm/i915: Drop runtime-pm assert from vgpu io accessors Chris Wilson
2020-08-12 2:06 ` Zhenyu Wang
2020-08-19 8:32 ` Zhenyu Wang
2020-10-19 9:37 ` Zhenyu Wang
2020-10-20 9:41 ` Chris Wilson
2020-08-11 10:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt:fix raw-wakeref not held calltrace in vGPU (rev2) Patchwork
2020-08-11 10:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-11 13:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811083909.GM27035@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.