From: Christoph Hellwig <hch@lst.de>
To: Coly Li <colyli@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
netdev@vger.kernel.org, open-iscsi@googlegroups.com,
linux-scsi@vger.kernel.org, ceph-devel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Hannes Reinecke <hare@suse.de>, Jan Kara <jack@suse.com>,
Jens Axboe <axboe@kernel.dk>,
Mikhail Skorzhinskii <mskorzhinskiy@solarflare.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
Sagi Grimberg <sagi@grimberg.me>,
Vlastimil Babka <vbabka@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h
Date: Tue, 18 Aug 2020 21:49:30 +0200 [thread overview]
Message-ID: <20200818194930.GA31966@lst.de> (raw)
In-Reply-To: <217ec0ec-3c5a-a8ed-27d9-c634f0b9a045@suse.de>
On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote:
> On 2020/8/19 00:24, Christoph Hellwig wrote:
> > I think we should go for something simple like this instead:
>
> This idea is fine to me. Should a warning message be through here? IMHO
> the driver still sends an improper page in, fix it in silence is too
> kind or over nice to the buggy driver(s).
I don't think a warning is a good idea. An API that does the right
thing underneath and doesn't require boiler plate code in most callers
is the right API.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Coly Li <colyli@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>, Vlastimil Babka <vbabka@suse.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-scsi@vger.kernel.org, netdev@vger.kernel.org,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Mikhail Skorzhinskii <mskorzhinskiy@solarflare.com>,
linux-block@vger.kernel.org, Hannes Reinecke <hare@suse.de>,
Jan Kara <jack@suse.com>,
stable@vger.kernel.org, ceph-devel@vger.kernel.org,
open-iscsi@googlegroups.com, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h
Date: Tue, 18 Aug 2020 21:49:30 +0200 [thread overview]
Message-ID: <20200818194930.GA31966@lst.de> (raw)
In-Reply-To: <217ec0ec-3c5a-a8ed-27d9-c634f0b9a045@suse.de>
On Wed, Aug 19, 2020 at 12:33:37AM +0800, Coly Li wrote:
> On 2020/8/19 00:24, Christoph Hellwig wrote:
> > I think we should go for something simple like this instead:
>
> This idea is fine to me. Should a warning message be through here? IMHO
> the driver still sends an improper page in, fix it in silence is too
> kind or over nice to the buggy driver(s).
I don't think a warning is a good idea. An API that does the right
thing underneath and doesn't require boiler plate code in most callers
is the right API.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-18 19:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 13:12 [PATCH v7 0/6] Introduce sendpage_ok() to detect misused sendpage in network related drivers Coly Li
2020-08-18 13:12 ` Coly Li
2020-08-18 13:12 ` [PATCH v7 1/6] net: introduce helper sendpage_ok() in include/linux/net.h Coly Li
2020-08-18 13:12 ` Coly Li
2020-08-18 16:24 ` Christoph Hellwig
2020-08-18 16:24 ` Christoph Hellwig
2020-08-18 16:33 ` Coly Li
2020-08-18 16:33 ` Coly Li
2020-08-18 19:49 ` Christoph Hellwig [this message]
2020-08-18 19:49 ` Christoph Hellwig
2020-08-19 4:22 ` Coly Li
2020-08-19 4:22 ` Coly Li
2020-09-23 8:43 ` Christoph Hellwig
2020-09-23 8:43 ` Christoph Hellwig
2020-09-23 8:45 ` Coly Li
2020-09-23 8:45 ` Coly Li
2020-08-18 13:12 ` [PATCH v7 2/6] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage() Coly Li
2020-08-18 13:12 ` Coly Li
2020-08-18 13:12 ` [PATCH v7 3/6] tcp: use sendpage_ok() to detect misused .sendpage Coly Li
2020-08-18 13:12 ` Coly Li
2020-08-18 13:12 ` [PATCH v7 4/6] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage() Coly Li
2020-08-18 13:12 ` Coly Li
2020-08-18 13:12 ` [PATCH v7 5/6] scsi: libiscsi: use sendpage_ok() in iscsi_tcp_segment_map() Coly Li
2020-08-18 13:12 ` Coly Li
2020-08-18 13:12 ` [PATCH v7 6/6] libceph: use sendpage_ok() in ceph_tcp_sendpage() Coly Li
2020-08-18 13:12 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818194930.GA31966@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=ceph-devel@vger.kernel.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=colyli@suse.de \
--cc=hare@suse.de \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mskorzhinskiy@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
--cc=philipp.reisner@linbit.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.