From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>, Andi Shyti <andi@etezian.org>,
Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, m.szyprowski@samsung.com,
b.zolnierkie@samsung.com
Subject: Re: [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250
Date: Wed, 19 Aug 2020 15:06:24 +0200 [thread overview]
Message-ID: <20200819130624.GB18970@kozik-lap> (raw)
In-Reply-To: <dleftjpn7m23j2.fsf%l.stelmach@samsung.com>
On Wed, Aug 19, 2020 at 03:01:21PM +0200, Lukasz Stelmach wrote:
> It was <2020-08-19 śro 14:39>, when Krzysztof Kozlowski wrote:
> > On Wed, Aug 19, 2020 at 02:32:02PM +0200, Łukasz Stelmach wrote:
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> >
> > Add a quirk - why?
>
> Because stuff does not work without it and works with it and it is
> turned on for other SoCs which have simmilar SPI HW.
>
> > There is here no commit msg, no explanation.
>
> As I wrote in the cover letter, this and previous commits make things
> work on Exynos3250 (ARTIK5 precisely). I can't explain why. I read
> everything I could about this HW and there were no details about
> automatic CS handling other than how to turn it on and off.
At least this information would be useful. If vendor kernel also does
it, that's another argument to use, since there are no better ones...
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Andi Shyti <andi@etezian.org>,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250
Date: Wed, 19 Aug 2020 15:06:24 +0200 [thread overview]
Message-ID: <20200819130624.GB18970@kozik-lap> (raw)
In-Reply-To: <dleftjpn7m23j2.fsf%l.stelmach@samsung.com>
On Wed, Aug 19, 2020 at 03:01:21PM +0200, Lukasz Stelmach wrote:
> It was <2020-08-19 śro 14:39>, when Krzysztof Kozlowski wrote:
> > On Wed, Aug 19, 2020 at 02:32:02PM +0200, Łukasz Stelmach wrote:
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> >
> > Add a quirk - why?
>
> Because stuff does not work without it and works with it and it is
> turned on for other SoCs which have simmilar SPI HW.
>
> > There is here no commit msg, no explanation.
>
> As I wrote in the cover letter, this and previous commits make things
> work on Exynos3250 (ARTIK5 precisely). I can't explain why. I read
> everything I could about this HW and there were no details about
> automatic CS handling other than how to turn it on and off.
At least this information would be useful. If vendor kernel also does
it, that's another argument to use, since there are no better ones...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-19 13:06 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200819123225eucas1p28be1b1920ade0ba8997bc17da97599b6@eucas1p2.samsung.com>
2020-08-19 12:32 ` [PATCH 0/8] Some fixes for spi-s3c64xx Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
[not found] ` <CGME20200819123226eucas1p16c9b90330d957344f99f6ee461190085@eucas1p1.samsung.com>
2020-08-19 12:32 ` [PATCH 1/8] spi: spi-s3c64xx: swap s3c64xx_spi_set_cs() and s3c64xx_enable_datapath() Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:38 ` Krzysztof Kozlowski
2020-08-19 12:38 ` Krzysztof Kozlowski
[not found] ` <CGME20200819125150eucas1p1965fab59b6e75cf54cac262161c5695b@eucas1p1.samsung.com>
2020-08-19 12:51 ` Lukasz Stelmach
2020-08-19 12:51 ` Lukasz Stelmach
2020-08-19 12:58 ` Krzysztof Kozlowski
2020-08-19 12:58 ` Krzysztof Kozlowski
2020-08-19 13:16 ` Mark Brown
2020-08-19 13:16 ` Mark Brown
[not found] ` <CGME20200819140203eucas1p2818858289f2394b32f3c647e47705cd2@eucas1p2.samsung.com>
2020-08-19 14:01 ` Lukasz Stelmach
2020-08-19 14:01 ` Lukasz Stelmach
2020-08-19 19:12 ` Mark Brown
2020-08-19 19:12 ` Mark Brown
[not found] ` <CGME20200820101251eucas1p237a794cc11f44c709c0ccdfef766702c@eucas1p2.samsung.com>
2020-08-20 10:12 ` Lukasz Stelmach
2020-08-20 10:12 ` Lukasz Stelmach
[not found] ` <CGME20200819123226eucas1p2f4be625abd7ddaac2f09bdf94395346b@eucas1p2.samsung.com>
2020-08-19 12:32 ` [PATCH 2/8] spi: spi-s3s64xx: Add S3C64XX_SPI_QUIRK_CS_AUTO for Exynos3250 Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:39 ` Krzysztof Kozlowski
2020-08-19 12:39 ` Krzysztof Kozlowski
[not found] ` <CGME20200819130122eucas1p27e9e84c4399d01409858de6d01e11b52@eucas1p2.samsung.com>
2020-08-19 13:01 ` Lukasz Stelmach
2020-08-19 13:01 ` Lukasz Stelmach
2020-08-19 13:06 ` Krzysztof Kozlowski [this message]
2020-08-19 13:06 ` Krzysztof Kozlowski
2020-08-19 19:38 ` Mark Brown
2020-08-19 19:38 ` Mark Brown
[not found] ` <CGME20200820104737eucas1p140e3c575eb692a1de54c5a702951ebfe@eucas1p1.samsung.com>
2020-08-20 10:47 ` Lukasz Stelmach
2020-08-20 10:47 ` Lukasz Stelmach
[not found] ` <CGME20200819123226eucas1p2dc50cd60f71f2155524ec21bf4dcdd74@eucas1p2.samsung.com>
2020-08-19 12:32 ` [PATCH 3/8] spi: spi-s3c64xx: Report more information when errors occur Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:43 ` Krzysztof Kozlowski
2020-08-19 12:43 ` Krzysztof Kozlowski
[not found] ` <CGME20200819123227eucas1p1f56cc06dc6c368abf2d3952ba04f37e2@eucas1p1.samsung.com>
2020-08-19 12:32 ` [PATCH 4/8] spi: spi-s3c64xx: Rename S3C64XX_SPI_SLAVE_* to S3C64XX_SPI_CS_* Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:44 ` Krzysztof Kozlowski
2020-08-19 12:44 ` Krzysztof Kozlowski
[not found] ` <CGME20200819123227eucas1p11cd47cf281a035ed02d5fc819a0370c1@eucas1p1.samsung.com>
2020-08-19 12:32 ` [PATCH 5/8] spi: spi-s3c64xx: Fix doc comment for struct s3c64xx_spi_driver_data Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:37 ` Krzysztof Kozlowski
2020-08-19 12:37 ` Krzysztof Kozlowski
[not found] ` <CGME20200819132540eucas1p1897948a4f4008ab4946120dd4fa5c192@eucas1p1.samsung.com>
2020-08-19 13:25 ` Lukasz Stelmach
2020-08-19 13:25 ` Lukasz Stelmach
[not found] ` <CGME20200819123227eucas1p11ec027714c16d5a66c89c6ef1f7b3604@eucas1p1.samsung.com>
2020-08-19 12:32 ` [PATCH 6/8] spi: spi-s3c64xx: Check return values Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:48 ` Krzysztof Kozlowski
2020-08-19 12:48 ` Krzysztof Kozlowski
[not found] ` <CGME20200819154154eucas1p1e88747d2495e6d1074991419504066df@eucas1p1.samsung.com>
2020-08-19 15:41 ` Lukasz Stelmach
2020-08-19 15:41 ` Lukasz Stelmach
2020-08-19 16:13 ` Krzysztof Kozlowski
2020-08-19 16:13 ` Krzysztof Kozlowski
[not found] ` <CGME20200819123228eucas1p19ac7fc04dec52c733ab9c770e91f6ace@eucas1p1.samsung.com>
2020-08-19 12:32 ` [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:49 ` Krzysztof Kozlowski
2020-08-19 12:49 ` Krzysztof Kozlowski
[not found] ` <CGME20200819133957eucas1p293192baeabb9788ac9148068c1627a57@eucas1p2.samsung.com>
2020-08-19 13:39 ` Lukasz Stelmach
2020-08-19 13:39 ` Lukasz Stelmach
2020-08-21 7:10 ` Krzysztof Kozlowski
2020-08-21 7:10 ` Krzysztof Kozlowski
[not found] ` <CGME20200819123228eucas1p132d530d17256f887d93ed7792f5b9587@eucas1p1.samsung.com>
2020-08-19 12:32 ` [PATCH 8/8] spi: spi-s3c64xx: Turn on interrupts upon resume Łukasz Stelmach
2020-08-19 12:32 ` Łukasz Stelmach
2020-08-19 12:53 ` Krzysztof Kozlowski
2020-08-19 12:53 ` Krzysztof Kozlowski
[not found] ` <CGME20200819133334eucas1p2080182850c7ba84829e3304a1172afff@eucas1p2.samsung.com>
2020-08-19 13:33 ` Lukasz Stelmach
2020-08-19 13:33 ` Lukasz Stelmach
2020-08-19 12:50 ` [PATCH 0/8] Some fixes for spi-s3c64xx Krzysztof Kozlowski
2020-08-19 12:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819130624.GB18970@kozik-lap \
--to=krzk@kernel.org \
--cc=andi@etezian.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=kgene@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.