All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Coly Li <colyli@suse.de>
Cc: keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
Date: Wed, 19 Aug 2020 21:04:57 +0000	[thread overview]
Message-ID: <20200819210457.GC9942@linux.intel.com> (raw)
In-Reply-To: <20200819210234.GB9942@linux.intel.com>

On Thu, Aug 20, 2020 at 12:02:38AM +0300, Jarkko Sakkinen wrote:
> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
> > The parameters in command examples for tpm2_createprimary and
> > tpm2_evictcontrol are outdated, people (like me) are not able to create
> > trusted key by these command examples.
> > 
> > This patch updates the parameters of command example tpm2_createprimary
> > and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
> > and tpm2-tools-4.1, people can create a trusted key by following the
> > examples in this document.
> > 
> > Signed-off-by: Coly Li <colyli@suse.de>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> OK, now it is clear. Thank you.
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

There is one problem though.

You have missed to add linux-doc and linux-integrity maintainers and
also their maintainers from the CC list. You need to resend this patch
with that information. Use get_maintainers.pl or look from the file
called MAINTAINERS.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Coly Li <colyli@suse.de>
Cc: keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dan Williams <dan.j.williams@intel.com>,
	James Bottomley <jejb@linux.ibm.com>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Stefan Berger <stefanb@linux.ibm.com>
Subject: Re: [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples
Date: Thu, 20 Aug 2020 00:04:57 +0300	[thread overview]
Message-ID: <20200819210457.GC9942@linux.intel.com> (raw)
In-Reply-To: <20200819210234.GB9942@linux.intel.com>

On Thu, Aug 20, 2020 at 12:02:38AM +0300, Jarkko Sakkinen wrote:
> On Wed, Aug 19, 2020 at 01:00:02AM +0800, Coly Li wrote:
> > The parameters in command examples for tpm2_createprimary and
> > tpm2_evictcontrol are outdated, people (like me) are not able to create
> > trusted key by these command examples.
> > 
> > This patch updates the parameters of command example tpm2_createprimary
> > and tpm2_evictcontrol in trusted-encrypted.rst. With Linux kernel v5.8
> > and tpm2-tools-4.1, people can create a trusted key by following the
> > examples in this document.
> > 
> > Signed-off-by: Coly Li <colyli@suse.de>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > Cc: Mimi Zohar <zohar@linux.ibm.com>
> > Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> OK, now it is clear. Thank you.
> 
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

There is one problem though.

You have missed to add linux-doc and linux-integrity maintainers and
also their maintainers from the CC list. You need to resend this patch
with that information. Use get_maintainers.pl or look from the file
called MAINTAINERS.

/Jarkko

  reply	other threads:[~2020-08-19 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-18 17:00 [PATCH v3] docs: trusted-encrypted.rst: update parameters for command examples Coly Li
2020-08-18 17:00 ` Coly Li
2020-08-19 21:02 ` Jarkko Sakkinen
2020-08-19 21:02   ` Jarkko Sakkinen
2020-08-19 21:04   ` Jarkko Sakkinen [this message]
2020-08-19 21:04     ` Jarkko Sakkinen
2020-08-21 13:50     ` Coly Li
2020-08-21 13:50       ` Coly Li
2020-08-21 17:43       ` Jarkko Sakkinen
2020-08-21 17:43         ` Jarkko Sakkinen
2020-08-19 23:03   ` Stefan Berger
2020-08-19 23:03     ` Stefan Berger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819210457.GC9942@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=colyli@suse.de \
    --cc=dan.j.williams@intel.com \
    --cc=jejb@linux.ibm.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanb@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.