All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	Yamin Friedman <yaminf@mellanox.com>,
	kernel test robot <rong.a.chen@intel.com>,
	Max Gurtovoy <maxg@mellanox.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg+lists@ziepe.ca>,
	<linux-rdma@vger.kernel.org>, <lkp@lists.01.org>
Subject: Re: [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143
Date: Mon, 24 Aug 2020 10:30:19 -0300	[thread overview]
Message-ID: <20200824133019.GH1152540@nvidia.com> (raw)
In-Reply-To: <128192ad-05ff-fa8e-14fc-479a115311e0@acm.org>

On Sun, Aug 23, 2020 at 02:18:41PM -0700, Bart Van Assche wrote:
 
> The patch below is sufficient to unbreak blktests. I think that the
> deadlock while unloading rdma_rxe happens because the RDMA core waits for
> all ib_dev references to be dropped before dealloc_driver is called.

Which is required, yes

> The rdma_rxe dealloc_driver implementation drops an ib_dev
> reference. 

Where does it do that? I didn't notice it?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@nvidia.com>
To: lkp@lists.01.org
Subject: Re: [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143
Date: Mon, 24 Aug 2020 10:30:19 -0300	[thread overview]
Message-ID: <20200824133019.GH1152540@nvidia.com> (raw)
In-Reply-To: <128192ad-05ff-fa8e-14fc-479a115311e0@acm.org>

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

On Sun, Aug 23, 2020 at 02:18:41PM -0700, Bart Van Assche wrote:
 
> The patch below is sufficient to unbreak blktests. I think that the
> deadlock while unloading rdma_rxe happens because the RDMA core waits for
> all ib_dev references to be dropped before dealloc_driver is called.

Which is required, yes

> The rdma_rxe dealloc_driver implementation drops an ib_dev
> reference. 

Where does it do that? I didn't notice it?

Jason

  reply	other threads:[~2020-08-24 13:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-02  6:09 [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143 kernel test robot
2020-08-02  6:09 ` kernel test robot
2020-08-02 15:05 ` Bart Van Assche
2020-08-02 15:05   ` Bart Van Assche
2020-08-03  6:19   ` Yamin Friedman
2020-08-03  6:19     ` Yamin Friedman
2020-08-03  7:27     ` Sagi Grimberg
2020-08-23 21:18       ` Bart Van Assche
2020-08-23 21:18         ` Bart Van Assche
2020-08-24 13:30         ` Jason Gunthorpe [this message]
2020-08-24 13:30           ` Jason Gunthorpe
2020-09-07  2:58           ` Bart Van Assche
2020-09-07  2:58             ` Bart Van Assche
2020-09-08 18:22             ` Jason Gunthorpe
2020-09-08 18:22               ` Jason Gunthorpe
2020-09-09  2:01               ` Bart Van Assche
2020-09-09  2:01                 ` Bart Van Assche
2020-09-11 22:00                 ` Bart Van Assche
2020-09-11 22:00                   ` Bart Van Assche
2020-09-12  4:46                   ` Yi Zhang
2020-09-12  4:46                     ` Yi Zhang
2020-09-14 18:26                   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200824133019.GH1152540@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=bvanassche@acm.org \
    --cc=dledford@redhat.com \
    --cc=jgg+lists@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lkp@lists.01.org \
    --cc=maxg@mellanox.com \
    --cc=rong.a.chen@intel.com \
    --cc=sagi@grimberg.me \
    --cc=yaminf@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.