From: Catalin Marinas <catalin.marinas@arm.com>
To: chenzhou <chenzhou10@huawei.com>
Cc: Dave Young <dyoung@redhat.com>,
will@kernel.org, james.morse@arm.com, tglx@linutronix.de,
mingo@redhat.com, bhe@redhat.com, corbet@lwn.net,
John.P.donnelly@oracle.com, prabhakar.pkin@gmail.com,
bhsharma@redhat.com, horms@verge.net.au, robh+dt@kernel.org,
arnd@arndb.de, nsaenzjulienne@suse.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
linux-doc@vger.kernel.org, guohanjun@huawei.com,
xiexiuqi@huawei.com, huawei.libin@huawei.com,
wangkefeng.wang@huawei.com
Subject: Re: [PATCH v11 5/5] kdump: update Documentation about crashkernel
Date: Wed, 2 Sep 2020 17:42:52 +0100 [thread overview]
Message-ID: <20200902164251.GA16673@gaia> (raw)
In-Reply-To: <2e6aebf9-3765-5d8c-933c-698442db1d52@huawei.com>
On Tue, Aug 18, 2020 at 03:07:04PM +0800, chenzhou wrote:
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index a8e34d97a894..4df18c7ea438 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -147,7 +147,7 @@ static void __init reserve_crashkernel(void)
> }
> memblock_reserve(crash_base, crash_size);
>
> - if (crash_base >= CRASH_ADDR_LOW_MAX) {
> + if (memstart_addr < CRASH_ADDR_LOW_MAX && crash_base >= CRASH_ADDR_LOW_MAX) {
> const char *rename = "Crash kernel (low)";
Since CRASH_ADDR_LOW_MAX is defined as arm64_dma32_phys_limit and such
limit is always greater than memstart_addr, this additional check
doesn't do anything. See my other reply on how ZONE_DMA32 is created on
arm64.
--
Catalin
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: chenzhou <chenzhou10@huawei.com>
Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org,
bhsharma@redhat.com, huawei.libin@huawei.com,
guohanjun@huawei.com, will@kernel.org, bhe@redhat.com,
corbet@lwn.net, mingo@redhat.com, Dave Young <dyoung@redhat.com>,
John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com,
horms@verge.net.au, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
james.morse@arm.com, prabhakar.pkin@gmail.com,
nsaenzjulienne@suse.de
Subject: Re: [PATCH v11 5/5] kdump: update Documentation about crashkernel
Date: Wed, 2 Sep 2020 17:42:52 +0100 [thread overview]
Message-ID: <20200902164251.GA16673@gaia> (raw)
In-Reply-To: <2e6aebf9-3765-5d8c-933c-698442db1d52@huawei.com>
On Tue, Aug 18, 2020 at 03:07:04PM +0800, chenzhou wrote:
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index a8e34d97a894..4df18c7ea438 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -147,7 +147,7 @@ static void __init reserve_crashkernel(void)
> }
> memblock_reserve(crash_base, crash_size);
>
> - if (crash_base >= CRASH_ADDR_LOW_MAX) {
> + if (memstart_addr < CRASH_ADDR_LOW_MAX && crash_base >= CRASH_ADDR_LOW_MAX) {
> const char *rename = "Crash kernel (low)";
Since CRASH_ADDR_LOW_MAX is defined as arm64_dma32_phys_limit and such
limit is always greater than memstart_addr, this additional check
doesn't do anything. See my other reply on how ZONE_DMA32 is created on
arm64.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: chenzhou <chenzhou10@huawei.com>
Cc: wangkefeng.wang@huawei.com, linux-doc@vger.kernel.org,
bhsharma@redhat.com, huawei.libin@huawei.com,
guohanjun@huawei.com, will@kernel.org, bhe@redhat.com,
corbet@lwn.net, mingo@redhat.com, Dave Young <dyoung@redhat.com>,
John.P.donnelly@oracle.com, arnd@arndb.de, xiexiuqi@huawei.com,
horms@verge.net.au, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
james.morse@arm.com, prabhakar.pkin@gmail.com,
nsaenzjulienne@suse.de
Subject: Re: [PATCH v11 5/5] kdump: update Documentation about crashkernel
Date: Wed, 2 Sep 2020 17:42:52 +0100 [thread overview]
Message-ID: <20200902164251.GA16673@gaia> (raw)
In-Reply-To: <2e6aebf9-3765-5d8c-933c-698442db1d52@huawei.com>
On Tue, Aug 18, 2020 at 03:07:04PM +0800, chenzhou wrote:
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index a8e34d97a894..4df18c7ea438 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -147,7 +147,7 @@ static void __init reserve_crashkernel(void)
> }
> memblock_reserve(crash_base, crash_size);
>
> - if (crash_base >= CRASH_ADDR_LOW_MAX) {
> + if (memstart_addr < CRASH_ADDR_LOW_MAX && crash_base >= CRASH_ADDR_LOW_MAX) {
> const char *rename = "Crash kernel (low)";
Since CRASH_ADDR_LOW_MAX is defined as arm64_dma32_phys_limit and such
limit is always greater than memstart_addr, this additional check
doesn't do anything. See my other reply on how ZONE_DMA32 is created on
arm64.
--
Catalin
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-09-02 16:43 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 13:08 [PATCH v11 0/5] support reserving crashkernel above 4G on arm64 kdump Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` [PATCH v11 1/5] arm64: kdump: add macro CRASH_ALIGN and CRASH_ADDR_LOW_MAX Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` [PATCH v11 2/5] x86: kdump: move reserve_crashkernel_low() into crash_core.c Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-06 13:36 ` Ingo Molnar
2020-08-06 13:36 ` Ingo Molnar
2020-08-06 13:36 ` Ingo Molnar
2020-09-01 16:50 ` Catalin Marinas
2020-09-01 16:50 ` Catalin Marinas
2020-09-01 16:50 ` Catalin Marinas
2020-08-08 9:59 ` Dave Young
2020-08-08 9:59 ` Dave Young
2020-08-08 9:59 ` Dave Young
2020-08-01 13:08 ` [PATCH v11 3/5] arm64: kdump: reimplement crashkernel=X Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-09-02 17:09 ` Catalin Marinas
2020-09-02 17:09 ` Catalin Marinas
2020-09-02 17:09 ` Catalin Marinas
2020-09-03 11:26 ` chenzhou
2020-09-03 11:26 ` chenzhou
2020-09-03 11:26 ` chenzhou
2020-09-03 13:18 ` chenzhou
2020-09-03 13:18 ` chenzhou
2020-09-03 13:18 ` chenzhou
2020-09-04 3:04 ` Dave Young
2020-09-04 3:04 ` Dave Young
2020-09-04 3:04 ` Dave Young
2020-09-04 3:10 ` Dave Young
2020-09-04 3:10 ` Dave Young
2020-09-04 3:10 ` Dave Young
2020-09-04 4:02 ` chenzhou
2020-09-04 4:02 ` chenzhou
2020-09-04 4:02 ` chenzhou
2020-09-04 4:16 ` Dave Young
2020-09-04 4:16 ` Dave Young
2020-09-04 4:16 ` Dave Young
2020-09-04 6:39 ` chenzhou
2020-09-04 6:39 ` chenzhou
2020-09-04 6:39 ` chenzhou
2020-08-01 13:08 ` [PATCH v11 4/5] arm64: kdump: add memory for devices by DT property linux,usable-memory-range Chen Zhou
2020-08-01 13:08 ` [PATCH v11 4/5] arm64: kdump: add memory for devices by DT property linux, usable-memory-range Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` [PATCH v11 5/5] kdump: update Documentation about crashkernel Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-01 13:08 ` Chen Zhou
2020-08-08 10:02 ` Dave Young
2020-08-08 10:02 ` Dave Young
2020-08-08 10:02 ` Dave Young
2020-08-10 3:28 ` chenzhou
2020-08-10 3:28 ` chenzhou
2020-08-10 3:28 ` chenzhou
2020-08-10 5:59 ` Dave Young
2020-08-10 5:59 ` Dave Young
2020-08-10 5:59 ` Dave Young
2020-08-10 6:03 ` Dave Young
2020-08-10 6:03 ` Dave Young
2020-08-10 6:03 ` Dave Young
2020-08-18 7:07 ` chenzhou
2020-08-18 7:07 ` chenzhou
2020-08-18 7:07 ` chenzhou
2020-08-19 12:03 ` Dave Young
2020-08-19 12:03 ` Dave Young
2020-08-19 12:03 ` Dave Young
2020-08-28 1:59 ` chenzhou
2020-08-28 1:59 ` chenzhou
2020-08-28 1:59 ` chenzhou
2020-09-01 17:13 ` Catalin Marinas
2020-09-01 17:13 ` Catalin Marinas
2020-09-01 17:13 ` Catalin Marinas
2020-09-02 16:42 ` Catalin Marinas [this message]
2020-09-02 16:42 ` Catalin Marinas
2020-09-02 16:42 ` Catalin Marinas
2020-09-02 17:13 ` Catalin Marinas
2020-09-02 17:13 ` Catalin Marinas
2020-09-02 17:13 ` Catalin Marinas
2020-09-03 11:56 ` chenzhou
2020-09-03 11:56 ` chenzhou
2020-09-03 11:56 ` chenzhou
2020-08-06 11:37 ` [PATCH v11 0/5] support reserving crashkernel above 4G on arm64 kdump Dave Young
2020-08-06 11:37 ` Dave Young
2020-08-06 11:37 ` Dave Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902164251.GA16673@gaia \
--to=catalin.marinas@arm.com \
--cc=John.P.donnelly@oracle.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bhsharma@redhat.com \
--cc=chenzhou10@huawei.com \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=guohanjun@huawei.com \
--cc=horms@verge.net.au \
--cc=huawei.libin@huawei.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nsaenzjulienne@suse.de \
--cc=prabhakar.pkin@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.