From: Karthik B S <karthik.b.s@intel.com> To: intel-gfx@lists.freedesktop.org Cc: paulo.r.zanoni@intel.com, michel@daenzer.net, Karthik B S <karthik.b.s@intel.com>, dri-devel@lists.freedesktop.org, vandita.kulkarni@intel.com, uma.shankar@intel.com, daniel.vetter@intel.com, nicholas.kazlauskas@amd.com Subject: [PATCH v7 2/7] drm/i915: Add support for async flips in I915 Date: Fri, 4 Sep 2020 17:03:25 +0530 [thread overview] Message-ID: <20200904113330.19815-3-karthik.b.s@intel.com> (raw) In-Reply-To: <20200904113330.19815-1-karthik.b.s@intel.com> Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook for async flip case (Ville) v5: -Rebased. v6: -Move the plane hook to separate patch. (Paulo) -Remove the early return in skl_plane_ctl. (Paulo) v7: -Move async address update enable to skl_plane_ctl_crtc() (Ville) Signed-off-by: Karthik B S <karthik.b.s@intel.com> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 25cea9592891..c795ea01cec3 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -4784,6 +4784,9 @@ u32 skl_plane_ctl_crtc(const struct intel_crtc_state *crtc_state) struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev); u32 plane_ctl = 0; + if (crtc_state->uapi.async_flip) + plane_ctl |= PLANE_CTL_ASYNC_FLIP; + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) return plane_ctl; diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index ab4b1abd4364..abf43e63264c 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -6924,6 +6924,7 @@ enum { #define PLANE_CTL_TILED_X (1 << 10) #define PLANE_CTL_TILED_Y (4 << 10) #define PLANE_CTL_TILED_YF (5 << 10) +#define PLANE_CTL_ASYNC_FLIP (1 << 9) #define PLANE_CTL_FLIP_HORIZONTAL (1 << 8) #define PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE (1 << 4) /* TGL+ */ #define PLANE_CTL_ALPHA_MASK (0x3 << 4) /* Pre-GLK */ -- 2.22.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Karthik B S <karthik.b.s@intel.com> To: intel-gfx@lists.freedesktop.org Cc: paulo.r.zanoni@intel.com, michel@daenzer.net, dri-devel@lists.freedesktop.org, daniel.vetter@intel.com, harry.wentland@amd.com, nicholas.kazlauskas@amd.com Subject: [Intel-gfx] [PATCH v7 2/7] drm/i915: Add support for async flips in I915 Date: Fri, 4 Sep 2020 17:03:25 +0530 [thread overview] Message-ID: <20200904113330.19815-3-karthik.b.s@intel.com> (raw) In-Reply-To: <20200904113330.19815-1-karthik.b.s@intel.com> Set the Async Address Update Enable bit in plane ctl when async flip is requested. v2: -Move the Async flip enablement to individual patch (Paulo) v3: -Rebased. v4: -Add separate plane hook for async flip case (Ville) v5: -Rebased. v6: -Move the plane hook to separate patch. (Paulo) -Remove the early return in skl_plane_ctl. (Paulo) v7: -Move async address update enable to skl_plane_ctl_crtc() (Ville) Signed-off-by: Karthik B S <karthik.b.s@intel.com> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com> --- drivers/gpu/drm/i915/display/intel_display.c | 3 +++ drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 25cea9592891..c795ea01cec3 100644 --- a/drivers/gpu/drm/i915/display/intel_display.c +++ b/drivers/gpu/drm/i915/display/intel_display.c @@ -4784,6 +4784,9 @@ u32 skl_plane_ctl_crtc(const struct intel_crtc_state *crtc_state) struct drm_i915_private *dev_priv = to_i915(crtc_state->uapi.crtc->dev); u32 plane_ctl = 0; + if (crtc_state->uapi.async_flip) + plane_ctl |= PLANE_CTL_ASYNC_FLIP; + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) return plane_ctl; diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index ab4b1abd4364..abf43e63264c 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_reg.h @@ -6924,6 +6924,7 @@ enum { #define PLANE_CTL_TILED_X (1 << 10) #define PLANE_CTL_TILED_Y (4 << 10) #define PLANE_CTL_TILED_YF (5 << 10) +#define PLANE_CTL_ASYNC_FLIP (1 << 9) #define PLANE_CTL_FLIP_HORIZONTAL (1 << 8) #define PLANE_CTL_MEDIA_DECOMPRESSION_ENABLE (1 << 4) /* TGL+ */ #define PLANE_CTL_ALPHA_MASK (0x3 << 4) /* Pre-GLK */ -- 2.22.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-09-04 12:00 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-04 11:33 [PATCH v7 0/7] Asynchronous flip implementation for i915 Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 11:33 ` [PATCH v7 1/7] drm/i915: Add enable/disable flip done and flip done handler Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 11:33 ` Karthik B S [this message] 2020-09-04 11:33 ` [Intel-gfx] [PATCH v7 2/7] drm/i915: Add support for async flips in I915 Karthik B S 2020-09-04 11:33 ` [PATCH v7 3/7] drm/i915: Add checks specific to async flips Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 11:33 ` [PATCH v7 4/7] drm/i915: Do not call drm_crtc_arm_vblank_event in " Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 11:33 ` [PATCH v7 5/7] drm/i915: Add dedicated plane hook for async flip case Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 11:33 ` [PATCH v7 6/7] Documentation/gpu: Add asynchronous flip documentation for i915 Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 11:33 ` [PATCH v7 7/7] drm/i915: Enable async flips in i915 Karthik B S 2020-09-04 11:33 ` [Intel-gfx] " Karthik B S 2020-09-04 13:45 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Asynchronous flip implementation for i915 (rev7) Patchwork 2020-09-04 14:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-09-05 0:10 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200904113330.19815-3-karthik.b.s@intel.com \ --to=karthik.b.s@intel.com \ --cc=daniel.vetter@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=michel@daenzer.net \ --cc=nicholas.kazlauskas@amd.com \ --cc=paulo.r.zanoni@intel.com \ --cc=uma.shankar@intel.com \ --cc=vandita.kulkarni@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.