From: Christoph Hellwig <hch@infradead.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH] iomap: Fix direct I/O write consistency check
Date: Mon, 7 Sep 2020 08:07:01 +0100 [thread overview]
Message-ID: <20200907070701.GA27019@infradead.org> (raw)
In-Reply-To: <20200903165632.1338996-1-agruenba@redhat.com>
On Thu, Sep 03, 2020 at 06:56:32PM +0200, Andreas Gruenbacher wrote:
> When a direct I/O write falls back to buffered I/O entirely, dio->size
> will be 0 in iomap_dio_complete. Function invalidate_inode_pages2_range
> will try to invalidate the rest of the address space. If there are any
> dirty pages in that range, the write will fail and a "Page cache
> invalidation failure on direct I/O" error will be logged.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] iomap: Fix direct I/O write consistency check
Date: Mon, 7 Sep 2020 08:07:01 +0100 [thread overview]
Message-ID: <20200907070701.GA27019@infradead.org> (raw)
In-Reply-To: <20200903165632.1338996-1-agruenba@redhat.com>
On Thu, Sep 03, 2020 at 06:56:32PM +0200, Andreas Gruenbacher wrote:
> When a direct I/O write falls back to buffered I/O entirely, dio->size
> will be 0 in iomap_dio_complete. Function invalidate_inode_pages2_range
> will try to invalidate the rest of the address space. If there are any
> dirty pages in that range, the write will fail and a "Page cache
> invalidation failure on direct I/O" error will be logged.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-09-07 7:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 16:56 [PATCH] iomap: Fix direct I/O write consistency check Andreas Gruenbacher
2020-09-03 16:56 ` [Cluster-devel] " Andreas Gruenbacher
2020-09-03 21:12 ` Eric Sandeen
2020-09-03 21:12 ` [Cluster-devel] " Eric Sandeen
2020-09-03 21:47 ` Andreas Gruenbacher
2020-09-03 21:47 ` [Cluster-devel] " Andreas Gruenbacher
2020-09-07 7:07 ` Christoph Hellwig [this message]
2020-09-07 7:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907070701.GA27019@infradead.org \
--to=hch@infradead.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.