From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-kernel@vger.kernel.org
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2 1/3] mtd: lpddr: Fix bad logic in print_drs_error
Date: Mon, 7 Sep 2020 09:34:46 +0200 [thread overview]
Message-ID: <20200907073446.27727-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <3fb0e29f5b601db8be2938a01d974b00c8788501.1588016644.git.gustavo@embeddedor.com>
On Mon, 2020-04-27 at 19:50:37 UTC, "Gustavo A. R. Silva" wrote:
> Update logic for broken test. Use a more common logging style.
>
> It appears the logic in this function is broken for the
> consecutive tests of
>
> if (prog_status & 0x3)
> ...
> else if (prog_status & 0x2)
> ...
> else (prog_status & 0x1)
> ...
>
> Likely the first test should be
>
> if ((prog_status & 0x3) == 0x3)
>
> Found by inspection of include files using printk.
>
> Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition")
> Cc: stable@vger.kernel.org
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
linux-kernel@vger.kernel.org
Cc: Joe Perches <joe@perches.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Vignesh Raghavendra <vigneshr@ti.com>,
Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v2 1/3] mtd: lpddr: Fix bad logic in print_drs_error
Date: Mon, 7 Sep 2020 09:34:46 +0200 [thread overview]
Message-ID: <20200907073446.27727-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <3fb0e29f5b601db8be2938a01d974b00c8788501.1588016644.git.gustavo@embeddedor.com>
On Mon, 2020-04-27 at 19:50:37 UTC, "Gustavo A. R. Silva" wrote:
> Update logic for broken test. Use a more common logging style.
>
> It appears the logic in this function is broken for the
> consecutive tests of
>
> if (prog_status & 0x3)
> ...
> else if (prog_status & 0x2)
> ...
> else (prog_status & 0x1)
> ...
>
> Likely the first test should be
>
> if ((prog_status & 0x3) == 0x3)
>
> Found by inspection of include files using printk.
>
> Fixes: eb3db27507f7 ("[MTD] LPDDR PFOW definition")
> Cc: stable@vger.kernel.org
> Reported-by: Joe Perches <joe@perches.com>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.
Miquel
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-09-07 7:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 19:48 [PATCH v2 0/3] mtd: lpddr: Fix bad logic bug in print_drs_error Gustavo A. R. Silva
2020-04-27 19:48 ` Gustavo A. R. Silva
2020-04-27 19:50 ` [PATCH v2 1/3] mtd: lpddr: Fix bad logic " Gustavo A. R. Silva
2020-04-27 19:50 ` Gustavo A. R. Silva
2020-04-27 20:08 ` Miquel Raynal
2020-04-27 20:08 ` Miquel Raynal
2020-05-19 16:22 ` Gustavo A. R. Silva
2020-05-19 16:22 ` Gustavo A. R. Silva
2020-09-07 7:34 ` Miquel Raynal [this message]
2020-09-07 7:34 ` Miquel Raynal
2020-04-27 19:54 ` [PATCH v2 2/3] mtd: lpddr: Replace printk with pr_notice Gustavo A. R. Silva
2020-04-27 19:54 ` Gustavo A. R. Silva
2020-04-27 20:09 ` Miquel Raynal
2020-04-27 20:09 ` Miquel Raynal
2020-09-07 7:34 ` Miquel Raynal
2020-09-07 7:34 ` Miquel Raynal
2020-04-27 19:56 ` [PATCH v2 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c Gustavo A. R. Silva
2020-04-27 19:56 ` Gustavo A. R. Silva
2020-04-27 20:09 ` Miquel Raynal
2020-04-27 20:09 ` Miquel Raynal
2020-09-07 7:34 ` Miquel Raynal
2020-09-07 7:34 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907073446.27727-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=gustavo@embeddedor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.