Re: [PATCH v7 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration

From: kernel test robot <lkp@intel.com>
To: Cheng-Yi Chiang <cychiang@chromium.org>, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, Mark Brown <broonie@kernel.org>,
	Taniya Das <tdas@codeaurora.org>,
	Rohit kumar <rohitkr@codeaurora.org>,
	Banajit Goswami <bgoswami@codeaurora.org>,
	Patrick Lai <plai@codeaurora.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v7 3/3] ASoC: qcom: sc7180: Add machine driver for sound card registration
Date: Mon, 7 Sep 2020 20:08:48 +0800	[thread overview]
Message-ID: <202009072032.9yLwcLu0%lkp@intel.com> (raw)
In-Reply-To: <20200907100039.1731457-4-cychiang@chromium.org>

[-- Attachment #1: Type: text/plain, Size: 3908 bytes --]

Hi Cheng-Yi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on asoc/for-next]
[also build test ERROR on next-20200903]
[cannot apply to linux/master sound/for-next rockchip/for-next linus/master v5.9-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Cheng-Yi-Chiang/Add-documentation-and-machine-driver-for-SC7180-sound-card/20200907-180250
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: nios2-allyesconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   sound/soc/qcom/sc7180.c: In function 'sc7180_snd_startup':
>> sound/soc/qcom/sc7180.c:144:7: error: 'HDMI' undeclared (first use in this function)
     144 |  case HDMI:
         |       ^~~~
   sound/soc/qcom/sc7180.c:144:7: note: each undeclared identifier is reported only once for each function it appears in
   sound/soc/qcom/sc7180.c: In function 'sc7180_snd_shutdown':
   sound/soc/qcom/sc7180.c:172:7: error: 'HDMI' undeclared (first use in this function)
     172 |  case HDMI:
         |       ^~~~

# https://github.com/0day-ci/linux/commit/54ab0f3cb3682429fc199d9b30572f67a967b30b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cheng-Yi-Chiang/Add-documentation-and-machine-driver-for-SC7180-sound-card/20200907-180250
git checkout 54ab0f3cb3682429fc199d9b30572f67a967b30b
vim +/HDMI +144 sound/soc/qcom/sc7180.c

   101	
   102	static int sc7180_snd_startup(struct snd_pcm_substream *substream)
   103	{
   104		struct snd_soc_pcm_runtime *rtd = substream->private_data;
   105		struct snd_soc_card *card = rtd->card;
   106		struct sc7180_snd_data *data = snd_soc_card_get_drvdata(card);
   107		struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
   108		struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
   109		int ret;
   110	
   111		switch (cpu_dai->id) {
   112		case MI2S_PRIMARY:
   113			if (++data->pri_mi2s_clk_count == 1) {
   114				snd_soc_dai_set_sysclk(cpu_dai,
   115						       LPASS_MCLK0,
   116						       DEFAULT_MCLK_RATE,
   117						       SNDRV_PCM_STREAM_PLAYBACK);
   118			}
   119	
   120			snd_soc_dai_set_fmt(codec_dai,
   121					    SND_SOC_DAIFMT_CBS_CFS |
   122					    SND_SOC_DAIFMT_NB_NF |
   123					    SND_SOC_DAIFMT_I2S);
   124	
   125			/* Configure PLL1 for codec */
   126			ret = snd_soc_dai_set_pll(codec_dai, 0, RT5682_PLL1_S_MCLK,
   127						  DEFAULT_MCLK_RATE, RT5682_PLL1_FREQ);
   128			if (ret) {
   129				dev_err(rtd->dev, "can't set codec pll: %d\n", ret);
   130				return ret;
   131			}
   132	
   133			/* Configure sysclk for codec */
   134			ret = snd_soc_dai_set_sysclk(codec_dai, RT5682_SCLK_S_PLL1,
   135						     RT5682_PLL1_FREQ,
   136						     SND_SOC_CLOCK_IN);
   137			if (ret)
   138				dev_err(rtd->dev, "snd_soc_dai_set_sysclk err = %d\n",
   139					ret);
   140	
   141			break;
   142		case MI2S_SECONDARY:
   143			break;
 > 144		case HDMI:
   145			break;
   146		default:
   147			dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__,
   148				cpu_dai->id);
   149			return -EINVAL;
   150		}
   151		return 0;
   152	}
   153	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 57205 bytes --]