From: Vinod Koul <vkoul@kernel.org> To: Jaroslav Kysela <perex@perex.cz> Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, mengdong.lin@intel.com, sanyog.r.kale@intel.com, Bard Liao <yung-chuan.liao@linux.intel.com>, rander.wang@linux.intel.com, bard.liao@intel.com Subject: Re: [PATCH] soundwire: cadence: fix race condition between suspend and Slave device alerts Date: Wed, 9 Sep 2020 13:29:22 +0530 [thread overview] Message-ID: <20200909075922.GM77521@vkoul-mobl> (raw) In-Reply-To: <3e4dee4b-1309-2d3e-ae20-e2dcbadb2f40@perex.cz> On 08-09-20, 13:58, Jaroslav Kysela wrote: > Dne 28. 08. 20 v 17:14 Pierre-Louis Bossart napsal(a): > > > > > > > >> Is this timeout for suspend or resume? Somehow I was under the > >> assumption that it is former? Or is the result seen on resume? > >> > >> Rereading the race describe above in steps, I think this should be > >> handled in step c above. Btw is that suspend or runtime suspend which > >> causes this? Former would be bigger issue as we should not have work > >> running when we return from suspend call. Latter should be dealt with > >> anyway as device might be off after suspend. > > > > This happens with a system suspend. Because we disable the interrupts, > > the workqueue never completes, and we have a timeout on system resume. > > > > That's why we want to prevent the workqueue from starting, or let it > > complete, but not have this zombie state where we suspend but there's > > still a wait for completion that times out later. The point here is > > really making sure the workqueue is not used before suspend. > > > > Vinod, there is no acceptance progress on this. The patch is really straight > and for the Intel controller. They know what they're doing. I would apply > this. The code can be refined at anytime. It's a fix. I tested it and I can > confirm, that it fixes the issue. It's a vital patch for 5.10 to enable > finally SoundWire drivers for the Intel hardware. I do feel that there is something else going on, but not able to pin point, anyway this fixes the issue so I am applying it now > > Acked-by: Jaroslav Kysela <perex@perex.cz> Thanks for ack -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Jaroslav Kysela <perex@perex.cz> Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, ranjani.sridharan@linux.intel.com, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, hui.wang@canonical.com, broonie@kernel.org, srinivas.kandagatla@linaro.org, bard.liao@intel.com, jank@cadence.com, mengdong.lin@intel.com, sanyog.r.kale@intel.com, Bard Liao <yung-chuan.liao@linux.intel.com>, rander.wang@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soundwire: cadence: fix race condition between suspend and Slave device alerts Date: Wed, 9 Sep 2020 13:29:22 +0530 [thread overview] Message-ID: <20200909075922.GM77521@vkoul-mobl> (raw) In-Reply-To: <3e4dee4b-1309-2d3e-ae20-e2dcbadb2f40@perex.cz> On 08-09-20, 13:58, Jaroslav Kysela wrote: > Dne 28. 08. 20 v 17:14 Pierre-Louis Bossart napsal(a): > > > > > > > >> Is this timeout for suspend or resume? Somehow I was under the > >> assumption that it is former? Or is the result seen on resume? > >> > >> Rereading the race describe above in steps, I think this should be > >> handled in step c above. Btw is that suspend or runtime suspend which > >> causes this? Former would be bigger issue as we should not have work > >> running when we return from suspend call. Latter should be dealt with > >> anyway as device might be off after suspend. > > > > This happens with a system suspend. Because we disable the interrupts, > > the workqueue never completes, and we have a timeout on system resume. > > > > That's why we want to prevent the workqueue from starting, or let it > > complete, but not have this zombie state where we suspend but there's > > still a wait for completion that times out later. The point here is > > really making sure the workqueue is not used before suspend. > > > > Vinod, there is no acceptance progress on this. The patch is really straight > and for the Intel controller. They know what they're doing. I would apply > this. The code can be refined at anytime. It's a fix. I tested it and I can > confirm, that it fixes the issue. It's a vital patch for 5.10 to enable > finally SoundWire drivers for the Intel hardware. I do feel that there is something else going on, but not able to pin point, anyway this fixes the issue so I am applying it now > > Acked-by: Jaroslav Kysela <perex@perex.cz> Thanks for ack -- ~Vinod
next prev parent reply other threads:[~2020-09-09 7:59 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-17 22:23 [PATCH] soundwire: cadence: fix race condition between suspend and Slave device alerts Bard Liao 2020-08-17 22:23 ` Bard Liao 2020-08-19 9:06 ` Vinod Koul 2020-08-19 9:06 ` Vinod Koul 2020-08-19 12:51 ` Pierre-Louis Bossart 2020-08-21 5:07 ` Vinod Koul 2020-08-21 5:07 ` Vinod Koul 2020-08-21 15:17 ` Pierre-Louis Bossart 2020-08-21 15:17 ` Pierre-Louis Bossart 2020-08-28 8:00 ` Vinod Koul 2020-08-28 8:00 ` Vinod Koul 2020-08-28 15:14 ` Pierre-Louis Bossart 2020-08-28 15:14 ` Pierre-Louis Bossart 2020-09-08 11:58 ` Jaroslav Kysela 2020-09-09 7:59 ` Vinod Koul [this message] 2020-09-09 7:59 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200909075922.GM77521@vkoul-mobl \ --to=vkoul@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=bard.liao@intel.com \ --cc=broonie@kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=hui.wang@canonical.com \ --cc=jank@cadence.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mengdong.lin@intel.com \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=rander.wang@linux.intel.com \ --cc=ranjani.sridharan@linux.intel.com \ --cc=sanyog.r.kale@intel.com \ --cc=srinivas.kandagatla@linaro.org \ --cc=tiwai@suse.de \ --cc=yung-chuan.liao@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.