From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: David Hildenbrand <david@redhat.com>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Jason Gunthorpe <jgg@ziepe.ca>,
Kees Cook <keescook@chromium.org>,
Ard Biesheuvel <ardb@kernel.org>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH v2 1/7] kernel/resource: make release_mem_region_adjustable() never fail
Date: Tue, 15 Sep 2020 17:06:12 +0800 [thread overview]
Message-ID: <20200915090612.GA6936@L-31X9LVDL-1304.local> (raw)
In-Reply-To: <927904b1-1909-f11f-483e-8012bda8ad0c@redhat.com>
On Tue, Sep 15, 2020 at 09:35:30AM +0200, David Hildenbrand wrote:
>
>>> static int __ref try_remove_memory(int nid, u64 start, u64 size)
>>> {
>>> int rc = 0;
>>> @@ -1777,7 +1757,7 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size)
>>> memblock_remove(start, size);
>>> }
>>>
>>> - __release_memory_resource(start, size);
>>> + release_mem_region_adjustable(&iomem_resource, start, size);
>>>
>>
>> Seems the only user of release_mem_region_adjustable() is here, can we move
>> iomem_resource into the function body? Actually, we don't iterate the resource
>> tree from any level. We always start from the root.
>
>You mean, making iomem_resource implicit? I can spot that something
>similar was done for
>
>#define devm_release_mem_region(dev, start, n) \
> __devm_release_region(dev, &iomem_resource, (start), (n))
>
What I prefer is remove iomem_resource from the parameter list. Just use is in
the function body.
For the example you listed, __release_region() would have varies of *parent*,
which looks reasonable to keep it here.
>I'll send an addon patch for that, ok? - thanks.
>
>--
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
_______________________________________________
Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org
To unsubscribe send an email to linux-nvdimm-leave@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: David Hildenbrand <david@redhat.com>
Cc: Wei Yang <richard.weiyang@linux.alibaba.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, linux-mm@kvack.org,
linux-hyperv@vger.kernel.org, xen-devel@lists.xenproject.org,
linux-acpi@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Dan Williams <dan.j.williams@intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Kees Cook <keescook@chromium.org>,
Ard Biesheuvel <ardb@kernel.org>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH v2 1/7] kernel/resource: make release_mem_region_adjustable() never fail
Date: Tue, 15 Sep 2020 17:06:12 +0800 [thread overview]
Message-ID: <20200915090612.GA6936@L-31X9LVDL-1304.local> (raw)
In-Reply-To: <927904b1-1909-f11f-483e-8012bda8ad0c@redhat.com>
On Tue, Sep 15, 2020 at 09:35:30AM +0200, David Hildenbrand wrote:
>
>>> static int __ref try_remove_memory(int nid, u64 start, u64 size)
>>> {
>>> int rc = 0;
>>> @@ -1777,7 +1757,7 @@ static int __ref try_remove_memory(int nid, u64 start, u64 size)
>>> memblock_remove(start, size);
>>> }
>>>
>>> - __release_memory_resource(start, size);
>>> + release_mem_region_adjustable(&iomem_resource, start, size);
>>>
>>
>> Seems the only user of release_mem_region_adjustable() is here, can we move
>> iomem_resource into the function body? Actually, we don't iterate the resource
>> tree from any level. We always start from the root.
>
>You mean, making iomem_resource implicit? I can spot that something
>similar was done for
>
>#define devm_release_mem_region(dev, start, n) \
> __devm_release_region(dev, &iomem_resource, (start), (n))
>
What I prefer is remove iomem_resource from the parameter list. Just use is in
the function body.
For the example you listed, __release_region() would have varies of *parent*,
which looks reasonable to keep it here.
>I'll send an addon patch for that, ok? - thanks.
>
>--
>Thanks,
>
>David / dhildenb
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2020-09-15 9:06 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 20:10 [PATCH v2 0/7] mm/memory_hotplug: selective merging of system ram resources David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` [PATCH v2 1/7] kernel/resource: make release_mem_region_adjustable() never fail David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-15 2:07 ` Wei Yang
2020-09-15 2:07 ` Wei Yang
2020-09-15 2:10 ` Wei Yang
2020-09-15 2:10 ` Wei Yang
2020-09-15 7:35 ` David Hildenbrand
2020-09-15 7:35 ` David Hildenbrand
2020-09-15 7:35 ` David Hildenbrand
2020-09-15 9:06 ` Wei Yang [this message]
2020-09-15 9:06 ` Wei Yang
2020-09-15 9:15 ` David Hildenbrand
2020-09-15 9:15 ` David Hildenbrand
2020-09-15 9:15 ` David Hildenbrand
2020-09-15 9:33 ` Wei Yang
2020-09-15 9:33 ` Wei Yang
2020-09-08 20:10 ` [PATCH v2 2/7] kernel/resource: move and rename IORESOURCE_MEM_DRIVER_MANAGED David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-09 7:16 ` Greg Kroah-Hartman
2020-09-09 7:16 ` Greg Kroah-Hartman
2020-09-09 7:16 ` Greg Kroah-Hartman
2020-09-09 7:16 ` Greg Kroah-Hartman
2020-09-09 7:27 ` David Hildenbrand
2020-09-09 7:27 ` David Hildenbrand
2020-09-09 7:27 ` David Hildenbrand
2020-09-09 7:27 ` David Hildenbrand
2020-09-15 2:20 ` Wei Yang
2020-09-15 2:20 ` Wei Yang
2020-09-15 2:20 ` Wei Yang
2020-09-15 7:37 ` David Hildenbrand
2020-09-15 7:37 ` David Hildenbrand
2020-09-15 7:37 ` David Hildenbrand
2020-09-15 7:37 ` David Hildenbrand
2020-09-08 20:10 ` [PATCH v2 3/7] mm/memory_hotplug: prepare passing flags to add_memory() and friends David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 7:17 ` Greg Kroah-Hartman
2020-09-09 7:17 ` Greg Kroah-Hartman
2020-09-09 7:17 ` Greg Kroah-Hartman
2020-09-09 7:17 ` Greg Kroah-Hartman
2020-09-09 7:28 ` David Hildenbrand
2020-09-09 7:28 ` David Hildenbrand
2020-09-09 7:28 ` David Hildenbrand
2020-09-09 7:28 ` David Hildenbrand
2020-09-09 11:24 ` Michael Ellerman
2020-09-09 11:24 ` Michael Ellerman
2020-09-09 11:24 ` Michael Ellerman
2020-09-09 11:24 ` Michael Ellerman
2020-09-09 11:37 ` David Hildenbrand
2020-09-09 11:37 ` David Hildenbrand
2020-09-09 11:37 ` David Hildenbrand
2020-09-09 11:37 ` David Hildenbrand
2020-09-09 11:51 ` David Hildenbrand
2020-09-09 11:51 ` David Hildenbrand
2020-09-09 11:51 ` David Hildenbrand
2020-09-09 11:51 ` David Hildenbrand
2020-09-08 20:10 ` [PATCH v2 4/7] mm/memory_hotplug: MEMHP_MERGE_RESOURCE to specify merging of System RAM resources David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` [PATCH v2 5/7] virtio-mem: try to merge system ram resources David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` [PATCH v2 6/7] xen/balloon: " David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 5:18 ` Jürgen Groß
2020-09-09 5:18 ` Jürgen Groß
2020-09-08 20:10 ` [PATCH v2 7/7] hv_balloon: " David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-08 20:10 ` David Hildenbrand
2020-09-09 9:43 ` Wei Liu
2020-09-09 9:43 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915090612.GA6936@L-31X9LVDL-1304.local \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=bhe@redhat.com \
--cc=david@redhat.com \
--cc=jgg@ziepe.ca \
--cc=keescook@chromium.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.