From: Rob Herring <robh@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Russell King" <linux@armlinux.org.uk>,
"Jason Cooper" <jason@lakedaemon.net>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Joel Stanley" <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Tero Kristo" <t-kristo@ti.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Guenter Roeck" <linux@roeck-us.net>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org,
linux-mediatek@lists.infradead.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema
Date: Tue, 15 Sep 2020 13:47:40 -0600 [thread overview]
Message-ID: <20200915194740.GA2385241@bogus> (raw)
In-Reply-To: <20200910191305.phjtijx2fhkhqavu@akan>
On Thu, Sep 10, 2020 at 02:13:05PM -0500, Nishanth Menon wrote:
> On 20:53-20200910, Krzysztof Kozlowski wrote:
> > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon <nm@ti.com> wrote:
> > >
> > > On 19:57-20200910, Krzysztof Kozlowski wrote:
> > > [...]
> > > > + wakeup-source:
> > > > + $ref: /schemas/types.yaml#/definitions/flag
> > > > +
> > > > +patternProperties:
> > > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> > >
> > > I wonder if "hog" is too generic and might clash with "something-hog" in
> > > the future?
> >
> > This pattern is already used in
> > Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml. It will
> > match only children and so far it did not find any other nodes in ARM
> > and ARM64 dts. I don't expect clashes. Also the question is then - if
> > one adds a child of GPIO expander named "foobar-hog" and it is not a
> > GPIO hog, then what is it?
>
> Probably a nitpick.. but then,.. I have'nt seen us depend on hierarchy
> for uniqueness of naming.. we choose for example "bus" no matter where
> in the hierarchy it falls in, as long it is a bus.. etc.. same argument
> holds good for properties as well.. "gpio-hog;" is kinda redundant if
> you think of it for a compatible that is already gpio ;)..
>
> I did'nt mean to de-rail the discussion, but was curious what the DT
> maintainers think..
Not really a fan of gpio-hog binding to have another type of hog nor can
I imagine what that would be.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Tony Lindgren" <tony@atomide.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-renesas-soc@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
"Guenter Roeck" <linux@roeck-us.net>,
"NXP Linux Team" <linux-imx@nxp.com>,
devicetree@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-mediatek@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Andrew Jeffery" <andrew@aj.id.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema
Date: Tue, 15 Sep 2020 13:47:40 -0600 [thread overview]
Message-ID: <20200915194740.GA2385241@bogus> (raw)
In-Reply-To: <20200910191305.phjtijx2fhkhqavu@akan>
On Thu, Sep 10, 2020 at 02:13:05PM -0500, Nishanth Menon wrote:
> On 20:53-20200910, Krzysztof Kozlowski wrote:
> > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon <nm@ti.com> wrote:
> > >
> > > On 19:57-20200910, Krzysztof Kozlowski wrote:
> > > [...]
> > > > + wakeup-source:
> > > > + $ref: /schemas/types.yaml#/definitions/flag
> > > > +
> > > > +patternProperties:
> > > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> > >
> > > I wonder if "hog" is too generic and might clash with "something-hog" in
> > > the future?
> >
> > This pattern is already used in
> > Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml. It will
> > match only children and so far it did not find any other nodes in ARM
> > and ARM64 dts. I don't expect clashes. Also the question is then - if
> > one adds a child of GPIO expander named "foobar-hog" and it is not a
> > GPIO hog, then what is it?
>
> Probably a nitpick.. but then,.. I have'nt seen us depend on hierarchy
> for uniqueness of naming.. we choose for example "bus" no matter where
> in the hierarchy it falls in, as long it is a bus.. etc.. same argument
> holds good for properties as well.. "gpio-hog;" is kinda redundant if
> you think of it for a compatible that is already gpio ;)..
>
> I did'nt mean to de-rail the discussion, but was curious what the DT
> maintainers think..
Not really a fan of gpio-hog binding to have another type of hog nor can
I imagine what that would be.
Rob
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Tony Lindgren" <tony@atomide.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Michal Simek" <michal.simek@xilinx.com>,
linux-renesas-soc@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Joel Stanley" <joel@jms.id.au>,
"Guenter Roeck" <linux@roeck-us.net>,
"NXP Linux Team" <linux-imx@nxp.com>,
devicetree@vger.kernel.org, "Jason Cooper" <jason@lakedaemon.net>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
linux-mediatek@lists.infradead.org,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Andrew Jeffery" <andrew@aj.id.au>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Tero Kristo" <t-kristo@ti.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema
Date: Tue, 15 Sep 2020 13:47:40 -0600 [thread overview]
Message-ID: <20200915194740.GA2385241@bogus> (raw)
In-Reply-To: <20200910191305.phjtijx2fhkhqavu@akan>
On Thu, Sep 10, 2020 at 02:13:05PM -0500, Nishanth Menon wrote:
> On 20:53-20200910, Krzysztof Kozlowski wrote:
> > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon <nm@ti.com> wrote:
> > >
> > > On 19:57-20200910, Krzysztof Kozlowski wrote:
> > > [...]
> > > > + wakeup-source:
> > > > + $ref: /schemas/types.yaml#/definitions/flag
> > > > +
> > > > +patternProperties:
> > > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$":
> > >
> > > I wonder if "hog" is too generic and might clash with "something-hog" in
> > > the future?
> >
> > This pattern is already used in
> > Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml. It will
> > match only children and so far it did not find any other nodes in ARM
> > and ARM64 dts. I don't expect clashes. Also the question is then - if
> > one adds a child of GPIO expander named "foobar-hog" and it is not a
> > GPIO hog, then what is it?
>
> Probably a nitpick.. but then,.. I have'nt seen us depend on hierarchy
> for uniqueness of naming.. we choose for example "bus" no matter where
> in the hierarchy it falls in, as long it is a bus.. etc.. same argument
> holds good for properties as well.. "gpio-hog;" is kinda redundant if
> you think of it for a compatible that is already gpio ;)..
>
> I did'nt mean to de-rail the discussion, but was curious what the DT
> maintainers think..
Not really a fan of gpio-hog binding to have another type of hog nor can
I imagine what that would be.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-15 19:48 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 17:57 [PATCH v2 00/15] ARM: dts: / gpio: Add dtschema for NXP PCA953x and correct dts Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 18:28 ` Nishanth Menon
2020-09-10 18:28 ` Nishanth Menon
2020-09-10 18:28 ` Nishanth Menon
2020-09-10 18:53 ` Krzysztof Kozlowski
2020-09-10 18:53 ` Krzysztof Kozlowski
2020-09-10 18:53 ` Krzysztof Kozlowski
2020-09-10 19:13 ` Nishanth Menon
2020-09-10 19:13 ` Nishanth Menon
2020-09-10 19:13 ` Nishanth Menon
2020-09-15 19:47 ` Rob Herring [this message]
2020-09-15 19:47 ` Rob Herring
2020-09-15 19:47 ` Rob Herring
2020-09-11 6:41 ` Geert Uytterhoeven
2020-09-11 6:41 ` Geert Uytterhoeven
2020-09-11 6:41 ` Geert Uytterhoeven
2020-09-11 6:54 ` Krzysztof Kozlowski
2020-09-11 6:54 ` Krzysztof Kozlowski
2020-09-11 6:54 ` Krzysztof Kozlowski
2020-09-11 6:24 ` Joel Stanley
2020-09-11 6:24 ` Joel Stanley
2020-09-11 6:24 ` Joel Stanley
2020-09-11 6:52 ` Krzysztof Kozlowski
2020-09-11 6:52 ` Krzysztof Kozlowski
2020-09-11 6:52 ` Krzysztof Kozlowski
2020-09-11 9:53 ` Grygorii Strashko
2020-09-11 9:53 ` Grygorii Strashko
2020-09-11 9:53 ` Grygorii Strashko
2020-09-12 10:07 ` Linus Walleij
2020-09-12 10:07 ` Linus Walleij
2020-09-12 10:07 ` Linus Walleij
2020-09-14 9:04 ` Grygorii Strashko
2020-09-14 9:04 ` Grygorii Strashko
2020-09-14 9:04 ` Grygorii Strashko
2020-09-15 19:56 ` Rob Herring
2020-09-15 19:56 ` Rob Herring
2020-09-15 19:56 ` Rob Herring
2020-09-15 19:59 ` Rob Herring
2020-09-15 19:59 ` Rob Herring
2020-09-15 19:59 ` Rob Herring
2020-09-10 17:57 ` [PATCH v2 02/15] dt-bindings: gpio: convert bindings for Maxim MAX732x " Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-12 9:58 ` Linus Walleij
2020-09-12 9:58 ` Linus Walleij
2020-09-12 9:58 ` Linus Walleij
2020-09-16 6:15 ` Krzysztof Kozlowski
2020-09-16 6:15 ` Krzysztof Kozlowski
2020-09-16 6:15 ` Krzysztof Kozlowski
2020-09-16 11:09 ` Krzysztof Kozlowski
2020-09-16 11:09 ` Krzysztof Kozlowski
2020-09-16 11:09 ` Krzysztof Kozlowski
2020-09-15 20:00 ` Rob Herring
2020-09-15 20:00 ` Rob Herring
2020-09-15 20:00 ` Rob Herring
2020-09-10 17:57 ` [PATCH v2 03/15] arm64: dts: mediatek: fix tca6416 reset GPIOs in pumpkin Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-21 9:46 ` Matthias Brugger
2020-09-21 9:46 ` Matthias Brugger
2020-09-21 9:46 ` Matthias Brugger
2020-09-10 17:57 ` [PATCH v2 04/15] arm64: dts: mediatek: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 05/15] arm64: dts: renesas: " Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 06/15] arm64: dts: ti: " Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 07/15] arm64: dts: xilinx: " Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 08/15] ARM: dts: am335x: lxm: fix PCA9539 GPIO expander properties Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 18:01 ` Krzysztof Kozlowski
2020-09-10 18:01 ` Krzysztof Kozlowski
2020-09-10 18:01 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 09/15] ARM: dts: am335x: t335: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 10/15] ARM: dts: am3874: iceboard: fix GPIO expander reset GPIOs Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 11/15] ARM: dts: aspeed: fix PCA95xx GPIO expander properties on Portwell Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-11 0:56 ` Joel Stanley
2020-09-11 0:56 ` Joel Stanley
2020-09-11 0:56 ` Joel Stanley
2020-09-10 17:57 ` [PATCH v2 12/15] ARM: dts: aspeed: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-11 0:58 ` Joel Stanley
2020-09-11 0:58 ` Joel Stanley
2020-09-11 0:58 ` Joel Stanley
2020-09-11 6:10 ` Krzysztof Kozlowski
2020-09-11 6:10 ` Krzysztof Kozlowski
2020-09-11 6:10 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 13/15] ARM: dts: dove: fix PCA95xx GPIO expander properties on A510 Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 14/15] ARM: dts: armada: align GPIO hog names with dtschema Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` [PATCH v2 15/15] ARM: dts: imx6q: " Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
2020-09-10 17:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200915194740.GA2385241@bogus \
--to=robh@kernel.org \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=joel@jms.id.au \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nm@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.