From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: linux-hyperv@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Michael Kelley <mikelley@microsoft.com>,
will@kernel.org, ardb@kernel.org, arnd@arndb.de,
catalin.marinas@arm.com, mark.rutland@arm.com, maz@kernel.org
Subject: Re: [PATCH v4 08/11] Input: hyperv-keyboard: Use VMBUS_RING_SIZE() for ringbuffer sizes
Date: Tue, 15 Sep 2020 21:05:11 -0700 [thread overview]
Message-ID: <20200916040511.GH1681290@dtor-ws> (raw)
In-Reply-To: <20200916034817.30282-9-boqun.feng@gmail.com>
On Wed, Sep 16, 2020 at 11:48:14AM +0800, Boqun Feng wrote:
> For a Hyper-V vmbus, the size of the ringbuffer has two requirements:
>
> 1) it has to take one PAGE_SIZE for the header
>
> 2) it has to be PAGE_SIZE aligned so that double-mapping can work
>
> VMBUS_RING_SIZE() could calculate a correct ringbuffer size which
> fulfills both requirements, therefore use it to make sure vmbus work
> when PAGE_SIZE != HV_HYP_PAGE_SIZE (4K).
>
> Note that since the argument for VMBUS_RING_SIZE() is the size of
> payload (data part), so it will be minus 4k (the size of header when
> PAGE_SIZE = 4k) than the original value to keep the ringbuffer total
> size unchanged when PAGE_SIZE = 4k.
>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Cc: Michael Kelley <mikelley@microsoft.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Please feel free to merge through whatever tree the rest of the patches
will go.
Thanks.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: mark.rutland@arm.com, linux-hyperv@vger.kernel.org,
catalin.marinas@arm.com, Michael Kelley <mikelley@microsoft.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"K. Y. Srinivasan" <kys@microsoft.com>,
will@kernel.org, ardb@kernel.org, Wei Liu <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
linux-scsi@vger.kernel.org, maz@kernel.org,
linux-input@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
arnd@arndb.de, Haiyang Zhang <haiyangz@microsoft.com>,
Jiri Kosina <jikos@kernel.org>,
linux-arm-kernel@lists.infradead.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 08/11] Input: hyperv-keyboard: Use VMBUS_RING_SIZE() for ringbuffer sizes
Date: Tue, 15 Sep 2020 21:05:11 -0700 [thread overview]
Message-ID: <20200916040511.GH1681290@dtor-ws> (raw)
In-Reply-To: <20200916034817.30282-9-boqun.feng@gmail.com>
On Wed, Sep 16, 2020 at 11:48:14AM +0800, Boqun Feng wrote:
> For a Hyper-V vmbus, the size of the ringbuffer has two requirements:
>
> 1) it has to take one PAGE_SIZE for the header
>
> 2) it has to be PAGE_SIZE aligned so that double-mapping can work
>
> VMBUS_RING_SIZE() could calculate a correct ringbuffer size which
> fulfills both requirements, therefore use it to make sure vmbus work
> when PAGE_SIZE != HV_HYP_PAGE_SIZE (4K).
>
> Note that since the argument for VMBUS_RING_SIZE() is the size of
> payload (data part), so it will be minus 4k (the size of header when
> PAGE_SIZE = 4k) than the original value to keep the ringbuffer total
> size unchanged when PAGE_SIZE = 4k.
>
> Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
> Cc: Michael Kelley <mikelley@microsoft.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Please feel free to merge through whatever tree the rest of the patches
will go.
Thanks.
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-16 4:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 3:48 [PATCH v4 00/11] Hyper-V: Support PAGE_SIZE larger than 4K Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 01/11] Drivers: hv: vmbus: Always use HV_HYP_PAGE_SIZE for gpadl Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 02/11] Drivers: hv: vmbus: Move __vmbus_open() Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 03/11] Drivers: hv: vmbus: Introduce types of GPADL Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 04/11] Drivers: hv: Use HV_HYP_PAGE in hv_synic_enable_regs() Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 05/11] Drivers: hv: vmbus: Move virt_to_hvpfn() to hyperv header Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 06/11] hv: hyperv.h: Introduce some hvpfn helper functions Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 07/11] hv_netvsc: Use HV_HYP_PAGE_SIZE for Hyper-V communication Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 3:48 ` [PATCH v4 08/11] Input: hyperv-keyboard: Use VMBUS_RING_SIZE() for ringbuffer sizes Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-16 4:05 ` Dmitry Torokhov [this message]
2020-09-16 4:05 ` Dmitry Torokhov
2020-09-27 0:10 ` Michael Kelley
2020-09-27 0:10 ` Michael Kelley
2020-09-16 3:48 ` [PATCH v4 09/11] HID: hyperv: " Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-27 0:11 ` Michael Kelley
2020-09-27 0:11 ` Michael Kelley
2020-09-16 3:48 ` [PATCH v4 10/11] Driver: hv: util: " Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-27 0:12 ` Michael Kelley
2020-09-27 0:12 ` Michael Kelley
2020-09-16 3:48 ` [PATCH v4 11/11] scsi: storvsc: Support PAGE_SIZE larger than 4K Boqun Feng
2020-09-16 3:48 ` Boqun Feng
2020-09-28 8:59 ` [PATCH v4 00/11] Hyper-V: " Wei Liu
2020-09-28 8:59 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916040511.GH1681290@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.ibm.com \
--cc=jikos@kernel.org \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=maz@kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.