Re: [PATCH RFC 8/8] soc:qcom:qcom_aoss: Change cooling_device_register to warming_device_register

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH RFC 8/8] soc:qcom:qcom_aoss: Change cooling_device_register to warming_device_register
Date: Thu, 17 Sep 2020 15:36:34 +0800	[thread overview]
Message-ID: <202009171510.j8nNDlHr%lkp@intel.com> (raw)
In-Reply-To: <20200917032226.820371-9-thara.gopinath@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 5196 bytes --]

Hi Thara,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v5.9-rc5 next-20200916]
[cannot apply to thermal/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm64-randconfig-r003-20200917 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 1321160a26e7e489baf9b10d6de90a342f898960)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/soc/qcom/qcom_aoss.c:464:19: error: implicit declaration of function 'devm_thermal_of_warming_device_register' [-Werror,-Wimplicit-function-declaration]
           qmp_cdev->cdev = devm_thermal_of_warming_device_register
                            ^
   drivers/soc/qcom/qcom_aoss.c:464:19: note: did you mean 'devm_thermal_of_cooling_device_register'?
   include/linux/thermal.h:432:1: note: 'devm_thermal_of_cooling_device_register' declared here
   devm_thermal_of_cooling_device_register(struct device *dev,
   ^
>> drivers/soc/qcom/qcom_aoss.c:464:17: warning: incompatible integer to pointer conversion assigning to 'struct thermal_cooling_device *' from 'int' [-Wint-conversion]
           qmp_cdev->cdev = devm_thermal_of_warming_device_register
                          ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/soc/qcom/qcom_aoss.c:504:3: error: implicit declaration of function 'thermal_warming_device_unregister' [-Werror,-Wimplicit-function-declaration]
                   thermal_warming_device_unregister
                   ^
   drivers/soc/qcom/qcom_aoss.c:504:3: note: did you mean 'thermal_cooling_device_unregister'?
   include/linux/thermal.h:439:20: note: 'thermal_cooling_device_unregister' declared here
   static inline void thermal_cooling_device_unregister(
                      ^
   drivers/soc/qcom/qcom_aoss.c:515:3: error: implicit declaration of function 'thermal_warming_device_unregister' [-Werror,-Wimplicit-function-declaration]
                   thermal_warming_device_unregister(qmp->cooling_devs[i].cdev);
                   ^
   1 warning and 3 errors generated.

# https://github.com/0day-ci/linux/commit/7c75758cd4b524506f725cb5c62ae90c260f34da
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 7c75758cd4b524506f725cb5c62ae90c260f34da
vim +/devm_thermal_of_warming_device_register +464 drivers/soc/qcom/qcom_aoss.c

   454	
   455	static int qmp_cooling_device_add(struct qmp *qmp,
   456					  struct qmp_cooling_device *qmp_cdev,
   457					  struct device_node *node)
   458	{
   459		char *cdev_name = (char *)node->name;
   460	
   461		qmp_cdev->qmp = qmp;
   462		qmp_cdev->state = !qmp_cdev_max_state;
   463		qmp_cdev->name = cdev_name;
 > 464		qmp_cdev->cdev = devm_thermal_of_warming_device_register
   465					(qmp->dev, node,
   466					cdev_name,
   467					qmp_cdev, &qmp_cooling_device_ops);
   468	
   469		if (IS_ERR(qmp_cdev->cdev))
   470			dev_err(qmp->dev, "unable to register %s cooling device\n",
   471				cdev_name);
   472	
   473		return PTR_ERR_OR_ZERO(qmp_cdev->cdev);
   474	}
   475	
   476	static int qmp_cooling_devices_register(struct qmp *qmp)
   477	{
   478		struct device_node *np, *child;
   479		int count = QMP_NUM_COOLING_RESOURCES;
   480		int ret;
   481	
   482		np = qmp->dev->of_node;
   483	
   484		qmp->cooling_devs = devm_kcalloc(qmp->dev, count,
   485						 sizeof(*qmp->cooling_devs),
   486						 GFP_KERNEL);
   487	
   488		if (!qmp->cooling_devs)
   489			return -ENOMEM;
   490	
   491		for_each_available_child_of_node(np, child) {
   492			if (!of_find_property(child, "#cooling-cells", NULL))
   493				continue;
   494			ret = qmp_cooling_device_add(qmp, &qmp->cooling_devs[count++],
   495						     child);
   496			if (ret)
   497				goto unroll;
   498		}
   499	
   500		return 0;
   501	
   502	unroll:
   503		while (--count >= 0)
 > 504			thermal_warming_device_unregister
   505				(qmp->cooling_devs[count].cdev);
   506	
   507		return ret;
   508	}
   509	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34800 bytes --]