From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature
Date: Thu, 17 Sep 2020 15:08:01 +0300 [thread overview]
Message-ID: <20200917120801.GQ4282@kadam> (raw)
In-Reply-To: <20200917032226.820371-5-thara.gopinath@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 6456 bytes --]
Hi Thara,
url: https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-m001-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/thermal/thermal_core.c:436 handle_thermal_trip() error: uninitialized symbol 'mon_type'.
# https://github.com/0day-ci/linux/commit/602ffc327f610db12c9657821c144d359c9d1f7f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 602ffc327f610db12c9657821c144d359c9d1f7f
vim +/mon_type +436 drivers/thermal/thermal_core.c
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 417 static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 418 {
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 419 enum thermal_trip_type type;
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 420 enum thermal_trip_monitor_type mon_type;
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 421 int trip_temp, hyst = 0;
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 422
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 423 /* Ignore disabled trip points */
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 424 if (test_bit(trip, &tz->trips_disabled))
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 425 return;
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 426
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 427 tz->ops->get_trip_temp(tz, trip, &trip_temp);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 428 tz->ops->get_trip_type(tz, trip, &type);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 429 if (tz->ops->get_trip_hyst)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 430 tz->ops->get_trip_hyst(tz, trip, &hyst);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 431
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 432 if (tz->ops->get_trip_mon_type)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 433 tz->ops->get_trip_mon_type(tz, trip, &mon_type);
^^^^^^^^^
Unintialized on else path
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 434
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 435 if (tz->last_temperature != THERMAL_TEMP_INVALID) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 @436 if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
^^^^^^^^
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 437 if (tz->last_temperature > trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 438 tz->temperature <= trip_temp)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 439 thermal_notify_tz_trip_down(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 440 if (tz->last_temperature <= trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 441 tz->temperature > (trip_temp + hyst))
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 442 thermal_notify_tz_trip_up(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 443 } else {
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 444 if (tz->last_temperature < trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 445 tz->temperature >= trip_temp)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 446 thermal_notify_tz_trip_up(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 447 if (tz->last_temperature >= trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 448 tz->temperature < (trip_temp - hyst))
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 449 thermal_notify_tz_trip_down(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 450 }
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 451 }
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 452
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 453 if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 454 handle_critical_trips(tz, trip, type);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 455 else
5be52fccaf3d218 drivers/thermal/thermal_core.c Lukasz Luba 2018-10-15 456 handle_non_critical_trips(tz, trip);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 457 /*
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 458 * Alright, we handled this trip successfully.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 459 * So, start monitoring again.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 460 */
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 461 monitor_thermal_zone(tz);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 462 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30048 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature
Date: Thu, 17 Sep 2020 15:08:01 +0300 [thread overview]
Message-ID: <20200917120801.GQ4282@kadam> (raw)
In-Reply-To: <20200917032226.820371-5-thara.gopinath@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 6456 bytes --]
Hi Thara,
url: https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: x86_64-randconfig-m001-20200917 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/thermal/thermal_core.c:436 handle_thermal_trip() error: uninitialized symbol 'mon_type'.
# https://github.com/0day-ci/linux/commit/602ffc327f610db12c9657821c144d359c9d1f7f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Thara-Gopinath/Introduce-warming-in-thermal-framework/20200917-113050
git checkout 602ffc327f610db12c9657821c144d359c9d1f7f
vim +/mon_type +436 drivers/thermal/thermal_core.c
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 417 static void handle_thermal_trip(struct thermal_zone_device *tz, int trip)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 418 {
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 419 enum thermal_trip_type type;
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 420 enum thermal_trip_monitor_type mon_type;
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 421 int trip_temp, hyst = 0;
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 422
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 423 /* Ignore disabled trip points */
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 424 if (test_bit(trip, &tz->trips_disabled))
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 425 return;
81ad4276b505e98 drivers/thermal/thermal_core.c Zhang Rui 2016-03-18 426
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 427 tz->ops->get_trip_temp(tz, trip, &trip_temp);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 428 tz->ops->get_trip_type(tz, trip, &type);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 429 if (tz->ops->get_trip_hyst)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 430 tz->ops->get_trip_hyst(tz, trip, &hyst);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 431
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 432 if (tz->ops->get_trip_mon_type)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 433 tz->ops->get_trip_mon_type(tz, trip, &mon_type);
^^^^^^^^^
Unintialized on else path
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 434
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 435 if (tz->last_temperature != THERMAL_TEMP_INVALID) {
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 @436 if (mon_type == THERMAL_TRIP_MONITOR_FALLING) {
^^^^^^^^
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 437 if (tz->last_temperature > trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 438 tz->temperature <= trip_temp)
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 439 thermal_notify_tz_trip_down(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 440 if (tz->last_temperature <= trip_temp &&
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 441 tz->temperature > (trip_temp + hyst))
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 442 thermal_notify_tz_trip_up(tz->id, trip);
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 443 } else {
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 444 if (tz->last_temperature < trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 445 tz->temperature >= trip_temp)
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 446 thermal_notify_tz_trip_up(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 447 if (tz->last_temperature >= trip_temp &&
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 448 tz->temperature < (trip_temp - hyst))
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 449 thermal_notify_tz_trip_down(tz->id, trip);
55cdf0a283b8760 drivers/thermal/thermal_core.c Daniel Lezcano 2020-07-06 450 }
602ffc327f610db drivers/thermal/thermal_core.c Thara Gopinath 2020-09-16 451 }
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 452
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 453 if (type == THERMAL_TRIP_CRITICAL || type == THERMAL_TRIP_HOT)
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 454 handle_critical_trips(tz, trip, type);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 455 else
5be52fccaf3d218 drivers/thermal/thermal_core.c Lukasz Luba 2018-10-15 456 handle_non_critical_trips(tz, trip);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 457 /*
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 458 * Alright, we handled this trip successfully.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 459 * So, start monitoring again.
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 460 */
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 461 monitor_thermal_zone(tz);
0c01ebbfd3caf1d drivers/thermal/thermal_sys.c Durgadoss R 2012-09-18 462 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30048 bytes --]
next prev parent reply other threads:[~2020-09-17 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 3:22 [PATCH RFC 0/8] Introduce warming in thermal framework Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 1/8] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding Thara Gopinath
2020-09-23 16:03 ` Rob Herring
2020-09-28 11:21 ` Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 2/8] thermal: Introduce new property monitor_type for trip point Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 3/8] thermal: thermal_of: Extend thermal dt driver to support bi-directional monitoring of a thermal " Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature Thara Gopinath
2020-09-17 12:08 ` Dan Carpenter [this message]
2020-09-17 12:08 ` Dan Carpenter
2020-09-17 3:22 ` [PATCH RFC 5/8] thermal: gov_step_wise: Extend thermal step-wise governor to monitor " Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 6/8] thermal: Modify thermal governors to do nothing for trip points being monitored for " Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 7/8] thermal:core: Add is_warming_dev and supporting warming device api's to the cooling dev framework Thara Gopinath
2020-09-17 3:22 ` [PATCH RFC 8/8] soc:qcom:qcom_aoss: Change cooling_device_register to warming_device_register Thara Gopinath
2020-09-17 7:36 ` kernel test robot
2020-10-19 18:42 ` [PATCH RFC 0/8] Introduce warming in thermal framework Thara Gopinath
2020-10-19 19:22 ` Daniel Lezcano
2020-09-17 11:19 [PATCH RFC 4/8] thermal:core:Add genetlink notifications for monitoring falling temperature kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200917120801.GQ4282@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.