From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Song Liu <song@kernel.org>,
Hans de Goede <hdegoede@redhat.com>, Coly Li <colyli@suse.de>,
Richard Weinberger <richard@nod.at>,
Minchan Kim <minchan@kernel.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Justin Sanders <justin@coraid.com>,
linux-mtd@lists.infradead.org, dm-devel@redhat.com,
linux-block@vger.kernel.org, linux-bcache@vger.kernel.org,
linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com,
linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, cgroups@vger.kernel.org
Subject: Re: [PATCH 04/13] aoe: set an optimal I/O size
Date: Tue, 22 Sep 2020 10:45:17 +0200 [thread overview]
Message-ID: <20200922084517.GB16464@quack2.suse.cz> (raw)
In-Reply-To: <20200921080734.452759-5-hch@lst.de>
On Mon 21-09-20 10:07:25, Christoph Hellwig wrote:
> aoe forces a larger readahead size, but any reason to do larger I/O
> is not limited to readahead. Also set the optimal I/O size, and
> remove the local constants in favor of just using SZ_2G.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> drivers/block/aoe/aoeblk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> index 5ca7216e9e01f3..d8cfc233e64b93 100644
> --- a/drivers/block/aoe/aoeblk.c
> +++ b/drivers/block/aoe/aoeblk.c
> @@ -347,7 +347,6 @@ aoeblk_gdalloc(void *vp)
> mempool_t *mp;
> struct request_queue *q;
> struct blk_mq_tag_set *set;
> - enum { KB = 1024, MB = KB * KB, READ_AHEAD = 2 * MB, };
> ulong flags;
> int late = 0;
> int err;
> @@ -407,7 +406,8 @@ aoeblk_gdalloc(void *vp)
> WARN_ON(d->gd);
> WARN_ON(d->flags & DEVFL_UP);
> blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS);
> - q->backing_dev_info->ra_pages = READ_AHEAD / PAGE_SIZE;
> + q->backing_dev_info->ra_pages = SZ_2M / PAGE_SIZE;
> + blk_queue_io_opt(q, SZ_2M);
> d->bufpool = mp;
> d->blkq = gd->queue = q;
> q->queuedata = d;
> --
> 2.28.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-raid@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Justin Sanders <justin@coraid.com>,
Minchan Kim <minchan@kernel.org>,
Richard Weinberger <richard@nod.at>,
linux-bcache@vger.kernel.org, Coly Li <colyli@suse.de>,
linux-block@vger.kernel.org, Song Liu <song@kernel.org>,
dm-devel@redhat.com, linux-mtd@lists.infradead.org,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
drbd-dev@lists.linbit.com
Subject: Re: [PATCH 04/13] aoe: set an optimal I/O size
Date: Tue, 22 Sep 2020 10:45:17 +0200 [thread overview]
Message-ID: <20200922084517.GB16464@quack2.suse.cz> (raw)
In-Reply-To: <20200921080734.452759-5-hch@lst.de>
On Mon 21-09-20 10:07:25, Christoph Hellwig wrote:
> aoe forces a larger readahead size, but any reason to do larger I/O
> is not limited to readahead. Also set the optimal I/O size, and
> remove the local constants in favor of just using SZ_2G.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> drivers/block/aoe/aoeblk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> index 5ca7216e9e01f3..d8cfc233e64b93 100644
> --- a/drivers/block/aoe/aoeblk.c
> +++ b/drivers/block/aoe/aoeblk.c
> @@ -347,7 +347,6 @@ aoeblk_gdalloc(void *vp)
> mempool_t *mp;
> struct request_queue *q;
> struct blk_mq_tag_set *set;
> - enum { KB = 1024, MB = KB * KB, READ_AHEAD = 2 * MB, };
> ulong flags;
> int late = 0;
> int err;
> @@ -407,7 +406,8 @@ aoeblk_gdalloc(void *vp)
> WARN_ON(d->gd);
> WARN_ON(d->flags & DEVFL_UP);
> blk_queue_max_hw_sectors(q, BLK_DEF_MAX_SECTORS);
> - q->backing_dev_info->ra_pages = READ_AHEAD / PAGE_SIZE;
> + q->backing_dev_info->ra_pages = SZ_2M / PAGE_SIZE;
> + blk_queue_io_opt(q, SZ_2M);
> d->bufpool = mp;
> d->blkq = gd->queue = q;
> q->queuedata = d;
> --
> 2.28.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-09-22 8:45 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-21 8:07 bdi cleanups v6 Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 01/13] fs: remove the unused SB_I_MULTIROOT flag Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 02/13] drbd: remove dead code in device_to_statistics Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 03/13] bcache: inherit the optimal I/O size Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 9:54 ` Coly Li
2020-09-21 9:54 ` Coly Li
2020-09-21 14:00 ` Christoph Hellwig
2020-09-21 14:00 ` Christoph Hellwig
2020-09-21 14:00 ` Christoph Hellwig
2020-09-21 15:09 ` Coly Li
2020-09-21 15:09 ` Coly Li
2020-09-21 18:18 ` Christoph Hellwig
2020-09-21 18:18 ` Christoph Hellwig
2020-09-22 8:44 ` Jan Kara
2020-09-22 8:44 ` Jan Kara
2020-09-22 8:44 ` Jan Kara
2020-09-22 9:39 ` Coly Li
2020-09-22 9:39 ` Coly Li
2020-09-21 8:07 ` [PATCH 04/13] aoe: set an " Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-22 8:45 ` Jan Kara [this message]
2020-09-22 8:45 ` Jan Kara
2020-09-21 8:07 ` [PATCH 05/13] bdi: initialize ->ra_pages and ->io_pages in bdi_init Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-22 8:49 ` Jan Kara
2020-09-22 8:49 ` Jan Kara
2020-09-22 8:49 ` Jan Kara
2020-09-23 15:16 ` Christoph Hellwig
2020-09-23 15:16 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 06/13] md: update the optimal I/O size on reshape Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 07/13] block: lift setting the readahead size into the block layer Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-22 9:13 ` Jan Kara
2020-09-22 9:13 ` Jan Kara
2020-09-22 9:51 ` Coly Li
2020-09-22 9:51 ` Coly Li
2020-09-21 8:07 ` [PATCH 08/13] bdi: remove BDI_CAP_CGROUP_WRITEBACK Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 09/13] bdi: remove BDI_CAP_SYNCHRONOUS_IO Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 10/13] mm: use SWP_SYNCHRONOUS_IO more intelligently Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 11/13] bdi: replace BDI_CAP_STABLE_WRITES with a queue and a sb flag Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 12/13] bdi: invert BDI_CAP_NO_ACCT_WB Christoph Hellwig
2020-09-21 8:07 ` Christoph Hellwig
2020-09-21 8:07 ` [PATCH 13/13] bdi: replace BDI_CAP_NO_{WRITEBACK,ACCT_DIRTY} with a single flag Christoph Hellwig
2020-09-21 8:07 ` [PATCH 13/13] bdi: replace BDI_CAP_NO_{WRITEBACK, ACCT_DIRTY} " Christoph Hellwig
2020-09-24 6:51 bdi cleanups v7 Christoph Hellwig
2020-09-24 6:51 ` [PATCH 04/13] aoe: set an optimal I/O size Christoph Hellwig
2020-09-24 6:51 ` Christoph Hellwig
2020-09-24 15:51 ` Martin K. Petersen
2020-09-24 15:51 ` Martin K. Petersen
2020-09-24 15:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200922084517.GB16464@quack2.suse.cz \
--to=jack@suse.cz \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=justin@coraid.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=richard@nod.at \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.