All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: <t-kristo@ti.com>, <ssantosh@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, Lokesh Vutla <lokeshvutla@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>
Subject: Re: [PATCH -next] firmware: ti_sci: Remove unneeded semicolon
Date: Tue, 22 Sep 2020 06:46:49 -0500	[thread overview]
Message-ID: <20200922114649.g3lpmdx2gcbgj7u4@akan> (raw)
In-Reply-To: <1600772344-79841-1-git-send-email-zou_wei@huawei.com>

On 18:59-20200922, Zou Wei wrote:
> Fixes coccicheck warning:
> 
> ./drivers/firmware/ti_sci.c:1759:2-3: Unneeded semicolon
> ./drivers/firmware/ti_sci.c:2191:2-3: Unneeded semicolon
> 
> Fixes: 9c19fb6895be ("firmware: ti_sci: Add support for RM core ops")
> Fixes: 68608b5e5063 ("firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma")
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/firmware/ti_sci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 896f53e..e0c8adf 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1756,7 +1756,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
>  	} else {
>  		*range_start = resp->range_start;
>  		*range_num = resp->range_num;
> -	};
> +	}
>  
>  fail:
>  	ti_sci_put_one_xfer(&info->minfo, xfer);
> @@ -2188,7 +2188,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
>  			*size = resp->size;
>  		if (order_id)
>  			*order_id = resp->order_id;
> -	};
> +	}
>  
>  fail:
>  	ti_sci_put_one_xfer(&info->minfo, xfer);

Thanks.
Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Zou Wei <zou_wei@huawei.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	Lokesh Vutla <lokeshvutla@ti.com>,
	linux-kernel@vger.kernel.org, t-kristo@ti.com,
	ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] firmware: ti_sci: Remove unneeded semicolon
Date: Tue, 22 Sep 2020 06:46:49 -0500	[thread overview]
Message-ID: <20200922114649.g3lpmdx2gcbgj7u4@akan> (raw)
In-Reply-To: <1600772344-79841-1-git-send-email-zou_wei@huawei.com>

On 18:59-20200922, Zou Wei wrote:
> Fixes coccicheck warning:
> 
> ./drivers/firmware/ti_sci.c:1759:2-3: Unneeded semicolon
> ./drivers/firmware/ti_sci.c:2191:2-3: Unneeded semicolon
> 
> Fixes: 9c19fb6895be ("firmware: ti_sci: Add support for RM core ops")
> Fixes: 68608b5e5063 ("firmware: ti_sci: Add resource management APIs for ringacc, psi-l and udma")
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/firmware/ti_sci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 896f53e..e0c8adf 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1756,7 +1756,7 @@ static int ti_sci_get_resource_range(const struct ti_sci_handle *handle,
>  	} else {
>  		*range_start = resp->range_start;
>  		*range_num = resp->range_num;
> -	};
> +	}
>  
>  fail:
>  	ti_sci_put_one_xfer(&info->minfo, xfer);
> @@ -2188,7 +2188,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle,
>  			*size = resp->size;
>  		if (order_id)
>  			*order_id = resp->order_id;
> -	};
> +	}
>  
>  fail:
>  	ti_sci_put_one_xfer(&info->minfo, xfer);

Thanks.
Reviewed-by: Nishanth Menon <nm@ti.com>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-22 11:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22 10:59 [PATCH -next] firmware: ti_sci: Remove unneeded semicolon Zou Wei
2020-09-22 10:59 ` Zou Wei
2020-09-22 11:46 ` Nishanth Menon [this message]
2020-09-22 11:46   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200922114649.g3lpmdx2gcbgj7u4@akan \
    --to=nm@ti.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=ssantosh@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=zou_wei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.