From: Marco Felsch <m.felsch@pengutronix.de> To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com, michal.vokac@ysoft.com, l.majewski@majess.pl Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 0/5] PWM i.MX27 fix disabled state for inverted signals Date: Fri, 25 Sep 2020 17:53:25 +0200 [thread overview] Message-ID: <20200925155330.32301-1-m.felsch@pengutronix.de> (raw) Hi, this small series fixes the pwm disabled behaviour in case of an inverted pwm signal. The current state is that in such a case the pwm signal goes to 0V which means logical '1' for inverted pwm signals. IMO this is wrong and should be fixed. I've tested my patches on a custom imx6 board which uses the pwm as backlight. Each patch has a dedicated changelog so I skip it here. Comments and testers are welcome :) Regards, Marco Marco Felsch (5): pwm: imx27: enable clock unconditional for register access pwm: imx27: move constant PWMCR register values into probe pwm: imx27: reset the PWM if it is not running pwm: imx27: fix disable state for inverted PWMs pwm: imx27: wait till the duty cycle is applied drivers/pwm/pwm-imx27.c | 166 +++++++++++++++++++++++++++++----------- 1 file changed, 120 insertions(+), 46 deletions(-) -- 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de> To: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, lee.jones@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, Anson.Huang@nxp.com, michal.vokac@ysoft.com, l.majewski@majess.pl Cc: linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH v2 0/5] PWM i.MX27 fix disabled state for inverted signals Date: Fri, 25 Sep 2020 17:53:25 +0200 [thread overview] Message-ID: <20200925155330.32301-1-m.felsch@pengutronix.de> (raw) Hi, this small series fixes the pwm disabled behaviour in case of an inverted pwm signal. The current state is that in such a case the pwm signal goes to 0V which means logical '1' for inverted pwm signals. IMO this is wrong and should be fixed. I've tested my patches on a custom imx6 board which uses the pwm as backlight. Each patch has a dedicated changelog so I skip it here. Comments and testers are welcome :) Regards, Marco Marco Felsch (5): pwm: imx27: enable clock unconditional for register access pwm: imx27: move constant PWMCR register values into probe pwm: imx27: reset the PWM if it is not running pwm: imx27: fix disable state for inverted PWMs pwm: imx27: wait till the duty cycle is applied drivers/pwm/pwm-imx27.c | 166 +++++++++++++++++++++++++++++----------- 1 file changed, 120 insertions(+), 46 deletions(-) -- 2.20.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-09-25 15:53 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-25 15:53 Marco Felsch [this message] 2020-09-25 15:53 ` [PATCH v2 0/5] PWM i.MX27 fix disabled state for inverted signals Marco Felsch 2020-09-25 15:53 ` [PATCH v2 1/5] pwm: imx27: enable clock unconditional for register access Marco Felsch 2020-09-25 15:53 ` Marco Felsch 2020-09-26 13:28 ` Uwe Kleine-König 2020-09-26 13:28 ` Uwe Kleine-König 2020-09-26 13:48 ` Uwe Kleine-König 2020-09-26 13:48 ` Uwe Kleine-König 2020-09-28 5:52 ` Marco Felsch 2020-09-28 5:52 ` Marco Felsch 2020-09-25 15:53 ` [PATCH v2 2/5] pwm: imx27: move constant PWMCR register values into probe Marco Felsch 2020-09-25 15:53 ` Marco Felsch 2020-09-26 13:46 ` Uwe Kleine-König 2020-09-26 13:46 ` Uwe Kleine-König 2020-09-28 5:50 ` Marco Felsch 2020-09-28 5:50 ` Marco Felsch 2020-09-25 15:53 ` [PATCH v2 3/5] pwm: imx27: reset the PWM if it is not running Marco Felsch 2020-09-25 15:53 ` Marco Felsch 2020-09-28 7:30 ` Uwe Kleine-König 2020-09-28 7:30 ` Uwe Kleine-König 2020-09-28 9:29 ` Marco Felsch 2020-09-28 9:29 ` Marco Felsch 2020-09-25 15:53 ` [PATCH v2 4/5] pwm: imx27: fix disable state for inverted PWMs Marco Felsch 2020-09-25 15:53 ` Marco Felsch 2020-09-28 7:47 ` Uwe Kleine-König 2020-09-28 7:47 ` Uwe Kleine-König 2020-09-28 9:52 ` Marco Felsch 2020-09-28 9:52 ` Marco Felsch 2020-09-28 19:06 ` Uwe Kleine-König 2020-09-28 19:06 ` Uwe Kleine-König 2020-09-29 5:23 ` Marco Felsch 2020-09-29 5:23 ` Marco Felsch 2020-09-25 15:53 ` [PATCH v2 5/5] pwm: imx27: wait till the duty cycle is applied Marco Felsch 2020-09-25 15:53 ` Marco Felsch 2020-09-28 8:04 ` Uwe Kleine-König 2020-09-28 8:04 ` Uwe Kleine-König 2020-09-28 9:59 ` Marco Felsch 2020-09-28 9:59 ` Marco Felsch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200925155330.32301-1-m.felsch@pengutronix.de \ --to=m.felsch@pengutronix.de \ --cc=Anson.Huang@nxp.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.majewski@majess.pl \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-pwm@vger.kernel.org \ --cc=michal.vokac@ysoft.com \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.