All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
Date: Sat, 26 Sep 2020 15:22:17 +0200	[thread overview]
Message-ID: <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> (raw)
In-Reply-To: <20200925212609.23093-1-krzk@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]

On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> warnings like:
> 
>   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
>     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> index 473863eb67e5..379d693889f6 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> @@ -25,6 +25,17 @@ properties:
>            - fsl,imx27-pwm
>        - items:
>            - enum:
> +              - fsl,imx25-pwm

The driver actually used fsl,imx27-pwm to bind ...

Also since v5.1-rc1~38^2~17 the driver is split into pwm-imx27 and
pwm-imx1. So maybe this file should be renamed to fsl,imx27-pwm.yaml?
(And we need a volunteer to write fsl,imx1-pwm.yaml.)

> +              - fsl,imx31-pwm
> +              - fsl,imx50-pwm
> +              - fsl,imx51-pwm
> +              - fsl,imx53-pwm
> +              - fsl,imx6q-pwm
> +              - fsl,imx6sl-pwm
> +              - fsl,imx6sll-pwm
> +              - fsl,imx6sx-pwm
> +              - fsl,imx6ul-pwm
> +              - fsl,imx7d-pwm
>                - fsl,imx8mm-pwm
>                - fsl,imx8mn-pwm
>                - fsl,imx8mp-pwm

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-pwm@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	devicetree@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: pwm: imx: document i.MX compatibles
Date: Sat, 26 Sep 2020 15:22:17 +0200	[thread overview]
Message-ID: <20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de> (raw)
In-Reply-To: <20200925212609.23093-1-krzk@kernel.org>


[-- Attachment #1.1: Type: text/plain, Size: 1842 bytes --]

On Fri, Sep 25, 2020 at 11:26:09PM +0200, Krzysztof Kozlowski wrote:
> Document all ARMv5, ARMv6 and ARMv7 i.MX compatibles to fix dtbs_check
> warnings like:
> 
>   arch/arm/boot/dts/imx6dl-colibri-eval-v3.dt.yaml: pwm@2080000: compatible:0:
>     'fsl,imx6q-pwm' is not one of ['fsl,imx8mm-pwm', 'fsl,imx8mn-pwm', 'fsl,imx8mp-pwm', 'fsl,imx8mq-pwm']
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  Documentation/devicetree/bindings/pwm/imx-pwm.yaml | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> index 473863eb67e5..379d693889f6 100644
> --- a/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/imx-pwm.yaml
> @@ -25,6 +25,17 @@ properties:
>            - fsl,imx27-pwm
>        - items:
>            - enum:
> +              - fsl,imx25-pwm

The driver actually used fsl,imx27-pwm to bind ...

Also since v5.1-rc1~38^2~17 the driver is split into pwm-imx27 and
pwm-imx1. So maybe this file should be renamed to fsl,imx27-pwm.yaml?
(And we need a volunteer to write fsl,imx1-pwm.yaml.)

> +              - fsl,imx31-pwm
> +              - fsl,imx50-pwm
> +              - fsl,imx51-pwm
> +              - fsl,imx53-pwm
> +              - fsl,imx6q-pwm
> +              - fsl,imx6sl-pwm
> +              - fsl,imx6sll-pwm
> +              - fsl,imx6sx-pwm
> +              - fsl,imx6ul-pwm
> +              - fsl,imx7d-pwm
>                - fsl,imx8mm-pwm
>                - fsl,imx8mn-pwm
>                - fsl,imx8mp-pwm

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-26 13:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-25 21:26 [PATCH] dt-bindings: pwm: imx: document i.MX compatibles Krzysztof Kozlowski
2020-09-25 21:26 ` Krzysztof Kozlowski
2020-09-26 13:22 ` Uwe Kleine-König [this message]
2020-09-26 13:22   ` Uwe Kleine-König
2020-09-26 13:41   ` Krzysztof Kozlowski
2020-09-26 13:41     ` Krzysztof Kozlowski
2020-10-09 12:02     ` Thierry Reding
2020-10-09 12:02       ` Thierry Reding
2020-10-12 17:16       ` Krzysztof Kozlowski
2020-10-12 17:16         ` Krzysztof Kozlowski
2020-10-12 18:14       ` Rob Herring
2020-10-12 18:14         ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200926132217.xr3rhv7o2o2yc2l7@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.