Re: [patch 01/35] net: enic: Cure the enic api locking trainwreck

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [patch 01/35] net: enic: Cure the enic api locking trainwreck
Date: Mon, 28 Sep 2020 06:06:23 +0800	[thread overview]
Message-ID: <202009280505.DLoMnKdf%lkp@intel.com> (raw)
In-Reply-To: <20200927194919.806110712@linutronix.de>

[-- Attachment #1: Type: text/plain, Size: 3272 bytes --]

Hi Thomas,

I love your patch! Yet something to improve:

[auto build test ERROR on wireless-drivers/master]
[also build test ERROR on jkirsher-next-queue/dev-queue linus/master v5.9-rc6 next-20200925]
[cannot apply to wireless-drivers-next/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Gleixner/net-in_interrupt-cleanup-and-fixes/20200928-040350
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/0faff202c0039d8da1baed3af43b0c1b4c67e36e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Thomas-Gleixner/net-in_interrupt-cleanup-and-fixes/20200928-040350
        git checkout 0faff202c0039d8da1baed3af43b0c1b4c67e36e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/cisco/enic/enic_main.c: In function 'enic_reset':
>> drivers/net/ethernet/cisco/enic/enic_main.c:2313:2: error: implicit declaration of function 'enic_set_api_state'; did you mean 'enic_set_api_busy'? [-Werror=implicit-function-declaration]
    2313 |  enic_set_api_state(enic, true);
         |  ^~~~~~~~~~~~~~~~~~
         |  enic_set_api_busy
   At top level:
   drivers/net/ethernet/cisco/enic/enic_main.c:2296:13: warning: 'enic_set_api_busy' defined but not used [-Wunused-function]
    2296 | static void enic_set_api_busy(struct enic *enic, bool busy)
         |             ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +2313 drivers/net/ethernet/cisco/enic/enic_main.c

  2302	
  2303	static void enic_reset(struct work_struct *work)
  2304	{
  2305		struct enic *enic = container_of(work, struct enic, reset);
  2306	
  2307		if (!netif_running(enic->netdev))
  2308			return;
  2309	
  2310		rtnl_lock();
  2311	
  2312		/* Stop any activity from infiniband */
> 2313		enic_set_api_state(enic, true);
  2314	
  2315		enic_stop(enic->netdev);
  2316		enic_dev_soft_reset(enic);
  2317		enic_reset_addr_lists(enic);
  2318		enic_init_vnic_resources(enic);
  2319		enic_set_rss_nic_cfg(enic);
  2320		enic_dev_set_ig_vlan_rewrite_mode(enic);
  2321		enic_open(enic->netdev);
  2322	
  2323		/* Allow infiniband to fiddle with the device again */
  2324		enic_set_api_state(enic, false);
  2325	
  2326		call_netdevice_notifiers(NETDEV_REBOOT, enic->netdev);
  2327	
  2328		rtnl_unlock();
  2329	}
  2330	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 61580 bytes --]