From: Thomas Gleixner <tglx@linutronix.de>
To: Edward Cree <ecree@solarflare.com>, linux-net-drivers@solarflare.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC PATCH net-next] sfc: replace in_interrupt() usage
Date: Mon, 28 Sep 2020 22:24:57 +0200 [thread overview]
Message-ID: <87k0wdk5t2.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <e45d9556-2759-6f33-01a0-d1739ce5760d@solarflare.com>
On Mon, Sep 28 2020 at 21:05, Edward Cree wrote:
> efx_ef10_try_update_nic_stats_vf() used in_interrupt() to figure out
> whether it is safe to sleep (for MCDI) or not.
> The only caller from which it was not is efx_net_stats(), which can be
> invoked under dev_base_lock from net-sysfs::netstat_show().
> So add a new update_stats_atomic() method to struct efx_nic_type, and
> call it from efx_net_stats(), removing the need for
> efx_ef10_try_update_nic_stats_vf() to behave differently for this case
> (which it wasn't doing correctly anyway).
> For all nic_types other than EF10 VF, this method is NULL and so we
> call the regular update_stats() methods, which are happy with being
> called from atomic contexts.
>
> Fixes: f00bf2305cab ("sfc: don't update stats on VF when called in atomic context")
> Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Edward Cree <ecree@solarflare.com>
That's much nicer.
> ---
> Only compile-tested so far, because I'm waiting for my kernel to
> finish rebuilding with CONFIG_DEBUG_ATOMIC_SLEEP which I'm hoping
> is the right thing to detect the bug in the existing code.
> I also wasn't quite sure how to give credit to the thorough analysis
> in the commit message of Sebastian's patch. I don't think we have
> a Whatever-by: tag to cover that, do we?
Sebastian did the analysis and I did some word polishing, but the credit
surely goes to him.
Thanks,
tglx
next prev parent reply other threads:[~2020-09-28 20:25 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 19:48 [patch 00/35] net: in_interrupt() cleanup and fixes Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 01/35] net: enic: Cure the enic api locking trainwreck Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 22:06 ` kernel test robot
2020-09-27 19:48 ` [patch 02/35] net: caif: Remove unused caif SPI driver Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 03/35] net: Add netif_rx_any_context() Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 04/35] net: caif: Use netif_rx_any_context() Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 05/35] net: atheros: Remove WARN_ON(in_interrupt()) Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 06/35] net: cxgb3: Cleanup in_interrupt() usage Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 07/35] net: cxbg4: Remove pointless in_interrupt() check Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 08/35] net: e100: Remove in_interrupt() usage and pointless GFP_ATOMIC allocation Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 09/35] net: fec_mpc52xx: Replace in_interrupt() usage Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 10/35] net: intel: Remove in_interrupt() warnings Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 23:04 ` Alexander Duyck
2020-09-28 23:04 ` [Intel-wired-lan] " Alexander Duyck
2020-09-27 19:48 ` [patch 11/35] net: ionic: Replace in_interrupt() usage Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 17:24 ` Shannon Nelson
2020-09-28 17:24 ` [Intel-wired-lan] " Shannon Nelson
2020-09-28 19:51 ` Shannon Nelson
2020-09-28 19:51 ` [Intel-wired-lan] " Shannon Nelson
2020-09-29 14:37 ` Thomas Gleixner
2020-09-29 14:37 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:48 ` [patch 12/35] net: ionic: Remove WARN_ON(in_interrupt()) Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 17:26 ` Shannon Nelson
2020-09-28 17:26 ` [Intel-wired-lan] " Shannon Nelson
2020-09-27 19:48 ` [patch 13/35] net: mdiobus: Remove WARN_ON_ONCE(in_interrupt()) Thomas Gleixner
2020-09-27 19:48 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 23:00 ` Andrew Lunn
2020-09-27 23:00 ` [Intel-wired-lan] " Andrew Lunn
2020-09-27 19:49 ` [patch 14/35] net: natsemi: Replace in_interrupt() usage Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 15/35] net: sfc: " Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 19:03 ` Edward Cree
2020-09-28 19:03 ` [Intel-wired-lan] " Edward Cree
2020-09-28 20:05 ` [RFC PATCH net-next] sfc: replace " Edward Cree
2020-09-28 20:24 ` Thomas Gleixner [this message]
2020-09-29 15:15 ` Edward Cree
2020-09-29 19:27 ` Thomas Gleixner
2020-09-29 9:39 ` Martin Habets
2020-09-27 19:49 ` [patch 16/35] net: sunbmac: Replace " Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 17/35] net: sun3lance: Remove redundant checks in interrupt handler Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 18/35] net: vxge: Remove in_interrupt() conditionals Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 19/35] net: zd1211rw: Remove ZD_ASSERT(in_interrupt()) Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 20/35] net: usb: kaweth: Replace kaweth_control() with usb_control_msg() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 21/35] net: usb: kaweth: Remove last user of kaweth_control() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 6:50 ` Greg Kroah-Hartman
2020-09-28 6:50 ` [Intel-wired-lan] " Greg Kroah-Hartman
2020-09-27 19:49 ` [patch 22/35] net: usb: net1080: Remove in_interrupt() comment Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 23/35] net: wan/lmc: Remove lmc_trace() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 24/35] net: brcmfmac: Replace in_interrupt() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 7:35 ` Arend Van Spriel
2020-09-28 7:35 ` [Intel-wired-lan] " Arend Van Spriel
2020-09-28 9:19 ` Ulf Hansson
2020-09-28 9:19 ` [Intel-wired-lan] " Ulf Hansson
2020-09-28 9:37 ` Arend Van Spriel
2020-09-28 9:37 ` [Intel-wired-lan] " Arend Van Spriel
2020-09-28 9:40 ` Arend Van Spriel
2020-09-28 9:40 ` [Intel-wired-lan] " Arend Van Spriel
2020-09-27 19:49 ` [patch 25/35] net: brcmfmac: Use netif_rx_any_context() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 8:03 ` Arend Van Spriel
2020-09-28 8:03 ` [Intel-wired-lan] " Arend Van Spriel
2020-09-27 19:49 ` [patch 26/35] net: brcmfmac: Convey allocation mode as argument Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 9:34 ` Arend Van Spriel
2020-09-28 9:34 ` [Intel-wired-lan] " Arend Van Spriel
2020-09-27 19:49 ` [patch 27/35] net: ipw2x00,iwlegacy,iwlwifi: Remove in_interrupt() from debug macros Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] [patch 27/35] net: ipw2x00, iwlegacy, iwlwifi: " Thomas Gleixner
2020-09-27 19:49 ` [patch 28/35] net: iwlwifi: Remove in_interrupt() from tracing macro Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-28 6:13 ` Coelho, Luciano
2020-09-28 6:13 ` [Intel-wired-lan] " Coelho, Luciano
2020-09-27 19:49 ` [patch 29/35] net: hostap: Remove in_interrupt() usage Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 30/35] net: mwifiex: Use netif_rx_any_context() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 31/35] net: libertas libertas_tf: Remove in_interrupt() from debug macro Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 32/35] net: libertas: Use netif_rx_any_context() Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 33/35] net: rtlwifi: Remove void* casts related to delayed work Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 34/35] net: rtlwifi: Remove in_interrupt() from debug macro Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 19:49 ` [patch 35/35] net: rtlwifi: Replace in_interrupt() for context detection Thomas Gleixner
2020-09-27 19:49 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-27 20:22 ` [patch 00/35] net: in_interrupt() cleanup and fixes Joe Perches
2020-09-27 20:22 ` [Intel-wired-lan] " Joe Perches
2020-09-27 20:57 ` David Miller
2020-09-27 20:57 ` [Intel-wired-lan] " David Miller
2020-09-28 10:25 ` Thomas Gleixner
2020-09-28 10:25 ` [Intel-wired-lan] " Thomas Gleixner
2020-09-29 8:01 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0wdk5t2.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=ecree@solarflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.