From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jic23@kernel.org, nicolas.ferre@microchip.com, ludovic.desroches@microchip.com Subject: Re: [PATCH v3 3/4] iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr() Date: Wed, 30 Sep 2020 15:02:54 +0200 [thread overview] Message-ID: <20200930130254.GG2804081@piout.net> (raw) In-Reply-To: <20200930125216.90424-4-alexandru.ardelean@analog.com> On 30/09/2020 15:52:15+0300, Alexandru Ardelean wrote: > This tries to solve a warning reported by the lkp bot: > > >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable > >> 'at91_adc_dt_ids' [-Wunused-const-variable] > static const struct of_device_id at91_adc_dt_ids[] = { > ^ > 1 warning generated. > > This warning has appeared after the AT91_ADC driver compilation has been > enabled via the COMPILE_TEST symbol dependency. > > The warning is caused by the 'of_match_ptr()' helper which returns NULL if > OF is undefined. This driver should build only for device-tree context, so > a dependency on the OF Kconfig symbol has been added. > Also, the usage of of_match_ptr() helper has been removed since it > shouldn't ever return NULL (because the driver should not be built for the > non-OF context). > > Fixes: 4027860dcc4c ("iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/iio/adc/Kconfig | 2 +- > drivers/iio/adc/at91_adc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 91ae90514aff..17e9ceb9c6c4 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -295,7 +295,7 @@ config ASPEED_ADC > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 || COMPILE_TEST > - depends on INPUT && SYSFS > + depends on INPUT && SYSFS && OF > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com> To: Alexandru Ardelean <alexandru.ardelean@analog.com> Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-arm-kernel@lists.infradead.org, jic23@kernel.org Subject: Re: [PATCH v3 3/4] iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr() Date: Wed, 30 Sep 2020 15:02:54 +0200 [thread overview] Message-ID: <20200930130254.GG2804081@piout.net> (raw) In-Reply-To: <20200930125216.90424-4-alexandru.ardelean@analog.com> On 30/09/2020 15:52:15+0300, Alexandru Ardelean wrote: > This tries to solve a warning reported by the lkp bot: > > >> drivers/iio/adc/at91_adc.c:1439:34: warning: unused variable > >> 'at91_adc_dt_ids' [-Wunused-const-variable] > static const struct of_device_id at91_adc_dt_ids[] = { > ^ > 1 warning generated. > > This warning has appeared after the AT91_ADC driver compilation has been > enabled via the COMPILE_TEST symbol dependency. > > The warning is caused by the 'of_match_ptr()' helper which returns NULL if > OF is undefined. This driver should build only for device-tree context, so > a dependency on the OF Kconfig symbol has been added. > Also, the usage of of_match_ptr() helper has been removed since it > shouldn't ever return NULL (because the driver should not be built for the > non-OF context). > > Fixes: 4027860dcc4c ("iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver") > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com> > --- > drivers/iio/adc/Kconfig | 2 +- > drivers/iio/adc/at91_adc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig > index 91ae90514aff..17e9ceb9c6c4 100644 > --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -295,7 +295,7 @@ config ASPEED_ADC > config AT91_ADC > tristate "Atmel AT91 ADC" > depends on ARCH_AT91 || COMPILE_TEST > - depends on INPUT && SYSFS > + depends on INPUT && SYSFS && OF > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER > help > diff --git a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c > index 7d846a2852a5..473bffe84fbd 100644 > --- a/drivers/iio/adc/at91_adc.c > +++ b/drivers/iio/adc/at91_adc.c > @@ -1466,7 +1466,7 @@ static struct platform_driver at91_adc_driver = { > .id_table = at91_adc_ids, > .driver = { > .name = DRIVER_NAME, > - .of_match_table = of_match_ptr(at91_adc_dt_ids), > + .of_match_table = at91_adc_dt_ids, > .pm = &at91_adc_pm_ops, > }, > }; > -- > 2.17.1 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-30 13:02 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-30 12:52 [PATCH v3 0/4] iio: adc: at91: misc driver cleanups Alexandru Ardelean 2020-09-30 12:52 ` Alexandru Ardelean 2020-09-30 12:52 ` [PATCH v3 1/4] iio: adc: at91_adc: use of_device_get_match_data() helper Alexandru Ardelean 2020-09-30 12:52 ` Alexandru Ardelean 2020-09-30 12:52 ` [PATCH v3 2/4] iio: adc: at91_adc: const-ify some driver data Alexandru Ardelean 2020-09-30 12:52 ` Alexandru Ardelean 2020-09-30 12:52 ` [PATCH v3 3/4] iio: adc: at91_adc: add Kconfig dep on the OF symbol and remove of_match_ptr() Alexandru Ardelean 2020-09-30 12:52 ` Alexandru Ardelean 2020-09-30 13:02 ` Alexandre Belloni [this message] 2020-09-30 13:02 ` Alexandre Belloni 2020-09-30 12:52 ` [PATCH v3 4/4] iio: adc: at91_adc: remove platform data and move defs in driver file Alexandru Ardelean 2020-09-30 12:52 ` Alexandru Ardelean 2020-09-30 13:07 ` Alexandre Belloni 2020-09-30 13:07 ` Alexandre Belloni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200930130254.GG2804081@piout.net \ --to=alexandre.belloni@bootlin.com \ --cc=alexandru.ardelean@analog.com \ --cc=jic23@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=nicolas.ferre@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.