From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: kernel test robot <lkp@intel.com>
Cc: linux-integrity@vger.kernel.org, kbuild-all@lists.01.org,
clang-built-linux@googlegroups.com,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
stable@vger.kernel.org, David Howells <dhowells@redhat.com>,
Mimi Zohar <zohar@linux.ibm.com>,
Sumit Garg <sumit.garg@linaro.org>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/3] KEYS: trusted: Reserve TPM for seal and unseal operations
Date: Mon, 5 Oct 2020 06:30:27 +0300 [thread overview]
Message-ID: <20201005033027.GA144802@linux.intel.com> (raw)
In-Reply-To: <202010051054.nSqmgsmE-lkp@intel.com>
I'll fix this this and send v2.
/Jarkko
On Mon, Oct 05, 2020 at 10:42:00AM +0800, kernel test robot wrote:
> Hi Jarkko,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on security/next-testing]
> [also build test WARNING on integrity/next-integrity char-misc/char-misc-testing linus/master v5.9-rc8 next-20201002]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/KEYS-trusted-Fix-incorrect-handling-of-tpm_get_random/20201005-092710
> base: https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-testing
> config: x86_64-randconfig-a002-20201005 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bcd05599d0e53977a963799d6ee4f6e0bc21331b)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/ef36c0cd07555d658f81aee66abb02bdbe1c37b7
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Jarkko-Sakkinen/KEYS-trusted-Fix-incorrect-handling-of-tpm_get_random/20201005-092710
> git checkout ef36c0cd07555d658f81aee66abb02bdbe1c37b7
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> In file included from security/keys/encrypted-keys/encrypted.c:22:
> In file included from include/keys/trusted-type.h:12:
> >> include/linux/tpm.h:423:16: warning: no previous prototype for function 'tpm_transmit_cmd' [-Wmissing-prototypes]
> extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> ^
> include/linux/tpm.h:423:8: note: declare 'static' if the function is not intended to be used outside of this translation unit
> extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> ^
> >> include/linux/tpm.h:426:1: warning: non-void function does not return a value [-Wreturn-type]
> }
> ^
> 2 warnings generated.
>
> vim +/tpm_transmit_cmd +423 include/linux/tpm.h
>
> 397
> 398 extern int tpm_is_tpm2(struct tpm_chip *chip);
> 399 extern __must_check int tpm_try_get_ops(struct tpm_chip *chip);
> 400 extern void tpm_put_ops(struct tpm_chip *chip);
> 401 extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> 402 size_t min_rsp_body_length, const char *desc);
> 403 extern int tpm_pcr_read(struct tpm_chip *chip, u32 pcr_idx,
> 404 struct tpm_digest *digest);
> 405 extern int tpm_pcr_extend(struct tpm_chip *chip, u32 pcr_idx,
> 406 struct tpm_digest *digests);
> 407 extern int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen);
> 408 extern int tpm_get_random(struct tpm_chip *chip, u8 *data, size_t max);
> 409 extern struct tpm_chip *tpm_default_chip(void);
> 410 void tpm2_flush_context(struct tpm_chip *chip, u32 handle);
> 411 #else
> 412 static inline int tpm_is_tpm2(struct tpm_chip *chip)
> 413 {
> 414 return -ENODEV;
> 415 }
> 416 static inline int tpm_try_get_ops(struct tpm_chip *chip)
> 417 {
> 418 return -ENODEV;
> 419 }
> 420 static inline void tpm_put_ops(struct tpm_chip *chip)
> 421 {
> 422 }
> > 423 extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> 424 size_t min_rsp_body_length, const char *desc)
> 425 {
> > 426 }
> 427 static inline int tpm_pcr_read(struct tpm_chip *chip, int pcr_idx,
> 428 struct tpm_digest *digest)
> 429 {
> 430 return -ENODEV;
> 431 }
> 432
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 2/3] KEYS: trusted: Reserve TPM for seal and unseal operations
Date: Mon, 05 Oct 2020 06:30:27 +0300 [thread overview]
Message-ID: <20201005033027.GA144802@linux.intel.com> (raw)
In-Reply-To: <202010051054.nSqmgsmE-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 4429 bytes --]
I'll fix this this and send v2.
/Jarkko
On Mon, Oct 05, 2020 at 10:42:00AM +0800, kernel test robot wrote:
> Hi Jarkko,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on security/next-testing]
> [also build test WARNING on integrity/next-integrity char-misc/char-misc-testing linus/master v5.9-rc8 next-20201002]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Jarkko-Sakkinen/KEYS-trusted-Fix-incorrect-handling-of-tpm_get_random/20201005-092710
> base: https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next-testing
> config: x86_64-randconfig-a002-20201005 (attached as .config)
> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project bcd05599d0e53977a963799d6ee4f6e0bc21331b)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # install x86_64 cross compiling tool for clang build
> # apt-get install binutils-x86-64-linux-gnu
> # https://github.com/0day-ci/linux/commit/ef36c0cd07555d658f81aee66abb02bdbe1c37b7
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Jarkko-Sakkinen/KEYS-trusted-Fix-incorrect-handling-of-tpm_get_random/20201005-092710
> git checkout ef36c0cd07555d658f81aee66abb02bdbe1c37b7
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> In file included from security/keys/encrypted-keys/encrypted.c:22:
> In file included from include/keys/trusted-type.h:12:
> >> include/linux/tpm.h:423:16: warning: no previous prototype for function 'tpm_transmit_cmd' [-Wmissing-prototypes]
> extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> ^
> include/linux/tpm.h:423:8: note: declare 'static' if the function is not intended to be used outside of this translation unit
> extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> ^
> >> include/linux/tpm.h:426:1: warning: non-void function does not return a value [-Wreturn-type]
> }
> ^
> 2 warnings generated.
>
> vim +/tpm_transmit_cmd +423 include/linux/tpm.h
>
> 397
> 398 extern int tpm_is_tpm2(struct tpm_chip *chip);
> 399 extern __must_check int tpm_try_get_ops(struct tpm_chip *chip);
> 400 extern void tpm_put_ops(struct tpm_chip *chip);
> 401 extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> 402 size_t min_rsp_body_length, const char *desc);
> 403 extern int tpm_pcr_read(struct tpm_chip *chip, u32 pcr_idx,
> 404 struct tpm_digest *digest);
> 405 extern int tpm_pcr_extend(struct tpm_chip *chip, u32 pcr_idx,
> 406 struct tpm_digest *digests);
> 407 extern int tpm_send(struct tpm_chip *chip, void *cmd, size_t buflen);
> 408 extern int tpm_get_random(struct tpm_chip *chip, u8 *data, size_t max);
> 409 extern struct tpm_chip *tpm_default_chip(void);
> 410 void tpm2_flush_context(struct tpm_chip *chip, u32 handle);
> 411 #else
> 412 static inline int tpm_is_tpm2(struct tpm_chip *chip)
> 413 {
> 414 return -ENODEV;
> 415 }
> 416 static inline int tpm_try_get_ops(struct tpm_chip *chip)
> 417 {
> 418 return -ENODEV;
> 419 }
> 420 static inline void tpm_put_ops(struct tpm_chip *chip)
> 421 {
> 422 }
> > 423 extern ssize_t tpm_transmit_cmd(struct tpm_chip *chip, struct tpm_buf *buf,
> 424 size_t min_rsp_body_length, const char *desc)
> 425 {
> > 426 }
> 427 static inline int tpm_pcr_read(struct tpm_chip *chip, int pcr_idx,
> 428 struct tpm_digest *digest)
> 429 {
> 430 return -ENODEV;
> 431 }
> 432
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
next prev parent reply other threads:[~2020-10-05 3:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 0:26 [PATCH 0/3] A bunch of trusted keys fixes Jarkko Sakkinen
2020-10-05 0:26 ` [PATCH 1/3] KEYS: trusted: Fix incorrect handling of tpm_get_random() Jarkko Sakkinen
2020-10-05 0:26 ` Jarkko Sakkinen
2020-10-05 0:26 ` [PATCH 2/3] KEYS: trusted: Reserve TPM for seal and unseal operations Jarkko Sakkinen
2020-10-05 0:26 ` Jarkko Sakkinen
2020-10-05 2:42 ` kernel test robot
2020-10-05 2:42 ` kernel test robot
2020-10-05 3:30 ` Jarkko Sakkinen [this message]
2020-10-05 3:30 ` Jarkko Sakkinen
2020-10-05 3:19 ` kernel test robot
2020-10-05 3:19 ` kernel test robot
2020-10-05 0:26 ` [PATCH 3/3] KEYS: trusted: Fix migratable=1 failing Jarkko Sakkinen
2020-10-05 0:26 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201005033027.GA144802@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=arnd@arndb.de \
--cc=clang-built-linux@googlegroups.com \
--cc=dhowells@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kbuild-all@lists.01.org \
--cc=linux-integrity@vger.kernel.org \
--cc=lkp@intel.com \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.