From: Moritz Fischer <mdf@kernel.org> To: linux-fpga@vger.kernel.org Cc: trix@redhat.com, hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com, Moritz Fischer <mdf@kernel.org> Subject: [PATCH v2 05/10] fpga: fpga-mgr: machxo2-spi: Simplify registration Date: Mon, 5 Oct 2020 10:37:30 -0700 [thread overview] Message-ID: <20201005173735.162408-6-mdf@kernel.org> (raw) In-Reply-To: <20201005173735.162408-1-mdf@kernel.org> Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix <trix@redhat.com> Signed-off-by: Moritz Fischer <mdf@kernel.org> --- drivers/fpga/machxo2-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index b316369156fe..114a64d2b7a4 100644 --- a/drivers/fpga/machxo2-spi.c +++ b/drivers/fpga/machxo2-spi.c @@ -371,18 +371,7 @@ static int machxo2_spi_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int machxo2_spi_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(dev, mgr); } static const struct of_device_id of_match[] = { @@ -403,7 +392,6 @@ static struct spi_driver machxo2_spi_driver = { .of_match_table = of_match_ptr(of_match), }, .probe = machxo2_spi_probe, - .remove = machxo2_spi_remove, .id_table = lattice_ids, }; -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Moritz Fischer <mdf@kernel.org> To: linux-fpga@vger.kernel.org Cc: russell.h.weight@intel.com, trix@redhat.com, michal.simek@xilinx.com, matthew.gerlach@intel.com, linux-kernel@vger.kernel.org, Moritz Fischer <mdf@kernel.org>, linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Subject: [PATCH v2 05/10] fpga: fpga-mgr: machxo2-spi: Simplify registration Date: Mon, 5 Oct 2020 10:37:30 -0700 [thread overview] Message-ID: <20201005173735.162408-6-mdf@kernel.org> (raw) In-Reply-To: <20201005173735.162408-1-mdf@kernel.org> Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix <trix@redhat.com> Signed-off-by: Moritz Fischer <mdf@kernel.org> --- drivers/fpga/machxo2-spi.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index b316369156fe..114a64d2b7a4 100644 --- a/drivers/fpga/machxo2-spi.c +++ b/drivers/fpga/machxo2-spi.c @@ -371,18 +371,7 @@ static int machxo2_spi_probe(struct spi_device *spi) if (!mgr) return -ENOMEM; - spi_set_drvdata(spi, mgr); - - return fpga_mgr_register(mgr); -} - -static int machxo2_spi_remove(struct spi_device *spi) -{ - struct fpga_manager *mgr = spi_get_drvdata(spi); - - fpga_mgr_unregister(mgr); - - return 0; + return devm_fpga_mgr_register(dev, mgr); } static const struct of_device_id of_match[] = { @@ -403,7 +392,6 @@ static struct spi_driver machxo2_spi_driver = { .of_match_table = of_match_ptr(of_match), }, .probe = machxo2_spi_probe, - .remove = machxo2_spi_remove, .id_table = lattice_ids, }; -- 2.28.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-05 17:38 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-05 17:37 Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-09 21:25 ` Moritz Fischer 2020-10-09 21:25 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 03/10] fpga: fpga-mgr: dfl-fme-mgr: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 04/10] fpga: fpga-mgr: ice40-spi: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer [this message] 2020-10-05 17:37 ` [PATCH v2 05/10] fpga: fpga-mgr: machxo2-spi: " Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 06/10] fpga: fpga-mgr: socfpga: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 07/10] fpga: fpga-mgr: ts73xx: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 08/10] fpga: fpga-mgr: xilinx-spi: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 09/10] fpga: fpga-mgr: zynqmp: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 17:37 ` [PATCH v2 10/10] fpga: fpga-mgr: altera-pr-ip: " Moritz Fischer 2020-10-05 17:37 ` Moritz Fischer 2020-10-05 20:13 ` Tom Rix 2020-10-05 20:13 ` Tom Rix
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201005173735.162408-6-mdf@kernel.org \ --to=mdf@kernel.org \ --cc=hao.wu@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=matthew.gerlach@intel.com \ --cc=michal.simek@xilinx.com \ --cc=russell.h.weight@intel.com \ --cc=trix@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.