From: Greg KH <gregkh@linuxfoundation.org>
To: Bert Vermeulen <bert@biot.com>
Cc: tudor.ambarus@microchip.com, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [RESEND PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB
Date: Tue, 6 Oct 2020 17:33:01 +0200 [thread overview]
Message-ID: <20201006153301.GC23711@kroah.com> (raw)
In-Reply-To: <20201006132346.12652-1-bert@biot.com>
On Tue, Oct 06, 2020 at 03:23:46PM +0200, Bert Vermeulen wrote:
> If a flash chip has more than 16MB capacity but its BFPT reports
> BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3.
>
> The check in spi_nor_set_addr_width() doesn't catch it because addr_width
> did get set. This fixes that check.
>
> Fixes: f9acd7fa80be ("mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths")
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Bert Vermeulen <bert@biot.com>
Cc: vigneshr@ti.com, tudor.ambarus@microchip.com, richard@nod.at,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com
Subject: Re: [RESEND PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB
Date: Tue, 6 Oct 2020 17:33:01 +0200 [thread overview]
Message-ID: <20201006153301.GC23711@kroah.com> (raw)
In-Reply-To: <20201006132346.12652-1-bert@biot.com>
On Tue, Oct 06, 2020 at 03:23:46PM +0200, Bert Vermeulen wrote:
> If a flash chip has more than 16MB capacity but its BFPT reports
> BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3.
>
> The check in spi_nor_set_addr_width() doesn't catch it because addr_width
> did get set. This fixes that check.
>
> Fixes: f9acd7fa80be ("mtd: spi-nor: sfdp: default to addr_width of 3 for configurable widths")
> Signed-off-by: Bert Vermeulen <bert@biot.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> drivers/mtd/spi-nor/core.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-06 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 13:23 [RESEND PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB Bert Vermeulen
2020-10-06 13:23 ` Bert Vermeulen
2020-10-06 15:18 ` Pratyush Yadav
2020-10-06 15:18 ` Pratyush Yadav
2020-10-07 7:29 ` Vignesh Raghavendra
2020-10-07 7:29 ` Vignesh Raghavendra
2020-10-07 7:48 ` Pratyush Yadav
2020-10-07 7:48 ` Pratyush Yadav
2020-10-06 15:33 ` Greg KH [this message]
2020-10-06 15:33 ` Greg KH
2020-10-29 4:46 ` Vignesh Raghavendra
2020-10-29 4:46 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201006153301.GC23711@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bert@biot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=tudor.ambarus@microchip.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.