From: Borislav Petkov <bp@alien8.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-tip-commits@vger.kernel.org,
Tony Luck <tony.luck@intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
stable@vger.kernel.org, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [tip: ras/core] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()
Date: Wed, 7 Oct 2020 19:03:05 +0200 [thread overview]
Message-ID: <20201007170305.GK5607@zn.tnic> (raw)
In-Reply-To: <20201007164536.GJ5607@zn.tnic>
On Wed, Oct 07, 2020 at 06:45:36PM +0200, Borislav Petkov wrote:
> It doesn't look like it is toolchain-specific and in both cases,
> copy_mc_fragile's checksum is 0.
>
> SUSE Leap 15.1:
>
> Name : binutils
> Version : 2.32-lp151.3.6.1
>
> $ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers
> 0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL
> 0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL
>
> debian testing:
>
> Package: binutils
> Version: 2.35-2
>
> $ grep -E "(copy_mc_fragile|copy_user_generic_unrolled)" Module.symvers
> 0x00000000 copy_mc_fragile vmlinux EXPORT_SYMBOL_GPL
> 0xecdcabd2 copy_user_generic_unrolled vmlinux EXPORT_SYMBOL
Ok, I think I have it:
---
From: Borislav Petkov <bp@suse.de>
Date: Wed, 7 Oct 2020 18:55:35 +0200
Subject: [PATCH] x86/mce: Allow for copy_mc_fragile symbol checksum to be generated
Add asm/mce.h to asm/asm-prototypes.h so that that asm symbol's checksum
can be generated in order to support CONFIG_MODVERSIONS with it and fix:
WARNING: modpost: EXPORT symbol "copy_mc_fragile" [vmlinux] version \
generation failed, symbol will not be versioned.
For reference see:
4efca4ed05cb ("kbuild: modversions for EXPORT_SYMBOL() for asm")
334bb7738764 ("x86/kbuild: enable modversions for symbols exported from asm")
Fixes: ec6347bb4339 ("x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}()")
Signed-off-by: Borislav Petkov <bp@suse.de>
---
arch/x86/include/asm/asm-prototypes.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/include/asm/asm-prototypes.h b/arch/x86/include/asm/asm-prototypes.h
index 5a42f9206138..51e2bf27cc9b 100644
--- a/arch/x86/include/asm/asm-prototypes.h
+++ b/arch/x86/include/asm/asm-prototypes.h
@@ -5,6 +5,7 @@
#include <asm/string.h>
#include <asm/page.h>
#include <asm/checksum.h>
+#include <asm/mce.h>
#include <asm-generic/asm-prototypes.h>
--
2.21.0
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-10-07 17:03 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 20:30 [PATCH] x86/memcpy: Introduce memcpy_mcsafe_fast Andy Lutomirski
2020-04-18 20:30 ` Andy Lutomirski
2020-04-18 20:52 ` Linus Torvalds
2020-04-18 20:52 ` Linus Torvalds
2020-04-20 5:08 ` Dan Williams
2020-04-20 5:08 ` Dan Williams
2020-04-20 17:28 ` Linus Torvalds
2020-04-20 17:28 ` Linus Torvalds
2020-04-20 18:20 ` Dan Williams
2020-04-20 18:20 ` Dan Williams
2020-04-20 19:05 ` Linus Torvalds
2020-04-20 19:05 ` Linus Torvalds
2020-04-20 19:29 ` Dan Williams
2020-04-20 19:29 ` Dan Williams
2020-04-20 20:07 ` Linus Torvalds
2020-04-20 20:07 ` Linus Torvalds
2020-04-20 20:23 ` Luck, Tony
2020-04-20 20:23 ` Luck, Tony
2020-04-20 20:27 ` Linus Torvalds
2020-04-20 20:27 ` Linus Torvalds
2020-04-20 20:45 ` Luck, Tony
2020-04-20 20:45 ` Luck, Tony
2020-04-20 20:56 ` Linus Torvalds
2020-04-20 20:56 ` Linus Torvalds
2020-04-20 20:24 ` Dan Williams
2020-04-20 20:24 ` Dan Williams
2020-04-20 20:46 ` Linus Torvalds
2020-04-20 20:46 ` Linus Torvalds
2020-04-20 20:57 ` Luck, Tony
2020-04-20 20:57 ` Luck, Tony
2020-04-20 21:16 ` Linus Torvalds
2020-04-20 21:16 ` Linus Torvalds
2020-10-06 9:57 ` [tip: ras/core] x86, powerpc: Rename memcpy_mcsafe() to copy_mc_to_{user, kernel}() tip-bot2 for Dan Williams
2020-10-07 11:14 ` Borislav Petkov
2020-10-07 16:45 ` Borislav Petkov
2020-10-07 17:03 ` Borislav Petkov [this message]
2020-10-07 18:53 ` Dan Williams
2020-10-07 19:25 ` Borislav Petkov
2020-10-08 16:59 ` Dan Williams
2020-10-08 17:08 ` Borislav Petkov
2020-10-07 17:51 ` Dan Williams
2020-10-07 18:24 ` [PATCH] x86/mce: Gate copy_mc_fragile() export by CONFIG_COPY_MC_TEST=y Dan Williams
2020-10-07 18:24 ` Dan Williams
2020-10-08 9:01 ` [tip: ras/core] x86/mce: Allow for copy_mc_fragile symbol checksum to be generated tip-bot2 for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007170305.GK5607@zn.tnic \
--to=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=stable@vger.kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.