From: kernel test robot <lkp@intel.com> To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>, mpe@ellerman.id.au Cc: ravi.bangoria@linux.ibm.com, kbuild-all@lists.01.org, bala24@linux.ibm.com, paulus@samba.org, sandipan@linux.ibm.com, naveen.n.rao@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v4 2/4] powerpc/sstep: Support VSX vector paired storage access instructions Date: Thu, 8 Oct 2020 19:24:54 +0800 [thread overview] Message-ID: <202010081900.qsL0QYZ6-lkp@intel.com> (raw) In-Reply-To: <20201008072726.233086-3-ravi.bangoria@linux.ibm.com> [-- Attachment #1: Type: text/plain, Size: 6998 bytes --] Hi Ravi, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.9-rc8 next-20201007] [cannot apply to mpe/next scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ravi-Bangoria/powerpc-sstep-VSX-32-byte-vector-paired-load-store-instructions/20201008-153614 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-g5_defconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/55def6779849f9aec057f405abf1cd98a8674b4f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ravi-Bangoria/powerpc-sstep-VSX-32-byte-vector-paired-load-store-instructions/20201008-153614 git checkout 55def6779849f9aec057f405abf1cd98a8674b4f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): arch/powerpc/lib/sstep.c: In function 'analyse_instr': >> arch/powerpc/lib/sstep.c:2901:15: error: implicit declaration of function 'VSX_REGISTER_XTP'; did you mean 'H_REGISTER_SMR'? [-Werror=implicit-function-declaration] 2901 | op->reg = VSX_REGISTER_XTP(rd); | ^~~~~~~~~~~~~~~~ | H_REGISTER_SMR cc1: all warnings being treated as errors vim +2901 arch/powerpc/lib/sstep.c 2815 2816 #ifdef __powerpc64__ 2817 case 62: /* std[u] */ 2818 op->ea = dsform_ea(word, regs); 2819 switch (word & 3) { 2820 case 0: /* std */ 2821 op->type = MKOP(STORE, 0, 8); 2822 break; 2823 case 1: /* stdu */ 2824 op->type = MKOP(STORE, UPDATE, 8); 2825 break; 2826 case 2: /* stq */ 2827 if (!(rd & 1)) 2828 op->type = MKOP(STORE, 0, 16); 2829 break; 2830 } 2831 break; 2832 case 1: /* Prefixed instructions */ 2833 if (!cpu_has_feature(CPU_FTR_ARCH_31)) 2834 return -1; 2835 2836 prefix_r = GET_PREFIX_R(word); 2837 ra = GET_PREFIX_RA(suffix); 2838 op->update_reg = ra; 2839 rd = (suffix >> 21) & 0x1f; 2840 op->reg = rd; 2841 op->val = regs->gpr[rd]; 2842 2843 suffixopcode = get_op(suffix); 2844 prefixtype = (word >> 24) & 0x3; 2845 switch (prefixtype) { 2846 case 0: /* Type 00 Eight-Byte Load/Store */ 2847 if (prefix_r && ra) 2848 break; 2849 op->ea = mlsd_8lsd_ea(word, suffix, regs); 2850 switch (suffixopcode) { 2851 case 41: /* plwa */ 2852 op->type = MKOP(LOAD, PREFIXED | SIGNEXT, 4); 2853 break; 2854 case 42: /* plxsd */ 2855 op->reg = rd + 32; 2856 op->type = MKOP(LOAD_VSX, PREFIXED, 8); 2857 op->element_size = 8; 2858 op->vsx_flags = VSX_CHECK_VEC; 2859 break; 2860 case 43: /* plxssp */ 2861 op->reg = rd + 32; 2862 op->type = MKOP(LOAD_VSX, PREFIXED, 4); 2863 op->element_size = 8; 2864 op->vsx_flags = VSX_FPCONV | VSX_CHECK_VEC; 2865 break; 2866 case 46: /* pstxsd */ 2867 op->reg = rd + 32; 2868 op->type = MKOP(STORE_VSX, PREFIXED, 8); 2869 op->element_size = 8; 2870 op->vsx_flags = VSX_CHECK_VEC; 2871 break; 2872 case 47: /* pstxssp */ 2873 op->reg = rd + 32; 2874 op->type = MKOP(STORE_VSX, PREFIXED, 4); 2875 op->element_size = 8; 2876 op->vsx_flags = VSX_FPCONV | VSX_CHECK_VEC; 2877 break; 2878 case 51: /* plxv1 */ 2879 op->reg += 32; 2880 fallthrough; 2881 case 50: /* plxv0 */ 2882 op->type = MKOP(LOAD_VSX, PREFIXED, 16); 2883 op->element_size = 16; 2884 op->vsx_flags = VSX_CHECK_VEC; 2885 break; 2886 case 55: /* pstxv1 */ 2887 op->reg = rd + 32; 2888 fallthrough; 2889 case 54: /* pstxv0 */ 2890 op->type = MKOP(STORE_VSX, PREFIXED, 16); 2891 op->element_size = 16; 2892 op->vsx_flags = VSX_CHECK_VEC; 2893 break; 2894 case 56: /* plq */ 2895 op->type = MKOP(LOAD, PREFIXED, 16); 2896 break; 2897 case 57: /* pld */ 2898 op->type = MKOP(LOAD, PREFIXED, 8); 2899 break; 2900 case 58: /* plxvp */ > 2901 op->reg = VSX_REGISTER_XTP(rd); 2902 op->type = MKOP(LOAD_VSX, PREFIXED, 32); 2903 op->element_size = 32; 2904 break; 2905 case 60: /* stq */ 2906 op->type = MKOP(STORE, PREFIXED, 16); 2907 break; 2908 case 61: /* pstd */ 2909 op->type = MKOP(STORE, PREFIXED, 8); 2910 break; 2911 case 62: /* pstxvp */ 2912 op->reg = VSX_REGISTER_XTP(rd); 2913 op->type = MKOP(STORE_VSX, PREFIXED, 32); 2914 op->element_size = 32; 2915 break; 2916 } 2917 break; 2918 case 1: /* Type 01 Eight-Byte Register-to-Register */ 2919 break; 2920 case 2: /* Type 10 Modified Load/Store */ 2921 if (prefix_r && ra) 2922 break; 2923 op->ea = mlsd_8lsd_ea(word, suffix, regs); 2924 switch (suffixopcode) { 2925 case 32: /* plwz */ 2926 op->type = MKOP(LOAD, PREFIXED, 4); 2927 break; 2928 case 34: /* plbz */ 2929 op->type = MKOP(LOAD, PREFIXED, 1); 2930 break; 2931 case 36: /* pstw */ 2932 op->type = MKOP(STORE, PREFIXED, 4); 2933 break; 2934 case 38: /* pstb */ 2935 op->type = MKOP(STORE, PREFIXED, 1); 2936 break; 2937 case 40: /* plhz */ 2938 op->type = MKOP(LOAD, PREFIXED, 2); 2939 break; 2940 case 42: /* plha */ 2941 op->type = MKOP(LOAD, PREFIXED | SIGNEXT, 2); 2942 break; 2943 case 44: /* psth */ 2944 op->type = MKOP(STORE, PREFIXED, 2); 2945 break; 2946 case 48: /* plfs */ 2947 op->type = MKOP(LOAD_FP, PREFIXED | FPCONV, 4); 2948 break; 2949 case 50: /* plfd */ 2950 op->type = MKOP(LOAD_FP, PREFIXED, 8); 2951 break; 2952 case 52: /* pstfs */ 2953 op->type = MKOP(STORE_FP, PREFIXED | FPCONV, 4); 2954 break; 2955 case 54: /* pstfd */ 2956 op->type = MKOP(STORE_FP, PREFIXED, 8); 2957 break; 2958 } 2959 break; 2960 case 3: /* Type 11 Modified Register-to-Register */ 2961 break; 2962 } 2963 #endif /* __powerpc64__ */ 2964 2965 } 2966 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 22196 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH v4 2/4] powerpc/sstep: Support VSX vector paired storage access instructions Date: Thu, 08 Oct 2020 19:24:54 +0800 [thread overview] Message-ID: <202010081900.qsL0QYZ6-lkp@intel.com> (raw) In-Reply-To: <20201008072726.233086-3-ravi.bangoria@linux.ibm.com> [-- Attachment #1: Type: text/plain, Size: 7195 bytes --] Hi Ravi, Thank you for the patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v5.9-rc8 next-20201007] [cannot apply to mpe/next scottwood/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ravi-Bangoria/powerpc-sstep-VSX-32-byte-vector-paired-load-store-instructions/20201008-153614 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: powerpc-g5_defconfig (attached as .config) compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/55def6779849f9aec057f405abf1cd98a8674b4f git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ravi-Bangoria/powerpc-sstep-VSX-32-byte-vector-paired-load-store-instructions/20201008-153614 git checkout 55def6779849f9aec057f405abf1cd98a8674b4f # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All errors (new ones prefixed by >>): arch/powerpc/lib/sstep.c: In function 'analyse_instr': >> arch/powerpc/lib/sstep.c:2901:15: error: implicit declaration of function 'VSX_REGISTER_XTP'; did you mean 'H_REGISTER_SMR'? [-Werror=implicit-function-declaration] 2901 | op->reg = VSX_REGISTER_XTP(rd); | ^~~~~~~~~~~~~~~~ | H_REGISTER_SMR cc1: all warnings being treated as errors vim +2901 arch/powerpc/lib/sstep.c 2815 2816 #ifdef __powerpc64__ 2817 case 62: /* std[u] */ 2818 op->ea = dsform_ea(word, regs); 2819 switch (word & 3) { 2820 case 0: /* std */ 2821 op->type = MKOP(STORE, 0, 8); 2822 break; 2823 case 1: /* stdu */ 2824 op->type = MKOP(STORE, UPDATE, 8); 2825 break; 2826 case 2: /* stq */ 2827 if (!(rd & 1)) 2828 op->type = MKOP(STORE, 0, 16); 2829 break; 2830 } 2831 break; 2832 case 1: /* Prefixed instructions */ 2833 if (!cpu_has_feature(CPU_FTR_ARCH_31)) 2834 return -1; 2835 2836 prefix_r = GET_PREFIX_R(word); 2837 ra = GET_PREFIX_RA(suffix); 2838 op->update_reg = ra; 2839 rd = (suffix >> 21) & 0x1f; 2840 op->reg = rd; 2841 op->val = regs->gpr[rd]; 2842 2843 suffixopcode = get_op(suffix); 2844 prefixtype = (word >> 24) & 0x3; 2845 switch (prefixtype) { 2846 case 0: /* Type 00 Eight-Byte Load/Store */ 2847 if (prefix_r && ra) 2848 break; 2849 op->ea = mlsd_8lsd_ea(word, suffix, regs); 2850 switch (suffixopcode) { 2851 case 41: /* plwa */ 2852 op->type = MKOP(LOAD, PREFIXED | SIGNEXT, 4); 2853 break; 2854 case 42: /* plxsd */ 2855 op->reg = rd + 32; 2856 op->type = MKOP(LOAD_VSX, PREFIXED, 8); 2857 op->element_size = 8; 2858 op->vsx_flags = VSX_CHECK_VEC; 2859 break; 2860 case 43: /* plxssp */ 2861 op->reg = rd + 32; 2862 op->type = MKOP(LOAD_VSX, PREFIXED, 4); 2863 op->element_size = 8; 2864 op->vsx_flags = VSX_FPCONV | VSX_CHECK_VEC; 2865 break; 2866 case 46: /* pstxsd */ 2867 op->reg = rd + 32; 2868 op->type = MKOP(STORE_VSX, PREFIXED, 8); 2869 op->element_size = 8; 2870 op->vsx_flags = VSX_CHECK_VEC; 2871 break; 2872 case 47: /* pstxssp */ 2873 op->reg = rd + 32; 2874 op->type = MKOP(STORE_VSX, PREFIXED, 4); 2875 op->element_size = 8; 2876 op->vsx_flags = VSX_FPCONV | VSX_CHECK_VEC; 2877 break; 2878 case 51: /* plxv1 */ 2879 op->reg += 32; 2880 fallthrough; 2881 case 50: /* plxv0 */ 2882 op->type = MKOP(LOAD_VSX, PREFIXED, 16); 2883 op->element_size = 16; 2884 op->vsx_flags = VSX_CHECK_VEC; 2885 break; 2886 case 55: /* pstxv1 */ 2887 op->reg = rd + 32; 2888 fallthrough; 2889 case 54: /* pstxv0 */ 2890 op->type = MKOP(STORE_VSX, PREFIXED, 16); 2891 op->element_size = 16; 2892 op->vsx_flags = VSX_CHECK_VEC; 2893 break; 2894 case 56: /* plq */ 2895 op->type = MKOP(LOAD, PREFIXED, 16); 2896 break; 2897 case 57: /* pld */ 2898 op->type = MKOP(LOAD, PREFIXED, 8); 2899 break; 2900 case 58: /* plxvp */ > 2901 op->reg = VSX_REGISTER_XTP(rd); 2902 op->type = MKOP(LOAD_VSX, PREFIXED, 32); 2903 op->element_size = 32; 2904 break; 2905 case 60: /* stq */ 2906 op->type = MKOP(STORE, PREFIXED, 16); 2907 break; 2908 case 61: /* pstd */ 2909 op->type = MKOP(STORE, PREFIXED, 8); 2910 break; 2911 case 62: /* pstxvp */ 2912 op->reg = VSX_REGISTER_XTP(rd); 2913 op->type = MKOP(STORE_VSX, PREFIXED, 32); 2914 op->element_size = 32; 2915 break; 2916 } 2917 break; 2918 case 1: /* Type 01 Eight-Byte Register-to-Register */ 2919 break; 2920 case 2: /* Type 10 Modified Load/Store */ 2921 if (prefix_r && ra) 2922 break; 2923 op->ea = mlsd_8lsd_ea(word, suffix, regs); 2924 switch (suffixopcode) { 2925 case 32: /* plwz */ 2926 op->type = MKOP(LOAD, PREFIXED, 4); 2927 break; 2928 case 34: /* plbz */ 2929 op->type = MKOP(LOAD, PREFIXED, 1); 2930 break; 2931 case 36: /* pstw */ 2932 op->type = MKOP(STORE, PREFIXED, 4); 2933 break; 2934 case 38: /* pstb */ 2935 op->type = MKOP(STORE, PREFIXED, 1); 2936 break; 2937 case 40: /* plhz */ 2938 op->type = MKOP(LOAD, PREFIXED, 2); 2939 break; 2940 case 42: /* plha */ 2941 op->type = MKOP(LOAD, PREFIXED | SIGNEXT, 2); 2942 break; 2943 case 44: /* psth */ 2944 op->type = MKOP(STORE, PREFIXED, 2); 2945 break; 2946 case 48: /* plfs */ 2947 op->type = MKOP(LOAD_FP, PREFIXED | FPCONV, 4); 2948 break; 2949 case 50: /* plfd */ 2950 op->type = MKOP(LOAD_FP, PREFIXED, 8); 2951 break; 2952 case 52: /* pstfs */ 2953 op->type = MKOP(STORE_FP, PREFIXED | FPCONV, 4); 2954 break; 2955 case 54: /* pstfd */ 2956 op->type = MKOP(STORE_FP, PREFIXED, 8); 2957 break; 2958 } 2959 break; 2960 case 3: /* Type 11 Modified Register-to-Register */ 2961 break; 2962 } 2963 #endif /* __powerpc64__ */ 2964 2965 } 2966 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 22196 bytes --]
next prev parent reply other threads:[~2020-10-08 11:28 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-08 7:27 [PATCH v4 0/4] powerpc/sstep: VSX 32-byte vector paired load/store instructions Ravi Bangoria 2020-10-08 7:27 ` [PATCH v4 1/4] powerpc/sstep: Emulate prefixed instructions only when CPU_FTR_ARCH_31 is set Ravi Bangoria 2020-10-08 7:27 ` [PATCH v4 2/4] powerpc/sstep: Support VSX vector paired storage access instructions Ravi Bangoria 2020-10-08 11:24 ` kernel test robot [this message] 2020-10-08 11:24 ` kernel test robot 2020-10-08 7:27 ` [PATCH v4 3/4] powerpc/ppc-opcode: Add encoding macros for VSX vector paired instructions Ravi Bangoria 2020-10-08 7:27 ` [PATCH v4 4/4] powerpc/sstep: Add testcases for VSX vector paired load/store instructions Ravi Bangoria
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202010081900.qsL0QYZ6-lkp@intel.com \ --to=lkp@intel.com \ --cc=bala24@linux.ibm.com \ --cc=kbuild-all@lists.01.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=naveen.n.rao@linux.vnet.ibm.com \ --cc=paulus@samba.org \ --cc=ravi.bangoria@linux.ibm.com \ --cc=sandipan@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.