All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 5.10-rc0: build error in ipi.c
Date: Thu, 15 Oct 2020 22:26:52 +0200	[thread overview]
Message-ID: <20201015202652.GA21085@duo.ucw.cz> (raw)
In-Reply-To: <1d6af6a15b71e77c268428ffbc519d6a@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Thu 2020-10-15 20:41:32, Marc Zyngier wrote:
> On 2020-10-15 18:18, Pavel Machek wrote:
> > Hi!
> > 
> > > > > I'm getting build problems in 5.10-rc0 in config for n900. ARM board.
> > > > >
> > > > > CONFIG_SMP=y
> > > > > CONFIG_SMP_ON_UP=y
> > > 
> > > On its own, this doesn't break anything with multi_v7_defconfig.
> > 
> > I sent config off-list. Let me know if it does not arrive or if you
> > need more info.
> 
> Try this for size:
> 
> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
> index 10a5aff4eecc..db923e0da162 100644
> --- a/kernel/irq/Kconfig
> +++ b/kernel/irq/Kconfig
> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
> 
>  # Generic IRQ IPI support
>  config GENERIC_IRQ_IPI
> +	select IRQ_DOMAIN_HIERARCHY
>  	bool
> 
>  # Generic MSI interrupt support
> 

My OCD prevents me from doing that! :-)...

select needs to be moved line below, for consistency. And yes, this
fixes it for me.

Tested-by: Pavel Machek <pavel@ucw.cz>
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2020-10-15 20:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15 10:12 5.10-rc0: build error in ipi.c Pavel Machek
2020-10-15 14:23 ` Thomas Gleixner
2020-10-15 15:50   ` Marc Zyngier
2020-10-15 17:18     ` Pavel Machek
2020-10-15 19:41       ` Marc Zyngier
2020-10-15 20:26         ` Pavel Machek [this message]
2020-10-15 23:24         ` Thomas Gleixner
2020-10-16  8:28           ` Marc Zyngier
2020-10-16  9:03             ` Thomas Gleixner
2020-11-01 17:00 ` [tip: irq/urgent] genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY tip-bot2 for Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201015202652.GA21085@duo.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.