From: Marc Zyngier <maz@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Pavel Machek <pavel@ucw.cz>, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 5.10-rc0: build error in ipi.c
Date: Fri, 16 Oct 2020 09:28:07 +0100 [thread overview]
Message-ID: <3ba522d1351445bc8a488ac10df80e7b@kernel.org> (raw)
In-Reply-To: <87d01jul7x.fsf@nanos.tec.linutronix.de>
On 2020-10-16 00:24, Thomas Gleixner wrote:
> On Thu, Oct 15 2020 at 20:41, Marc Zyngier wrote:
>> On 2020-10-15 18:18, Pavel Machek wrote:
>> diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig
>> index 10a5aff4eecc..db923e0da162 100644
>> --- a/kernel/irq/Kconfig
>> +++ b/kernel/irq/Kconfig
>> @@ -81,6 +81,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS
>>
>> # Generic IRQ IPI support
>> config GENERIC_IRQ_IPI
>> + select IRQ_DOMAIN_HIERARCHY
>> bool
>
> which makes some of the MIPS GENERIC_IRQ_IPI/IRQ_DOMAIN_HIERARCHY
> Kconfig magic in drivers/irqchip/Kconfig obsolete.
Good point. I'll queue this on top:
diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
index cd734df57c42..d2a651372e15 100644
--- a/drivers/irqchip/Kconfig
+++ b/drivers/irqchip/Kconfig
@@ -180,7 +180,6 @@ config IRQ_MIPS_CPU
select GENERIC_IRQ_CHIP
select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING
select IRQ_DOMAIN
- select IRQ_DOMAIN_HIERARCHY if GENERIC_IRQ_IPI
select GENERIC_IRQ_EFFECTIVE_AFF_MASK
config CLPS711X_IRQCHIP
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-10-16 8:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 10:12 5.10-rc0: build error in ipi.c Pavel Machek
2020-10-15 14:23 ` Thomas Gleixner
2020-10-15 15:50 ` Marc Zyngier
2020-10-15 17:18 ` Pavel Machek
2020-10-15 19:41 ` Marc Zyngier
2020-10-15 20:26 ` Pavel Machek
2020-10-15 23:24 ` Thomas Gleixner
2020-10-16 8:28 ` Marc Zyngier [this message]
2020-10-16 9:03 ` Thomas Gleixner
2020-11-01 17:00 ` [tip: irq/urgent] genirq: Let GENERIC_IRQ_IPI select IRQ_DOMAIN_HIERARCHY tip-bot2 for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ba522d1351445bc8a488ac10df80e7b@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.