From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: kvm@vger.kernel.org, linux-mm@kvack.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org,
linux-s390@vger.kernel.org,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Inki Dae" <inki.dae@samsung.com>,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"John Hubbard" <jhubbard@nvidia.com>,
"Jérôme Glisse" <jglisse@redhat.com>, "Jan Kara" <jack@suse.cz>,
"Dan Williams" <dan.j.williams@intel.com>,
"Daniel Vetter" <daniel.vetter@ffwll.com>
Subject: [PATCH v3 02/16] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists
Date: Wed, 21 Oct 2020 10:56:41 +0200 [thread overview]
Message-ID: <20201021085655.1192025-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20201021085655.1192025-1-daniel.vetter@ffwll.ch>
The exynos g2d interface is very unusual, but it looks like the
userptr objects are persistent. Hence they need FOLL_LONGTERM.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: linux-mm@kvack.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-media@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.com>
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index ecede41af9b9..1e0c5a7f206e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -475,7 +475,8 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d,
goto err_free;
}
- ret = pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE,
+ ret = pin_user_pages_fast(start, npages,
+ FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM,
g2d_userptr->pages);
if (ret != npages) {
DRM_DEV_ERROR(g2d->dev,
--
2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Jan Kara" <jack@suse.cz>,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
kvm@vger.kernel.org, "Jason Gunthorpe" <jgg@ziepe.ca>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Daniel Vetter" <daniel.vetter@ffwll.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Inki Dae" <inki.dae@samsung.com>,
linux-mm@kvack.org, "Kyungmin Park" <kyungmin.park@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"John Hubbard" <jhubbard@nvidia.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dan Williams" <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v3 02/16] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists
Date: Wed, 21 Oct 2020 10:56:41 +0200 [thread overview]
Message-ID: <20201021085655.1192025-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20201021085655.1192025-1-daniel.vetter@ffwll.ch>
The exynos g2d interface is very unusual, but it looks like the
userptr objects are persistent. Hence they need FOLL_LONGTERM.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: linux-mm@kvack.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-media@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.com>
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index ecede41af9b9..1e0c5a7f206e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -475,7 +475,8 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d,
goto err_free;
}
- ret = pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE,
+ ret = pin_user_pages_fast(start, npages,
+ FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM,
g2d_userptr->pages);
if (ret != npages) {
DRM_DEV_ERROR(g2d->dev,
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: linux-s390@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
"Jan Kara" <jack@suse.cz>,
"Joonyoung Shim" <jy0922.shim@samsung.com>,
kvm@vger.kernel.org, "Jason Gunthorpe" <jgg@ziepe.ca>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Daniel Vetter" <daniel.vetter@ffwll.com>,
"Seung-Woo Kim" <sw0312.kim@samsung.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-mm@kvack.org, "Kyungmin Park" <kyungmin.park@samsung.com>,
"Kukjin Kim" <kgene@kernel.org>,
"John Hubbard" <jhubbard@nvidia.com>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Dan Williams" <dan.j.williams@intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: [PATCH v3 02/16] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists
Date: Wed, 21 Oct 2020 10:56:41 +0200 [thread overview]
Message-ID: <20201021085655.1192025-3-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20201021085655.1192025-1-daniel.vetter@ffwll.ch>
The exynos g2d interface is very unusual, but it looks like the
userptr objects are persistent. Hence they need FOLL_LONGTERM.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Inki Dae <inki.dae@samsung.com>
Cc: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: Seung-Woo Kim <sw0312.kim@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Jérôme Glisse <jglisse@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: linux-mm@kvack.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-media@vger.kernel.org
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.com>
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
index ecede41af9b9..1e0c5a7f206e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
@@ -475,7 +475,8 @@ static dma_addr_t *g2d_userptr_get_dma_addr(struct g2d_data *g2d,
goto err_free;
}
- ret = pin_user_pages_fast(start, npages, FOLL_FORCE | FOLL_WRITE,
+ ret = pin_user_pages_fast(start, npages,
+ FOLL_FORCE | FOLL_WRITE | FOLL_LONGTERM,
g2d_userptr->pages);
if (ret != npages) {
DRM_DEV_ERROR(g2d->dev,
--
2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-21 8:57 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 8:56 [PATCH v3 00/16] follow_pfn and other iomap races Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 01/16] drm/exynos: Stop using frame_vector helpers Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter [this message]
2020-10-21 8:56 ` [PATCH v3 02/16] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 03/16] misc/habana: Stop using frame_vector helpers Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 04/16] misc/habana: Use FOLL_LONGTERM for userptr Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-23 9:12 ` Daniel Vetter
2020-10-23 9:12 ` Daniel Vetter
2020-10-23 9:12 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 05/16] mm/frame-vector: Use FOLL_LONGTERM Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 06/16] media: videobuf2: Move frame_vector into media subsystem Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 07/16] mm: Close race in generic_access_phys Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 08/16] s390/pci: Remove races against pte updates Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 9:37 ` Niklas Schnelle
2020-10-21 9:37 ` Niklas Schnelle
2020-10-21 9:37 ` Niklas Schnelle
2020-10-21 13:56 ` Daniel Vetter
2020-10-21 13:56 ` Daniel Vetter
2020-10-21 13:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 09/16] mm: Add unsafe_follow_pfn Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 10/16] media/videbuf1|2: Mark follow_pfn usage as unsafe Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 11/16] vfio/type1: Mark follow_pfn " Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 12/16] PCI: Obey iomem restrictions for procfs mmap Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 12:50 ` Jason Gunthorpe
2020-10-21 12:50 ` Jason Gunthorpe
2020-10-21 12:50 ` Jason Gunthorpe
2020-10-21 14:42 ` Daniel Vetter
2020-10-21 14:42 ` Daniel Vetter
2020-10-21 14:42 ` Daniel Vetter
2020-10-21 15:13 ` Jason Gunthorpe
2020-10-21 15:13 ` Jason Gunthorpe
2020-10-21 15:13 ` Jason Gunthorpe
2020-10-21 15:54 ` Daniel Vetter
2020-10-21 15:54 ` Daniel Vetter
2020-10-21 15:54 ` Daniel Vetter
2020-10-21 16:37 ` Jason Gunthorpe
2020-10-21 16:37 ` Jason Gunthorpe
2020-10-21 16:37 ` Jason Gunthorpe
2020-10-21 19:24 ` Daniel Vetter
2020-10-21 19:24 ` Daniel Vetter
2020-10-21 19:24 ` Daniel Vetter
2020-10-21 23:20 ` Jason Gunthorpe
2020-10-21 23:20 ` Jason Gunthorpe
2020-10-21 23:20 ` Jason Gunthorpe
2020-10-22 7:00 ` Daniel Vetter
2020-10-22 7:00 ` Daniel Vetter
2020-10-22 7:00 ` Daniel Vetter
2020-10-22 11:43 ` Jason Gunthorpe
2020-10-22 11:43 ` Jason Gunthorpe
2020-10-22 11:43 ` Jason Gunthorpe
2020-10-22 13:04 ` Daniel Vetter
2020-10-22 13:04 ` Daniel Vetter
2020-10-22 13:04 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 13/16] /dev/mem: Only set filp->f_mapping Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 18:21 ` Dan Williams
2020-10-21 18:21 ` Dan Williams
2020-10-21 18:21 ` Dan Williams
2020-10-21 8:56 ` [PATCH v3 14/16] resource: Move devmem revoke code to resource framework Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 18:59 ` Dan Williams
2020-10-21 18:59 ` Dan Williams
2020-10-21 18:59 ` Dan Williams
2020-10-21 19:25 ` Daniel Vetter
2020-10-21 19:25 ` Daniel Vetter
2020-10-21 19:25 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 15/16] sysfs: Support zapping of binary attr mmaps Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` [PATCH v3 16/16] PCI: Revoke mappings like devmem Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 8:56 ` Daniel Vetter
2020-10-21 12:51 ` [PATCH v3 00/16] follow_pfn and other iomap races Jason Gunthorpe
2020-10-21 12:51 ` Jason Gunthorpe
2020-10-21 12:51 ` Jason Gunthorpe
2020-10-21 12:51 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201021085655.1192025-3-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@ffwll.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.