From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module
Date: Mon, 26 Oct 2020 07:21:33 +0100 [thread overview]
Message-ID: <20201026062133.xxuyx3fn34lvunxk@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAJ+F1C+8vorbx8smMzc3=iCPHCinVg__Ck57EjxBHqu_NfjCBA@mail.gmail.com>
Hi,
> > commit 501093207eb1ed4845e0a65ee1ce7db7b9676e0b
> > Author: Gerd Hoffmann <kraxel@redhat.com>
> > Date: Wed Sep 23 11:12:17 2020 +0200
> >
> > module: silence errors for module_load_qom_all().
> >
> Ok, but that could hide real errors, couldn't it?
It should not. If you explicitly ask for an module and it doesn't load
you'll get an error no matter what. This only skips the error message
in case loading all qom modules (for '-device help' & friends) was
requested.
> What about the proposal to have a subdir per arch with symlinks?
The modules are not per-arch. They just depend on pci or vga or usb
being present in core qemu, and some qemu-system-$arch variants don't
have that.
So -- for example -- s390x has no vga support, therefore qxl doesn't
load. qxl wasn't available before, so nothing fundamental changed. The
only difference is that you get an additional error message line from
the attempt to load the qxl module.
Why is this a problem?
take care,
Gerd
next prev parent reply other threads:[~2020-10-26 6:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 6:46 [PATCH 0/2] virtio-gpu: build pci and vga bits modular too Gerd Hoffmann
2020-10-23 6:46 ` [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module Gerd Hoffmann
2020-10-23 8:05 ` Marc-André Lureau
2020-10-23 11:01 ` Gerd Hoffmann
2020-10-23 11:26 ` Marc-André Lureau
2020-10-26 6:21 ` Gerd Hoffmann [this message]
2020-10-23 6:46 ` [PATCH 2/2] virtio-gpu: add virtio-vga module Gerd Hoffmann
2020-10-23 8:07 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026062133.xxuyx3fn34lvunxk@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.