From: "Marc-André Lureau" <marcandre.lureau@gmail.com>
To: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Cc: QEMU <qemu-devel@nongnu.org>
Subject: Re: [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module
Date: Fri, 23 Oct 2020 15:26:21 +0400 [thread overview]
Message-ID: <CAJ+F1C+8vorbx8smMzc3=iCPHCinVg__Ck57EjxBHqu_NfjCBA@mail.gmail.com> (raw)
In-Reply-To: <20201023110135.lrjq5mqvma4fzavi@sirius.home.kraxel.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
HI
On Fri, Oct 23, 2020 at 3:01 PM Gerd Hoffmann <kraxel@redhat.com> wrote:
> Hi,
>
> > Hmm, I realize we have a different behaviour when building devices as
> > modules shared by different qemu system binaries.
> >
> > It will attempt to load any kind of modules:
> >
> > ./qemu-system-m68k -kernel ~/Downloads/vmlinux-5.8.0-3-m68k -device
> > virtio-gpu-pci
> > Failed to open module:
> > /home/elmarco/src/qemu/buildnodoc/hw-display-virtio-gpu-pci.so: undefined
> > symbol: virtio_instance_init_common
> > qemu-system-m68k: -device virtio-gpu-pci: 'virtio-gpu-pci' is not a valid
> > device model name
>
> Yes. The last line is printed for non-modular builds too.
> The module load error can obviously only happen on modular builds.
>
> > $ qemu-system-m68k -device help
> > Failed to open module: /usr/lib64/qemu/hw-usb-smartcard.so: undefined
> > symbol: ccid_card_send_apdu_to_guest
> > Failed to open module: /usr/lib64/qemu/hw-display-qxl.so: undefined
> symbol:
> > vga_ioport_read
>
> That one is fixed meanwhile:
>
> commit 501093207eb1ed4845e0a65ee1ce7db7b9676e0b
> Author: Gerd Hoffmann <kraxel@redhat.com>
> Date: Wed Sep 23 11:12:17 2020 +0200
>
> module: silence errors for module_load_qom_all().
>
>
Ok, but that could hide real errors, couldn't it? What about the proposal
to have a subdir per arch with symlinks?
--
Marc-André Lureau
[-- Attachment #2: Type: text/html, Size: 1992 bytes --]
next prev parent reply other threads:[~2020-10-23 11:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 6:46 [PATCH 0/2] virtio-gpu: build pci and vga bits modular too Gerd Hoffmann
2020-10-23 6:46 ` [PATCH 1/2] virtio-gpu: add virtio-gpu-pci module Gerd Hoffmann
2020-10-23 8:05 ` Marc-André Lureau
2020-10-23 11:01 ` Gerd Hoffmann
2020-10-23 11:26 ` Marc-André Lureau [this message]
2020-10-26 6:21 ` Gerd Hoffmann
2020-10-23 6:46 ` [PATCH 2/2] virtio-gpu: add virtio-vga module Gerd Hoffmann
2020-10-23 8:07 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+F1C+8vorbx8smMzc3=iCPHCinVg__Ck57EjxBHqu_NfjCBA@mail.gmail.com' \
--to=marcandre.lureau@gmail.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.