From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> To: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com, misono.tomohiro@jp.fujitsu.com Cc: virtio-fs@redhat.com, vgoyal@Redhat.com Subject: [PULL 02/16] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Date: Mon, 26 Oct 2020 18:43:17 +0000 [thread overview] Message-ID: <20201026184331.272953-3-dgilbert@redhat.com> (raw) In-Reply-To: <20201026184331.272953-1-dgilbert@redhat.com> From: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Just noticed that although help message says default log level is INFO, it is actually 0 (EMRGE) and no mesage will be shown when error occurs. It's better to follow help message. Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Message-Id: <20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- tools/virtiofsd/passthrough_ll.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index ff53df4451..13fdb12367 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2878,12 +2878,11 @@ int main(int argc, char *argv[]) goto err_out1; } - /* - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG, - * and we don't use this log level). - */ if (opts.log_level != 0) { current_log_level = opts.log_level; + } else { + /* default log level is INFO */ + current_log_level = FUSE_LOG_INFO; } lo.debug = opts.debug; if (lo.debug) { -- 2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> To: qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com, misono.tomohiro@jp.fujitsu.com Cc: virtio-fs@redhat.com, vgoyal@redhat.com Subject: [Virtio-fs] [PULL 02/16] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Date: Mon, 26 Oct 2020 18:43:17 +0000 [thread overview] Message-ID: <20201026184331.272953-3-dgilbert@redhat.com> (raw) In-Reply-To: <20201026184331.272953-1-dgilbert@redhat.com> From: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Just noticed that although help message says default log level is INFO, it is actually 0 (EMRGE) and no mesage will be shown when error occurs. It's better to follow help message. Signed-off-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com> Message-Id: <20201008110148.2757734-1-misono.tomohiro@jp.fujitsu.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> --- tools/virtiofsd/passthrough_ll.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough_ll.c index ff53df4451..13fdb12367 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -2878,12 +2878,11 @@ int main(int argc, char *argv[]) goto err_out1; } - /* - * log_level is 0 if not configured via cmd options (0 is LOG_EMERG, - * and we don't use this log level). - */ if (opts.log_level != 0) { current_log_level = opts.log_level; + } else { + /* default log level is INFO */ + current_log_level = FUSE_LOG_INFO; } lo.debug = opts.debug; if (lo.debug) { -- 2.28.0
next prev parent reply other threads:[~2020-10-26 18:46 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-26 18:43 [PULL 00/16] virtiofs queue Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 01/16] configure: add option for virtiofsd Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` Dr. David Alan Gilbert (git) [this message] 2020-10-26 18:43 ` [Virtio-fs] [PULL 02/16] virtiofsd: passthrough_ll: set FUSE_LOG_INFO as default log_level Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 03/16] virtiofsd: add container-friendly -o sandbox=chroot option Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 04/16] tools/virtiofsd: xattr name mappings: Add option Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 05/16] tools/virtiofsd: xattr name mappings: Map client xattr names Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 06/16] tools/virtiofsd: xattr name mappings: Map server " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 07/16] tools/virtiofsd: xattr name mapping examples Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 08/16] tools/virtiofsd: xattr name mappings: Simple 'map' Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 09/16] linux/fuse.h: Pull in from Linux Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 10/16] virtiofsd: Announce FUSE_ATTR_FLAGS Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 11/16] virtiofsd: Add attr_flags to fuse_entry_param Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 12/16] virtiofsd: Add fuse_reply_attr_with_flags() Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 13/16] virtiofsd: Store every lo_inode's parent_dev Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 14/16] virtiofsd: Announce sub-mount points Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 15/16] tests/acceptance/boot_linux: Accept SSH pubkey Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [PULL 16/16] tests/acceptance: Add virtiofs_submounts.py Dr. David Alan Gilbert (git) 2020-10-26 18:43 ` [Virtio-fs] " Dr. David Alan Gilbert (git) 2020-10-27 16:58 ` [PULL 00/16] virtiofs queue Peter Maydell 2020-10-27 16:58 ` [Virtio-fs] " Peter Maydell
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201026184331.272953-3-dgilbert@redhat.com \ --to=dgilbert@redhat.com \ --cc=misono.tomohiro@jp.fujitsu.com \ --cc=mreitz@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=stefanha@redhat.com \ --cc=vgoyal@Redhat.com \ --cc=virtio-fs@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.