From: Michal Hocko <mhocko@suse.com>
To: Muchun Song <songmuchun@bytedance.com>
Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com,
akpm@linux-foundation.org, shakeelb@google.com, guro@fb.com,
iamjoonsoo.kim@lge.com, laoar.shao@gmail.com,
chris@chrisdown.name, christian.brauner@ubuntu.com,
peterz@infradead.org, mingo@kernel.org, keescook@chromium.org,
tglx@linutronix.de, esyr@redhat.com, surenb@google.com,
areber@redhat.com, elver@google.com,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 5/5] mm: memcontrol: Simplify the mem_cgroup_page_lruvec
Date: Tue, 27 Oct 2020 14:36:39 +0100 [thread overview]
Message-ID: <20201027133639.GT20500@dhcp22.suse.cz> (raw)
In-Reply-To: <20201027080256.76497-6-songmuchun@bytedance.com>
On Tue 27-10-20 16:02:56, Muchun Song wrote:
> We can reuse the code of mem_cgroup_lruvec() to simplify the code
> of the mem_cgroup_page_lruvec().
yes, removing the code duplication is reasonable. But ...
>
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> include/linux/memcontrol.h | 44 +++++++++++++++++++++++++++-----------
> mm/memcontrol.c | 40 ----------------------------------
> 2 files changed, 32 insertions(+), 52 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 95807bf6be64..5e8480e54cd8 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -451,16 +451,9 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
> return memcg->nodeinfo[nid];
> }
>
> -/**
> - * mem_cgroup_lruvec - get the lru list vector for a memcg & node
> - * @memcg: memcg of the wanted lruvec
> - *
> - * Returns the lru list vector holding pages for a given @memcg &
> - * @node combination. This can be the node lruvec, if the memory
> - * controller is disabled.
> - */
> -static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg,
> - struct pglist_data *pgdat)
> +static inline struct lruvec *mem_cgroup_node_lruvec(struct mem_cgroup *memcg,
> + struct pglist_data *pgdat,
> + int nid)
This is just wrong interface. Either take nid or pgdat. You do not want
both because that just begs for wrong usage.
--
Michal Hocko
SUSE Labs
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko-IBi9RG/b67k@public.gmane.org>
To: Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
Cc: hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
vdavydov.dev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
guro-b10kYP2dOMg@public.gmane.org,
iamjoonsoo.kim-Hm3cg6mZ9cc@public.gmane.org,
laoar.shao-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
chris-6Bi1550iOqEnzZ6mRAm98g@public.gmane.org,
christian.brauner-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org,
peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
esyr-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
surenb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
areber-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
elver-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org
Subject: Re: [PATCH 5/5] mm: memcontrol: Simplify the mem_cgroup_page_lruvec
Date: Tue, 27 Oct 2020 14:36:39 +0100 [thread overview]
Message-ID: <20201027133639.GT20500@dhcp22.suse.cz> (raw)
In-Reply-To: <20201027080256.76497-6-songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
On Tue 27-10-20 16:02:56, Muchun Song wrote:
> We can reuse the code of mem_cgroup_lruvec() to simplify the code
> of the mem_cgroup_page_lruvec().
yes, removing the code duplication is reasonable. But ...
>
> Signed-off-by: Muchun Song <songmuchun-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>
> ---
> include/linux/memcontrol.h | 44 +++++++++++++++++++++++++++-----------
> mm/memcontrol.c | 40 ----------------------------------
> 2 files changed, 32 insertions(+), 52 deletions(-)
>
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 95807bf6be64..5e8480e54cd8 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -451,16 +451,9 @@ mem_cgroup_nodeinfo(struct mem_cgroup *memcg, int nid)
> return memcg->nodeinfo[nid];
> }
>
> -/**
> - * mem_cgroup_lruvec - get the lru list vector for a memcg & node
> - * @memcg: memcg of the wanted lruvec
> - *
> - * Returns the lru list vector holding pages for a given @memcg &
> - * @node combination. This can be the node lruvec, if the memory
> - * controller is disabled.
> - */
> -static inline struct lruvec *mem_cgroup_lruvec(struct mem_cgroup *memcg,
> - struct pglist_data *pgdat)
> +static inline struct lruvec *mem_cgroup_node_lruvec(struct mem_cgroup *memcg,
> + struct pglist_data *pgdat,
> + int nid)
This is just wrong interface. Either take nid or pgdat. You do not want
both because that just begs for wrong usage.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-10-27 13:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 8:02 [PATCH 0/5] Fix some bugs in memcg/slab Muchun Song
2020-10-27 8:02 ` Muchun Song
2020-10-27 8:02 ` [PATCH 1/5] mm: memcg/slab: Fix return child memcg objcg for root memcg Muchun Song
2020-10-27 17:42 ` Roman Gushchin
2020-10-27 17:42 ` Roman Gushchin
2020-10-27 19:05 ` Roman Gushchin
2020-10-27 19:05 ` Roman Gushchin
2020-10-27 8:02 ` [PATCH 2/5] mm: memcg/slab: Fix use after free in obj_cgroup_charge Muchun Song
2020-10-27 18:31 ` Roman Gushchin
2020-10-27 18:31 ` Roman Gushchin
2020-10-27 8:02 ` [PATCH 3/5] mm: memcg/slab: Rename *_lruvec_slab_state to *_lruvec_kmem_state Muchun Song
2020-10-27 8:02 ` Muchun Song
2020-10-27 18:37 ` Roman Gushchin
2020-10-27 18:37 ` Roman Gushchin
2020-10-27 8:02 ` [PATCH 4/5] mm: memcg/slab: Fix root memcg vmstats Muchun Song
2020-10-27 8:02 ` Muchun Song
2020-10-27 18:48 ` Roman Gushchin
2020-10-27 18:48 ` Roman Gushchin
2020-10-28 2:56 ` [External] " Muchun Song
2020-10-28 2:56 ` Muchun Song
2020-10-28 2:56 ` Muchun Song
2020-10-28 3:47 ` Muchun Song
2020-10-28 3:47 ` Muchun Song
2020-10-29 0:14 ` Roman Gushchin
2020-10-29 0:14 ` Roman Gushchin
2020-10-29 6:15 ` Muchun Song
2020-10-29 6:15 ` Muchun Song
2020-11-10 1:32 ` Roman Gushchin
2020-11-10 1:32 ` Roman Gushchin
2020-11-10 2:57 ` Muchun Song
2020-11-10 2:57 ` Muchun Song
2020-11-10 2:57 ` Muchun Song
2020-10-27 8:02 ` [PATCH 5/5] mm: memcontrol: Simplify the mem_cgroup_page_lruvec Muchun Song
2020-10-27 8:02 ` Muchun Song
2020-10-27 13:36 ` Michal Hocko [this message]
2020-10-27 13:36 ` Michal Hocko
2020-10-27 14:15 ` [External] " Muchun Song
2020-10-27 14:15 ` Muchun Song
2020-10-27 14:15 ` Muchun Song
2020-10-27 14:31 ` Michal Hocko
2020-10-27 14:31 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027133639.GT20500@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=areber@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=christian.brauner@ubuntu.com \
--cc=elver@google.com \
--cc=esyr@redhat.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=keescook@chromium.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=shakeelb@google.com \
--cc=songmuchun@bytedance.com \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.