From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>,
"Marcus Cooper" <codekipper@gmail.com>,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
"Clément Péron" <peron.clem@gmail.com>
Subject: [PATCH v9 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition
Date: Tue, 27 Oct 2020 19:31:43 +0100 [thread overview]
Message-ID: <20201027183149.145165-9-peron.clem@gmail.com> (raw)
In-Reply-To: <20201027183149.145165-1-peron.clem@gmail.com>
Checkpatch script produces warning:
WARNING: function definition argument 'const struct sun4i_i2s *'
should also have an identifier name.
Let's fix this by adding identifier name to get_bclk_parent_rate()
and set_fmt() callback definition.
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
sound/soc/sunxi/sun4i-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 6a3207245ae2..4cf8a67efa4f 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -180,7 +180,7 @@ struct sun4i_i2s_quirks {
const struct sun4i_i2s_clk_div *mclk_dividers;
unsigned int num_mclk_dividers;
- unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *);
+ unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *i2s);
int (*get_sr)(unsigned int width);
int (*get_wss)(unsigned int width);
@@ -192,7 +192,7 @@ struct sun4i_i2s_quirks {
int (*set_chan_cfg)(const struct sun4i_i2s *i2s,
unsigned int channels, unsigned int slots,
unsigned int slot_width);
- int (*set_fmt)(const struct sun4i_i2s *, unsigned int);
+ int (*set_fmt)(const struct sun4i_i2s *i2s, unsigned int fmt);
};
struct sun4i_i2s {
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: devicetree@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
"Takashi Iwai" <tiwai@suse.com>,
"Marcus Cooper" <codekipper@gmail.com>,
linux-sunxi@googlegroups.com,
"Clément Péron" <peron.clem@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition
Date: Tue, 27 Oct 2020 19:31:43 +0100 [thread overview]
Message-ID: <20201027183149.145165-9-peron.clem@gmail.com> (raw)
In-Reply-To: <20201027183149.145165-1-peron.clem@gmail.com>
Checkpatch script produces warning:
WARNING: function definition argument 'const struct sun4i_i2s *'
should also have an identifier name.
Let's fix this by adding identifier name to get_bclk_parent_rate()
and set_fmt() callback definition.
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
sound/soc/sunxi/sun4i-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 6a3207245ae2..4cf8a67efa4f 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -180,7 +180,7 @@ struct sun4i_i2s_quirks {
const struct sun4i_i2s_clk_div *mclk_dividers;
unsigned int num_mclk_dividers;
- unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *);
+ unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *i2s);
int (*get_sr)(unsigned int width);
int (*get_wss)(unsigned int width);
@@ -192,7 +192,7 @@ struct sun4i_i2s_quirks {
int (*set_chan_cfg)(const struct sun4i_i2s *i2s,
unsigned int channels, unsigned int slots,
unsigned int slot_width);
- int (*set_fmt)(const struct sun4i_i2s *, unsigned int);
+ int (*set_fmt)(const struct sun4i_i2s *i2s, unsigned int fmt);
};
struct sun4i_i2s {
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: "Clément Péron" <peron.clem@gmail.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: devicetree@vger.kernel.org,
"Jernej Skrabec" <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
"Takashi Iwai" <tiwai@suse.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Marcus Cooper" <codekipper@gmail.com>,
linux-sunxi@googlegroups.com,
"Clément Péron" <peron.clem@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v9 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition
Date: Tue, 27 Oct 2020 19:31:43 +0100 [thread overview]
Message-ID: <20201027183149.145165-9-peron.clem@gmail.com> (raw)
In-Reply-To: <20201027183149.145165-1-peron.clem@gmail.com>
Checkpatch script produces warning:
WARNING: function definition argument 'const struct sun4i_i2s *'
should also have an identifier name.
Let's fix this by adding identifier name to get_bclk_parent_rate()
and set_fmt() callback definition.
Acked-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
sound/soc/sunxi/sun4i-i2s.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index 6a3207245ae2..4cf8a67efa4f 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -180,7 +180,7 @@ struct sun4i_i2s_quirks {
const struct sun4i_i2s_clk_div *mclk_dividers;
unsigned int num_mclk_dividers;
- unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *);
+ unsigned long (*get_bclk_parent_rate)(const struct sun4i_i2s *i2s);
int (*get_sr)(unsigned int width);
int (*get_wss)(unsigned int width);
@@ -192,7 +192,7 @@ struct sun4i_i2s_quirks {
int (*set_chan_cfg)(const struct sun4i_i2s *i2s,
unsigned int channels, unsigned int slots,
unsigned int slot_width);
- int (*set_fmt)(const struct sun4i_i2s *, unsigned int);
+ int (*set_fmt)(const struct sun4i_i2s *i2s, unsigned int fmt);
};
struct sun4i_i2s {
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 18:32 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 18:31 [PATCH v9 00/14] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:58 ` Pierre-Louis Bossart
2020-10-27 18:58 ` Pierre-Louis Bossart
2020-10-27 18:58 ` Pierre-Louis Bossart
2020-10-27 21:43 ` Clément Péron
2020-10-27 21:43 ` Clément Péron
2020-10-27 21:43 ` Clément Péron
2020-10-30 1:20 ` Samuel Holland
2020-10-30 1:20 ` Samuel Holland
2020-10-30 1:20 ` Samuel Holland
2020-10-30 12:58 ` Clément Péron
2020-10-30 12:58 ` Clément Péron
2020-10-30 12:58 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 02/14] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 04/14] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 05/14] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 06/14] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 07/14] ASoC: sun4i-i2s: Fix setting of FIFO modes Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron [this message]
2020-10-27 18:31 ` [PATCH v9 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 09/14] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 10/14] arm64: dts: allwinner: h6: Add I2S1 node Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 11/14] arm64: dts: allwinner: a64: Add I2S2 node Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 12/14] arm64: defconfig: Enable Allwinner i2s driver Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-28 10:18 ` [linux-sunxi] " Chen-Yu Tsai
2020-10-28 10:18 ` Chen-Yu Tsai
2020-10-28 10:18 ` Chen-Yu Tsai
2020-10-27 18:31 ` [PATCH v9 13/14] dt-bindings: sound: sun4i-i2s: Document H3 with missing RX channel possibility Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 14/14] arm: dts: sunxi: h3/h5: Add I2S2 node Clément Péron
2020-10-27 18:31 ` Clément Péron
2020-10-27 18:31 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027183149.145165-9-peron.clem@gmail.com \
--to=peron.clem@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.