From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: netdev@vger.kernel.org
Cc: "Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Daniel Drake" <dsd@gentoo.org>,
"David S. Miller" <davem@davemloft.net>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Horia Geantă" <horia.geanta@nxp.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jon Mason" <jdmason@kudzu.us>, "Jouni Malinen" <j@w1.fi>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Leon Romanovsky" <leon@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-rdma@vger.kernel.org, linux-wireless@vger.kernel.org,
"Li Yang" <leoyang.li@nxp.com>,
"Madalin Bucur" <madalin.bucur@nxp.com>,
"Ping-Ke Shih" <pkshih@realtek.com>,
"Rain River" <rain.1986.08.12@gmail.com>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Samuel Chessman" <chessman@tux.org>,
"Ulrich Kunitz" <kune@deine-taler.de>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Subject: [PATCH net-next 03/15] net: forcedeth: Replace context and lock check with a lockdep_assert()
Date: Tue, 27 Oct 2020 23:54:42 +0100 [thread overview]
Message-ID: <20201027225454.3492351-4-bigeasy@linutronix.de> (raw)
In-Reply-To: <20201027225454.3492351-1-bigeasy@linutronix.de>
nv_update_stats() triggers a WARN_ON() when invoked from hard interrupt
context because the locks in use are not hard interrupt safe. It also has
an assert_spin_locked() which was the lock check before the lockdep era.
Lockdep has way broader locking correctness checks and covers both issues,
so replace the warning and the lock assert with lockdep_assert_held().
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Rain River <rain.1986.08.12@gmail.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/nvidia/forcedeth.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 2fc10a36afa4a..7e85cf943be11 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -1666,11 +1666,7 @@ static void nv_update_stats(struct net_device *dev)
struct fe_priv *np = netdev_priv(dev);
u8 __iomem *base = get_hwbase(dev);
- /* If it happens that this is run in top-half context, then
- * replace the spin_lock of hwstats_lock with
- * spin_lock_irqsave() in calling functions. */
- WARN_ONCE(in_irq(), "forcedeth: estats spin_lock(_bh) from top-half");
- assert_spin_locked(&np->hwstats_lock);
+ lockdep_assert_held(&np->hwstats_lock);
/* query hardware */
np->estats.tx_bytes += readl(base + NvRegTxCnt);
--
2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: netdev@vger.kernel.org
Cc: "Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Madalin Bucur" <madalin.bucur@nxp.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>,
"Samuel Chessman" <chessman@tux.org>,
"Ping-Ke Shih" <pkshih@realtek.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Horia Geantă" <horia.geanta@nxp.com>,
linux-rdma@vger.kernel.org,
"Rain River" <rain.1986.08.12@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Ulrich Kunitz" <kune@deine-taler.de>, "Jouni Malinen" <j@w1.fi>,
"Daniel Drake" <dsd@gentoo.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Leon Romanovsky" <leon@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-wireless@vger.kernel.org,
"Li Yang" <leoyang.li@nxp.com>,
linux-crypto@vger.kernel.org, "Jon Mason" <jdmason@kudzu.us>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH net-next 03/15] net: forcedeth: Replace context and lock check with a lockdep_assert()
Date: Tue, 27 Oct 2020 23:54:42 +0100 [thread overview]
Message-ID: <20201027225454.3492351-4-bigeasy@linutronix.de> (raw)
In-Reply-To: <20201027225454.3492351-1-bigeasy@linutronix.de>
nv_update_stats() triggers a WARN_ON() when invoked from hard interrupt
context because the locks in use are not hard interrupt safe. It also has
an assert_spin_locked() which was the lock check before the lockdep era.
Lockdep has way broader locking correctness checks and covers both issues,
so replace the warning and the lock assert with lockdep_assert_held().
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Rain River <rain.1986.08.12@gmail.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/nvidia/forcedeth.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 2fc10a36afa4a..7e85cf943be11 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -1666,11 +1666,7 @@ static void nv_update_stats(struct net_device *dev)
struct fe_priv *np = netdev_priv(dev);
u8 __iomem *base = get_hwbase(dev);
- /* If it happens that this is run in top-half context, then
- * replace the spin_lock of hwstats_lock with
- * spin_lock_irqsave() in calling functions. */
- WARN_ONCE(in_irq(), "forcedeth: estats spin_lock(_bh) from top-half");
- assert_spin_locked(&np->hwstats_lock);
+ lockdep_assert_held(&np->hwstats_lock);
/* query hardware */
np->estats.tx_bytes += readl(base + NvRegTxCnt);
--
2.28.0
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: netdev@vger.kernel.org
Cc: "Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Madalin Bucur" <madalin.bucur@nxp.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Zhu Yanjun" <zyjzyj2000@gmail.com>,
"Samuel Chessman" <chessman@tux.org>,
"Ping-Ke Shih" <pkshih@realtek.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Horia Geantă" <horia.geanta@nxp.com>,
linux-rdma@vger.kernel.org,
"Rain River" <rain.1986.08.12@gmail.com>,
"Kalle Valo" <kvalo@codeaurora.org>,
"Ulrich Kunitz" <kune@deine-taler.de>, "Jouni Malinen" <j@w1.fi>,
"Daniel Drake" <dsd@gentoo.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
"Leon Romanovsky" <leon@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-wireless@vger.kernel.org,
"Li Yang" <leoyang.li@nxp.com>,
linux-crypto@vger.kernel.org, "Jon Mason" <jdmason@kudzu.us>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH net-next 03/15] net: forcedeth: Replace context and lock check with a lockdep_assert()
Date: Tue, 27 Oct 2020 23:54:42 +0100 [thread overview]
Message-ID: <20201027225454.3492351-4-bigeasy@linutronix.de> (raw)
In-Reply-To: <20201027225454.3492351-1-bigeasy@linutronix.de>
nv_update_stats() triggers a WARN_ON() when invoked from hard interrupt
context because the locks in use are not hard interrupt safe. It also has
an assert_spin_locked() which was the lock check before the lockdep era.
Lockdep has way broader locking correctness checks and covers both issues,
so replace the warning and the lock assert with lockdep_assert_held().
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Rain River <rain.1986.08.12@gmail.com>
Cc: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org
---
drivers/net/ethernet/nvidia/forcedeth.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 2fc10a36afa4a..7e85cf943be11 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -1666,11 +1666,7 @@ static void nv_update_stats(struct net_device *dev)
struct fe_priv *np = netdev_priv(dev);
u8 __iomem *base = get_hwbase(dev);
- /* If it happens that this is run in top-half context, then
- * replace the spin_lock of hwstats_lock with
- * spin_lock_irqsave() in calling functions. */
- WARN_ONCE(in_irq(), "forcedeth: estats spin_lock(_bh) from top-half");
- assert_spin_locked(&np->hwstats_lock);
+ lockdep_assert_held(&np->hwstats_lock);
/* query hardware */
np->estats.tx_bytes += readl(base + NvRegTxCnt);
--
2.28.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-27 22:55 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 22:54 [PATCH net-next 00/15] in_interrupt() cleanup, part 2 Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 01/15] net: orinoco: Remove BUG_ON(in_interrupt/irq()) Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 02/15] net: neterion: s2io: Replace in_interrupt() for context detection Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior [this message]
2020-10-27 22:54 ` [PATCH net-next 03/15] net: forcedeth: Replace context and lock check with a lockdep_assert() Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 04/15] net: mlx5: Replace in_irq() usage Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-31 16:59 ` Jakub Kicinski
2020-10-31 16:59 ` Jakub Kicinski
2020-10-31 16:59 ` Jakub Kicinski
2020-11-02 21:41 ` Saeed Mahameed
2020-11-02 21:41 ` Saeed Mahameed
2020-11-02 21:41 ` Saeed Mahameed
2020-11-03 19:31 ` Saeed Mahameed
2020-11-03 19:31 ` Saeed Mahameed
2020-11-03 19:31 ` Saeed Mahameed
2020-10-27 22:54 ` [PATCH net-next 05/15] net: tlan: " Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 06/15] net: airo: Invoke airo_read_wireless_stats() directly Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 07/15] net: airo: Always use JOB_STATS and JOB_EVENT Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 08/15] net: airo: Replace in_atomic() usage Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 09/15] net: hostap: Remove in_atomic() check Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 10/15] net: zd1211rw: Remove in_atomic() usage Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 11/15] net: rtlwifi: Remove in_interrupt() usage in is_any_client_connect_to_ap() Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 12/15] net: rtlwifi: Remove in_interrupt() usage in halbtc_send_bt_mp_operation() Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 13/15] soc/fsl/qbman: Add an argument to signal if NAPI processing is required Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 14/15] net: dpaa: Replace in_irq() usage Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-31 17:12 ` Jakub Kicinski
2020-10-31 17:12 ` Jakub Kicinski
2020-10-31 17:12 ` Jakub Kicinski
2020-11-01 23:04 ` Sebastian Andrzej Siewior
2020-11-01 23:04 ` Sebastian Andrzej Siewior
2020-11-01 23:04 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` [PATCH net-next 15/15] crypto: caam: " Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-27 22:54 ` Sebastian Andrzej Siewior
2020-10-30 18:29 ` [PATCH net-next 00/15] in_interrupt() cleanup, part 2 Jakub Kicinski
2020-10-30 18:29 ` Jakub Kicinski
2020-10-30 18:29 ` Jakub Kicinski
2020-10-31 17:08 ` Jakub Kicinski
2020-10-31 17:08 ` Jakub Kicinski
2020-10-31 17:08 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027225454.3492351-4-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aymen.sghaier@nxp.com \
--cc=chessman@tux.org \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=j@w1.fi \
--cc=jdmason@kudzu.us \
--cc=kuba@kernel.org \
--cc=kune@deine-taler.de \
--cc=kvalo@codeaurora.org \
--cc=leon@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rain.1986.08.12@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tglx@linutronix.de \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.