From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: linux-mtd@lists.infradead.org, jianxin.pan@amlogic.com,
liang.yang@amlogic.com, stable@vger.kernel.org
Subject: Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
Date: Wed, 28 Oct 2020 11:03:18 +0100 [thread overview]
Message-ID: <20201028110318.134be5f8@xps13> (raw)
In-Reply-To: <20201028094940.11765-1-saproj@gmail.com>
Hi Sergei,
Sergei Antonov <saproj@gmail.com> wrote on Wed, 28 Oct 2020 12:49:40
+0300:
> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
>
> Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
This patch looks good to me. Next time you send a new iteration of a
patch, please use [PATCH v2] in the subject prefix and also add a
changelog below the three dashes.
(your other patch to fix the style is still welcome)
> ---
> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 48e6dac96be6..a76afea6ea77 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
> }
>
> static void meson_nfc_dma_buffer_release(struct nand_chip *nand,
> - int infolen, int datalen,
> + int datalen, int infolen,
> enum dma_data_direction dir)
> {
> struct meson_nfc *nfc = nand_get_controller_data(nand);
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sergei Antonov <saproj@gmail.com>
Cc: liang.yang@amlogic.com, linux-mtd@lists.infradead.org,
stable@vger.kernel.org, jianxin.pan@amlogic.com
Subject: Re: [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments
Date: Wed, 28 Oct 2020 11:03:18 +0100 [thread overview]
Message-ID: <20201028110318.134be5f8@xps13> (raw)
In-Reply-To: <20201028094940.11765-1-saproj@gmail.com>
Hi Sergei,
Sergei Antonov <saproj@gmail.com> wrote on Wed, 28 Oct 2020 12:49:40
+0300:
> Arguments 'infolen' and 'datalen' to meson_nfc_dma_buffer_release() were mixed up.
>
> Fixes: 8fae856c53500 ("mtd: rawnand: meson: add support for Amlogic NAND flash controller")
> Cc: stable@vger.kernel.org
> Signed-off-by: Sergei Antonov <saproj@gmail.com>
This patch looks good to me. Next time you send a new iteration of a
patch, please use [PATCH v2] in the subject prefix and also add a
changelog below the three dashes.
(your other patch to fix the style is still welcome)
> ---
> drivers/mtd/nand/raw/meson_nand.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/raw/meson_nand.c b/drivers/mtd/nand/raw/meson_nand.c
> index 48e6dac96be6..a76afea6ea77 100644
> --- a/drivers/mtd/nand/raw/meson_nand.c
> +++ b/drivers/mtd/nand/raw/meson_nand.c
> @@ -510,7 +510,7 @@ static int meson_nfc_dma_buffer_setup(struct nand_chip *nand, void *databuf,
> }
>
> static void meson_nfc_dma_buffer_release(struct nand_chip *nand,
> - int infolen, int datalen,
> + int datalen, int infolen,
> enum dma_data_direction dir)
> {
> struct meson_nfc *nfc = nand_get_controller_data(nand);
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-10-29 0:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:49 [PATCH] mtd: meson: fix meson_nfc_dma_buffer_release() arguments Sergei Antonov
2020-10-28 9:49 ` Sergei Antonov
2020-10-28 10:03 ` Miquel Raynal [this message]
2020-10-28 10:03 ` Miquel Raynal
2020-10-30 2:22 ` Liang Yang
2020-10-30 2:22 ` Liang Yang
2020-10-30 17:27 ` Miquel Raynal
2020-10-30 17:27 ` Miquel Raynal
-- strict thread matches above, loose matches on Subject: below --
2020-10-27 22:20 sa
2020-10-28 8:12 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028110318.134be5f8@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=jianxin.pan@amlogic.com \
--cc=liang.yang@amlogic.com \
--cc=linux-mtd@lists.infradead.org \
--cc=saproj@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.