From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
"Russell King" <linux@armlinux.org.uk>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback
Date: Thu, 29 Oct 2020 17:49:45 +1100 [thread overview]
Message-ID: <20201029064944.GA19977@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXGfwuY_uEGT83QpoUZwy9X=6k7zaxHs2kFrdsArKpVpOw@mail.gmail.com>
On Wed, Oct 28, 2020 at 10:06:58AM +0100, Ard Biesheuvel wrote:
>
> Not sure what is happening here: IIRC the intention was to rely on the
> fact that only the sync cbc(aes) implementation needs the fallback,
> and therefore, allocating a sync skcipher explicitly would avoid this
> recursion.
>
> Herbert?
It works only if everything is built in. If cbc is built as a
module then you need Horia's patch to prevent a loop.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
"Russell King" <linux@armlinux.org.uk>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"NXP Linux Team" <linux-imx@nxp.com>
Subject: Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback
Date: Thu, 29 Oct 2020 17:49:45 +1100 [thread overview]
Message-ID: <20201029064944.GA19977@gondor.apana.org.au> (raw)
In-Reply-To: <CAMj1kXGfwuY_uEGT83QpoUZwy9X=6k7zaxHs2kFrdsArKpVpOw@mail.gmail.com>
On Wed, Oct 28, 2020 at 10:06:58AM +0100, Ard Biesheuvel wrote:
>
> Not sure what is happening here: IIRC the intention was to rely on the
> fact that only the sync cbc(aes) implementation needs the fallback,
> and therefore, allocating a sync skcipher explicitly would avoid this
> recursion.
>
> Herbert?
It works only if everything is built in. If cbc is built as a
module then you need Horia's patch to prevent a loop.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-29 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 9:03 [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback Horia Geantă
2020-10-28 9:03 ` Horia Geantă
2020-10-28 9:06 ` Ard Biesheuvel
2020-10-28 9:06 ` Ard Biesheuvel
2020-10-28 9:43 ` Horia Geantă
2020-10-28 9:43 ` Horia Geantă
2020-10-29 6:49 ` Herbert Xu [this message]
2020-10-29 6:49 ` Herbert Xu
2020-11-06 7:02 ` Herbert Xu
2020-11-06 7:02 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201029064944.GA19977@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=horia.geanta@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.